Prefer static imports instead of copying the constant #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
approved these changes
Feb 5, 2021
mcculls
force-pushed
the
mcculls/configStaticImports
branch
2 times, most recently
from
d74dfff
to
15086c4
Compare
mcculls
force-pushed
the
mcculls/configStaticImports
branch
from
15086c4
to
e756718
Compare
tylerbenson
reviewed
Feb 5, 2021
tylerbenson
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
After further consideration, I think we can move forward with this change. The Config class was marked as @Deprecated when I moved those fields out to their respective classes, which was some time ago. I also moved Config out of dd-trace-api, so this will only potentially impact dd-trace-ot users (who really should't be using the javaagent). We should still document this in our release notes though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just cleaning up how config gets these constants, no functional change