Centralize route handling and add a flag for resource naming #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinsba
force-pushed
the
bds/resource-name-raw
branch
13 times, most recently
from
4b7c685
to
0fb19fa
Compare
devinsba
force-pushed
the
bds/resource-name-raw
branch
3 times, most recently
from
16b3fbe
to
0802823
Compare
devinsba
force-pushed
the
bds/resource-name-raw
branch
3 times, most recently
from
72448e6
to
356de57
Compare
devinsba
force-pushed
the
bds/resource-name-raw
branch
11 times, most recently
from
f4f1300
to
caa9121
Compare
devinsba
force-pushed
the
bds/resource-name-raw
branch
3 times, most recently
from
45b99f7
to
3eba1d6
Compare
lpriima
approved these changes
May 3, 2021
devinsba
force-pushed
the
bds/resource-name-raw
branch
2 times, most recently
from
085d820
to
56db5b6
Compare
tylerbenson
reviewed
May 3, 2021
| @@ -52,6 +52,7 @@ class PlayServerTest extends HttpServerTest<TestServer> { | |||
| "$Tags.HTTP_URL" String | |||
| "$Tags.HTTP_METHOD" String | |||
| "$Tags.HTTP_STATUS" Integer | |||
| // "$Tags.HTTP_ROUTE" String | |||
There was a problem hiding this comment.
This is the bug in the tests that I mentioned earlier, the play tests don't wire the server together like a real app
There was a problem hiding this comment.
What's the path to resolution then? Is this (and others below) an acceptable deviation or does it need to be dealt with?
There was a problem hiding this comment.
I think we added something to the doc yesterday that this needs to be fixed so its on the radar
tylerbenson
reviewed
May 3, 2021
tylerbenson
reviewed
May 3, 2021
...p/src/main/java/datadog/trace/bootstrap/instrumentation/decorator/RouteHandlerDecorator.java
Outdated
Show resolved
Hide resolved
tylerbenson
reviewed
May 3, 2021
...p/src/main/java/datadog/trace/bootstrap/instrumentation/decorator/RouteHandlerDecorator.java
Show resolved
Hide resolved
devinsba
force-pushed
the
bds/resource-name-raw
branch
2 times, most recently
from
2e90c75
to
cd4521d
Compare
devinsba
force-pushed
the
bds/resource-name-raw
branch
from
cd4521d
to
ba115b4
Compare
tylerbenson
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers that don't do routes that probably should: