Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create noop scopes for akka messaging unless necessary #2688

Merged
merged 1 commit into from
May 5, 2021

Conversation

bantonsson
Copy link
Contributor

This change tries to minimize the work done when there is no span travelling across an akka message send.

Here are some numbers for an akka message sending benchmark that don't have any spans active.

Version Average time (s) stdev overhead %
none 1.676 0.132 0.000
0.75.0 4.163 0.588 148.426
0.76.0 4.675 0.845 178.973
0.76.1 4.051 0.473 141.741
0.77.0 11.723 3.888 599.550
0.78.1 9.756 3.390 482.148
0.78.2 7.253 0.811 332.792
0.78.3 4.276 0.364 155.163
0.79.0 4.147 0.381 147.496
this PR 1.980 0.218 18.169

@bantonsson bantonsson added the tag: performance Performance related changes label May 5, 2021
@bantonsson bantonsson self-assigned this May 5, 2021
@bantonsson bantonsson requested a review from a team as a code owner May 5, 2021 13:15
@bantonsson bantonsson merged commit 3d9e326 into master May 5, 2021
@bantonsson bantonsson deleted the ban/akka-noop-optimization branch May 5, 2021 15:16
@github-actions github-actions bot added this to the 0.80.0 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: performance Performance related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants