Change AgentTracer.activeScope() to return AgentScope #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
reviewed
Jul 8, 2021
dd-trace-ot/src/main/java/datadog/opentracing/CustomScopeManagerWrapper.java
Show resolved
Hide resolved
mcculls
force-pushed
the
mcculls/returnAgentScope
branch
from
c1edd43
to
2b9a9b5
Compare
mcculls
force-pushed
the
mcculls/returnAgentScope
branch
5 times, most recently
from
0e23627
to
820d7f2
Compare
mcculls
added
comp: core
bantonsson
reviewed
Nov 8, 2021
dd-trace-ot/src/test/groovy/datadog/opentracing/CustomScopeManagerTest.groovy
Show resolved
Hide resolved
bantonsson
approved these changes
Nov 8, 2021
mcculls
force-pushed
the
mcculls/returnAgentScope
branch
from
820d7f2
to
ed639c2
Compare
devinsba
reviewed
Dec 28, 2021
| } else { | ||
| return new OTScopeManager.OTScope((AgentScope) scope, finishSpanOnClose, this); | ||
| return new CustomScope(scope); |
There was a problem hiding this comment.
@mcculls I'm wondering what the reason for this change was?
devinsba
reviewed
Dec 28, 2021
|
|
||
| @Override | ||
| public AgentSpan span() { | ||
| return toAgentSpan(delegate.span()); |
There was a problem hiding this comment.
Unfortunately adding this class makes dd-trace-ot fail compile time checks for Graalvm because of this call when using opentracing 0.33, because Scope.span() was removed. Even if this code can never actually be executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a number of internal APIs and some non-public types in
dd-trace-otIt also updates a test to check that internal scopes are handled correctly when a custom scope manager is used.