[AppSec] Added smoke test to validate WAF #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinsba
reviewed
Aug 17, 2021
ValentinZakharov
force-pushed
the
vzakharov/appsec_smoke_test
branch
from
8ecba41
to
11c4b29
Compare
ValentinZakharov
force-pushed
the
vzakharov/appsec_smoke_test
branch
6 times, most recently
from
47b9aa2
to
36d05c3
Compare
bantonsson
requested changes
Nov 29, 2021
dd-java-agent/appsec/src/main/java/com/datadog/appsec/report/ReportStrategy.java
Outdated
Show resolved
Hide resolved
| class SpringBootSmokeTest extends AbstractAppSecServerSmokeTest { | ||
|
|
||
| // Estimate for the amount of time instrumentation, plus request, plus some extra | ||
| public static final int TIMEOUT_SECS = 30 |
There was a problem hiding this comment.
The comment makes no sense to me, since it's the total time it would take from the request is done to the AppSec attack has been reported.
There was a problem hiding this comment.
Ah, I'm sorry, blind copy-paste. Removed redundant code.
| @@ -858,6 +861,10 @@ private Config(final ConfigProvider configProvider) { | |||
| appSecEnabled = configProvider.getBoolean(APPSEC_ENABLED, DEFAULT_APPSEC_ENABLED); | |||
| appSecRulesFile = configProvider.getString(APPSEC_RULES_FILE, null); | |||
|
|
|||
| // Default AppSec report timeout min=5, max=60 | |||
| appSecReportMaxTimeout = configProvider.getInteger(APPSEC_REPORT_TIMEOUT_SEC, 30); | |||
There was a problem hiding this comment.
Comment says 60, but code says 30
There was a problem hiding this comment.
Old comment - fixed.
There was a problem hiding this comment.
Well, the comment might be old, but the tests seem to think that it should be 60 seconds since this fails subsequent event of same type should wait 1 min
ValentinZakharov
force-pushed
the
vzakharov/appsec_smoke_test
branch
3 times, most recently
from
607dddd
to
fc23b75
Compare
bantonsson
approved these changes
Nov 30, 2021
ValentinZakharov
force-pushed
the
vzakharov/appsec_smoke_test
branch
2 times, most recently
from
0eda189
to
c82c814
Compare
ValentinZakharov
force-pushed
the
vzakharov/appsec_smoke_test
branch
from
c82c814
to
2fd53d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppSec smoke test implemented based on SpringBoot smoke test.
Added AppSec report simulator to track if the malicious request reported correctly.
Thу test is a sequence of 200 malicious requests. Each request will be detected by AppSec and should be sent 200 events to the backend with corresponding information about the attack. To validate AppSec we are checking events reported by AppSec.
Since the event dispatch mechanism has a timeout (minimum and maximum time between dispatches), I added the
appsec.report.timeoutconfiguration option to force the maximum interval between dispatches. Thus, for tests, we set the value-Dappsec.report.timeout=0, which allows perform tests fast as possible (event commitment happens almost instantly).To use the additional option, I had to modify
Config.java, but after switching to AppSec Span Interface, I need to get rid of this option.