Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AgentInstaller ignores and @Trace naming #303

Merged
merged 1 commit into from
May 3, 2018
Merged

Fix AgentInstaller ignores and @Trace naming #303

merged 1 commit into from
May 3, 2018

Conversation

tylerbenson
Copy link
Contributor

The ignore:

.ignore(any(), skipClassLoader());

Was replacing the other ones.

And @Trace for anonymous classes wasn't including the parent class name, so it was only the method name.

@tylerbenson tylerbenson added type: bug comp: core Tracer core inst: others All other instrumentations labels May 2, 2018
@tylerbenson tylerbenson added this to the 0.8.0 milestone May 2, 2018
@tylerbenson tylerbenson requested a review from realark May 2, 2018 01:59
@tylerbenson tylerbenson force-pushed the tyler/agent-installer branch 2 times, most recently from dbdacbf to c3e22c7 Compare May 3, 2018 02:30
@tylerbenson tylerbenson merged commit 4af0c7f into master May 3, 2018
@tylerbenson tylerbenson deleted the tyler/agent-installer branch May 3, 2018 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realark realark realark approved these changes

Assignees
No one assigned
Labels
comp: core Tracer core inst: others All other instrumentations type: bug
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tylerbenson @realark