Make EndpointEvent durational to ease debugging any slack issues #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbachorik
force-pushed
the
jb/durational_endpoint_event
branch
2 times, most recently
from
494ed2a
to
987ba1d
Compare
jbachorik
force-pushed
the
jb/durational_endpoint_event
branch
from
c0f83f7
to
2303dfc
Compare
jbachorik
force-pushed
the
jb/durational_endpoint_event
branch
from
2303dfc
to
ab2d69b
Compare
luhenry
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to be having a problem with a slack between the checkpoints generated for a certain local root span and the corresponding
EndpointEvent- the checkpoints may all get written into a recording preceding the one containing theEndpointEventfor that particular local root span.In order to ease debugging and allow us to confirm or reject this assumption this PR is modifying the
EndpointEventto capture the start and end time as well as the time it took to handle that endpoint.Most of the changes are in the checkpoint tests where it is necessary to match a new call
onRootSpanStarted()when a local root span is created/started.The rest is rather straightforward and the only 'controversial' thing may be adding a new volatile field to
DDSpan- if there is a better way to achieve this functionality I would gladly make the change, so please let me know.