[CIAPP] Avoid sending non-CIVisibility traces if CIVisibility mode is enabled.
#3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguezhdez
force-pushed
the
drodriguezhdez/civisibility_trace_interceptor
branch
2 times, most recently
from
d749ee6
to
0e0d5b4
Compare
bantonsson
approved these changes
Nov 25, 2021
drodriguezhdez
force-pushed
the
drodriguezhdez/civisibility_trace_interceptor
branch
from
0e0d5b4
to
e23bcb2
Compare
drodriguezhdez
force-pushed
the
drodriguezhdez/civisibility_trace_interceptor
branch
from
e23bcb2
to
176dcb4
Compare
drodriguezhdez
deleted the
drodriguezhdez/civisibility_trace_interceptor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
CiVisibilityTraceInterceptorthat applies the following changes:test, the entire trace is dropped.test, we ensure all spans have the CI Visibility origin metadata.Context:
The
CI Visibilitymode can use the same integrations used by theTracingmode to have the same visibility in end-to-end tests. That means a test span potentially can have HTTP, SQL, Kafka, etc. children spans. This fact may have implications with Billing.We want to ensure that all generated traces are billed by CI App and not by APM if CI Visibility is enabled.