Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Forwarded' header extraction #3237

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Fix 'Forwarded' header extraction #3237

merged 1 commit into from
Dec 6, 2021

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Dec 6, 2021 •
edited

Previously we weren't extracting Forwarded headers because the code was only called when the header started with X

(Forwarded is the new standard header replacing X-Forwarded-For etc.)

@mcculls mcculls added the comp: context propagation Trace context propagation label Dec 6, 2021
@mcculls mcculls force-pushed the mcculls/fixForwardedHeaderExtraction branch from 25e783b to 2c0157b Compare December 6, 2021 10:57
@mcculls mcculls marked this pull request as ready for review December 6, 2021 10:57
@mcculls mcculls requested a review from a team as a code owner December 6, 2021 10:57
bantonsson
bantonsson approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops...

@mcculls mcculls merged commit e430f48 into master Dec 6, 2021
@mcculls mcculls deleted the mcculls/fixForwardedHeaderExtraction branch December 6, 2021 12:36
@github-actions github-actions bot added this to the 0.91.0 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bantonsson bantonsson bantonsson approved these changes

Assignees
No one assigned
Labels
comp: context propagation Trace context propagation
Projects
None yet
Milestone
0.91.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcculls @bantonsson