Adjust Apache/Drill tracing to cover the shared superclass from Apache/Calcite that the Drill class delegates to #3424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DrillPreparedStatementImpl
extendsAvaticaPreparedStatement
and while it does override most of its methods it doesn’t overrideexecuteQuery
- this means we need to move up to traceAvaticaPreparedStatement
to catch that callTracing the super-class is safe here because
DrillPreparedStatementImpl
ends up calling theAvaticaPreparedStatement
methods to do the actual work of talking to the database - theDrillPreparedStatementImpl
sub-class just adds some pre/post-condition checks that we don’t need to cover with tracing, as well as some non-JDBC methods specific to Apache/DrillThis is slightly complicated by the fact that drill-jdbc-all-1.15.0.jar refactors its copy of
AvaticaPreparedStatement
under theoadd
prefix, so we need to add it twice - once with and once without the prefix