Remove unused Method handles from Hibernate instrumentation #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the decorator (except for method name which byte-buddy makes available in cached form by using '#m') Removing them should reduce tracer overhead on every hibernate call. (* see warning in the @Advice.Origin javadoc)
devinsba
approved these changes
Apr 13, 2022
| @@ -25,7 +24,6 @@ public class SessionMethodUtils { | |||
| public static <TARGET, ENTITY> SessionState startScopeFrom( | |||
| final ContextStore<TARGET, SessionState> contextStore, | |||
| final TARGET spanKey, | |||
| final Method origin, | |||
There was a problem hiding this comment.
I wonder if there was intent to use this at some point. Nice catch!
There was a problem hiding this comment.
From the git history it looks like a leftover from changes to reduce the cost of computing the operationName.
bantonsson
approved these changes
Apr 13, 2022
| @@ -25,7 +24,6 @@ public class SessionMethodUtils { | |||
| public static <TARGET, ENTITY> SessionState startScopeFrom( | |||
| final ContextStore<TARGET, SessionState> contextStore, | |||
| final TARGET spanKey, | |||
| final Method origin, | |||
There was a problem hiding this comment.
From the git history it looks like a leftover from changes to reduce the cost of computing the operationName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These jlr.Method values are recreated* on every read and are not used in the decorator
(except for method name which byte-buddy makes available in cached form by using '#m')
Removing them should reduce tracer overhead on every hibernate call.
* see warning in the @Advice.Origin javadoc