Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAF: redaction and misc changes #3498

Merged
merged 8 commits into from
Apr 14, 2022
Merged

WAF: redaction and misc changes #3498

merged 8 commits into from
Apr 14, 2022

Conversation

cataphract
Copy link
Contributor

  • Implements redaction of sensitive data in the WAF reports
  • Changes the type of the cookie data to be a map, so that redaction can work properly on the keys.
  • Reports _dd.appsec.waf.version once
  • Reports _dd.appsec.event_rules.version on every request, rather than once.
  • Fixes the names of a couple of tag names.

@cataphract cataphract added the comp: asm waf Application Security Management (WAF) label Apr 13, 2022
luhenry
luhenry approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@luhenry luhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the changes in dd-java-agent/agent-profiling/profiling-context/src/test/java/com/datadog/profiling/context/AllocatorsTest.java.

@cataphract cataphract merged commit 8d425c8 into master Apr 14, 2022
@cataphract cataphract deleted the glopes/waf-misc branch April 14, 2022 11:34
@github-actions github-actions bot added this to the 0.100.0 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhenry luhenry luhenry approved these changes

@bantonsson bantonsson bantonsson approved these changes

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF)
Projects
None yet
Milestone
0.100.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cataphract @luhenry @bantonsson @ValentinZakharov