Remove classloader toString() logging from generated ExceptionHandler #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Apr 19, 2022
bantonsson
approved these changes
Apr 19, 2022
devinsba
force-pushed
the
bds/classloader-logging
branch
from
dec5cdb
to
468b5dc
Compare
devinsba
force-pushed
the
bds/classloader-logging
branch
from
468b5dc
to
5724416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes the classloader value from the ExceptionHandler code that is generated. It will cause an instrumentation error on some classloaders that have extremely long toString values
Motivation
Additional Notes