Add '-Ddd.resolver.type.pool.size' to control maximum size of resolver's type pool #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
approved these changes
Apr 20, 2022
devinsba
approved these changes
Apr 20, 2022
mcculls
force-pushed
the
mcculls/configurableTypePoolSize
branch
3 times, most recently
from
0737cd7
to
3b8c554
Compare
mcculls
force-pushed
the
mcculls/configurableTypePoolSize
branch
from
3b8c554
to
4b38e89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Controls how many type definitions are kept in the resolver's type pool before it starts evicting old entries.
Motivation
The default pool size of 64 (per-classloader) is likely too small for large enterprise applications leading to class resources repeatedly being requested, slowing down startup. Providing a flag to control its size allows users to accept a larger pool to reduce startup costs with the trade-off being potentially increased memory use.
Additional Notes
The equivalent environment variable is
DD_RESOLVER_TYPE_POOL_SIZE