[AppSec] Fixed Play/Akka double instrumentation #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
reviewed
Apr 21, 2022
dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/AppSecRequestContext.java
Outdated
Show resolved
Hide resolved
ValentinZakharov
force-pushed
the
vzakharov/double_instr
branch
from
fb7fa3f
to
6535666
Compare
bantonsson
approved these changes
Apr 21, 2022
devinsba
approved these changes
Apr 21, 2022
ValentinZakharov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
When setting the same data in the context of the request, the same data will be ignored for further analysis using AppSec WAF.
Motivation
Issue reported by customer: #3484
Additional Notes
Different instrumentations (Play and Akka) populate same data to distinct spans, but all of them consolidates in same AppSecRequestContext, which cause forbidden data replacement. As a workaround we ignores replacement if the values are the same.