Remove pre-sort requirement when building tries #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/trieRemovePreSortRequirement
branch
3 times, most recently
from
c372921
to
d0c46c6
Compare
mcculls
force-pushed
the
mcculls/trieRemovePreSortRequirement
branch
2 times, most recently
from
d37ff05
to
d7d7070
Compare
bantonsson
approved these changes
May 18, 2022
internal-api/src/main/java/datadog/trace/util/ClassNameTrie.java
Outdated
Show resolved
Hide resolved
mcculls
force-pushed
the
mcculls/trieRemovePreSortRequirement
branch
from
3e6589f
to
a704fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes the requirement that the
ClassNameTrie.Builderrequires the class-name mappings to be sorted before generating the trie. The builder now accepts class-name mappings out-of-order and manipulates the trie array to add the necessary branches/nodes.Motivation
This means we can support incremental trie building, which we can then drive from recorded matching results.