Decouple hierarchy matching #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/decoupleHierarchyMatching
branch
from
efdae19
to
6550689
Compare
mcculls
added
type: refactoring
and removed
tag: do not merge
devinsba
approved these changes
May 17, 2022
...agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleGradlePlugin.java
Show resolved
Hide resolved
|
Do you have envisioned experiments you want to try? |
|
@devinsba yes - this factory approach is needed so we can swap in some faster matchers that track results in bit-sets as well as add support for async matching, while still allowing a fall-back to the original approach in case we see issues in the field. |
… creates AdviceTransformations to scrape advice classes) then we may as well use them in the constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pluggable hierarchy matchers so we can trial new techniques while still supporting the old approach.