Support span activation intervals size limit #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbachorik
force-pushed
the
jb/context_intervals_limits
branch
2 times, most recently
from
2680021
to
e12ab97
Compare
jbachorik
force-pushed
the
jb/context_intervals_limits
branch
from
e12ab97
to
3126b0f
Compare
jbachorik
force-pushed
the
jb/context_intervals_limits
branch
from
dfbbacf
to
e3f3007
Compare
luhenry
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This adds hard limits on the size of the data representing the span activation intervals.
Motivation
The span metadata size (this includes the span tags) is limited to 25000 bytes - therefore it does not make sense to generate and keep more data if that is going to be discarded anyway. It is better to have the limit applied directly in the agent where we have control over when to cut off the data collection (saving CPU cycles) and the data export (where we can assure valid data).
Additional Notes
For the sakes of minimizing the costs of
Long.valueOf()this change is also adding a few classes from JCTools which are necessary to supportNonBlockingHashMapLongclass that is used instead ofConcurrentHashMap.The JCTools classes are stripped to the bare minimum required for the code to run and they are not adding a significant weight to the agent jar.