Simple instrumentation for the renaissance benchmarks #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinsba
approved these changes
May 25, 2022
...ance/src/main/java/datadog/trace/instrumentation/renaissance/RenaissanceInstrumentation.java
Outdated
Show resolved
Hide resolved
jbachorik
force-pushed
the
jb/renaissance_instr
branch
from
e92785b
to
789ec82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds a simple span instrumentation for Renaissance benchmarks
Motivation
Renaissance bechmarks are a good way to fully saturate a JVM with concurrent work - that way creating the opportunity for profiling the tracer and its extensions (in my case the new span activation intervals functionality) under extreme load.
Unfortunately, there are no 'entry' points in the benchmarks and as such the root span is not created and the whole tracer functionality is skipped. With this simple instrumentation each single benchmark run will have its own root span.
Additional Notes
There are no tests included - I was not able to find a renaissance benchmark artifact in the maven central and I would argue that the implementation itself is extremely simple and missing tests are not a hindrance.