Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument gRPC 1.5.0+ #388

Merged
merged 3 commits into from
Jul 23, 2018
Merged

Instrument gRPC 1.5.0+ #388

merged 3 commits into from
Jul 23, 2018

Conversation

tylerbenson
Copy link
Contributor

Adds spans for the duration of the connection and child spans for each message.
Also propagates the trace using the metadata object.

@tylerbenson tylerbenson added the inst: others All other instrumentations label Jul 19, 2018
@tylerbenson tylerbenson requested a review from realark July 19, 2018 02:58
@tylerbenson tylerbenson changed the title Instrument gRPC Instrument gRPC 1.5.0+ Jul 19, 2018
@tylerbenson tylerbenson force-pushed the tyler/grpc branch 3 times, most recently from 2faeedb to c1be4cc Compare July 19, 2018 03:40
Adds spans for the duration of the connection and child spans for each message.
Also propagates the trace using the metadata object.
Copy link
Contributor

@realark realark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work. It's nice when there's a clean listener/interceptor api for us to use.

@tylerbenson
Copy link
Contributor Author

Yeah, that's why I targeted 1.5+ because that's when the server interceptor was added. (grpc/grpc-java#3118)

@tylerbenson tylerbenson merged commit 9988c87 into master Jul 23, 2018
@tylerbenson tylerbenson deleted the tyler/grpc branch July 23, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inst: others All other instrumentations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants