Allow service name mapping to apply without setting the tag. #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-kolya
reviewed
Jul 23, 2018
| @@ -522,6 +525,10 @@ private DDSpanContext buildSpanContext() { | |||
| serviceName = DDTracer.this.serviceName; | |||
| } | |||
|
|
|||
| if (serviceNameMappings.containsKey(serviceName)) { | |||
| serviceName = serviceNameMappings.get(serviceName); | |||
| } | |||
There was a problem hiding this comment.
could you please clarify how this is different from just setting service.name?
There was a problem hiding this comment.
See the latest commit. I realized this didn't work and was fixing it... didn't expect anyone to be looking at it already . 😉
|
This would be a good feature to use with a |
tylerbenson
force-pushed
the
tyler/service-mapping
branch
from
33dc43e
to
f8176ba
Compare
Previously the mapping only applied when the `service.name` tag was set, not on the default or configured service name.
tylerbenson
force-pushed
the
tyler/service-mapping
branch
from
f8176ba
to
84927a9
Compare
Otherwise the context decorator doesn’t know if it should change the span name or not.
tylerbenson
force-pushed
the
tyler/service-mapping
branch
from
84927a9
to
7807615
Compare
mar-kolya
approved these changes
Jul 25, 2018
If done in the decorator, it would be applied twice. Only want it done once.
tylerbenson
force-pushed
the
tyler/service-mapping
branch
from
7f31cee
to
5fe08d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the mapping only applied when the
service.nametag was set, not on the default or configured service name.