Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java10 support #400

Merged
merged 6 commits into from
Jul 27, 2018
Merged

Java10 support #400

merged 6 commits into from
Jul 27, 2018

Conversation

mar-kolya
Copy link
Contributor

@mar-kolya mar-kolya commented Jul 24, 2018 •
edited

Allow agent to be run under Java10 without additional JVM arguments

@mar-kolya mar-kolya changed the title Mar kolya/java10 support Java10 support Jul 24, 2018
@mar-kolya mar-kolya added the tag: do not merge Do not merge changes label Jul 24, 2018
@tylerbenson
Copy link
Contributor

Which change actually fixed the problem?

@mar-kolya
Copy link
Contributor Author

mar-kolya commented Jul 25, 2018 •
edited

@tylerbenson so far main commit here is Fix SpockRunner BootstrapJar creation under Java9+ which fixes tests and makes build pass without --add-opens - I'm yet to look of anything else needs to be done.

@mar-kolya mar-kolya force-pushed the mar-kolya/java10-support branch 3 times, most recently from a571168 to dc8c323 Compare July 25, 2018 13:00
@mar-kolya mar-kolya requested a review from realark July 27, 2018 16:54
@mar-kolya mar-kolya removed the tag: do not merge Do not merge changes label Jul 27, 2018
@mar-kolya
Copy link
Contributor Author

mar-kolya commented Jul 27, 2018 •
edited

We still see warnings under Java10, but this PR fixes some stuff and should be self-contained enough to get merged

realark
realark reviewed Jul 27, 2018
View reviewed changes
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/HelperInjector.java
"Class was erroneously loaded on the System classloader: " + name);
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mar-kolya mar-kolya merged commit fadce5c into master Jul 27, 2018
@mar-kolya mar-kolya deleted the mar-kolya/java10-support branch July 27, 2018 17:38
@tylerbenson tylerbenson added this to the 0.12.0 milestone Aug 1, 2018
@tylerbenson tylerbenson added the comp: core Tracer core label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realark realark realark approved these changes

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mar-kolya @tylerbenson @realark