Add span for jax-rs representing controller execution #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add additional `span.origin.type` tags for better visibility.
tylerbenson
force-pushed
the
tyler/jax-rs-improvements
branch
from
b295446
to
d5cc84e
Compare
Might be slightly redundant given `jsp.requestURL` but consistent with other instrumentation.
tylerbenson
force-pushed
the
tyler/jax-rs-improvements
branch
from
2107e6d
to
984bc75
Compare
mar-kolya
reviewed
Aug 13, 2018
|
|
||
| // Now create a span representing the method execution. | ||
|
|
||
| final Class<?> clazz = method.getDeclaringClass(); |
There was a problem hiding this comment.
If this expected to be a 'declaring class' - is seems like it would be possible for clients to have some sort of a 'parent' class where methods are defined and multiple child classes that actually implement things. Having parent class in spans may be confusing. Would it make sense to use actual object's class name here?
There was a problem hiding this comment.
This is the same behavior that @Trace has. Perhaps that should be changed as well? Maybe we need better tests around this? (I'd suggest that be a separate task/pr...)
There was a problem hiding this comment.
Sounds good. I would appreciate if you could create a task for that, otherwise PR looks good.
Thanks!
mar-kolya
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add additional
span.origin.typetags for better visibility.Similar concept as #430, but for jax-rs.
#305