Register Datadog classloader as parallel capable #448
Conversation
realark
commented
Aug 17, 2018
realark
commented
- Register Datadog classloader as parallel capable and add a test to assert instance is not locked on during classloading
| @Override | ||
| public Object getClassLoadingLock(String className) { | ||
| return super.getClassLoadingLock(className); | ||
| } |
There was a problem hiding this comment.
It looks like this method already had enough visibility to not needing this. If you remove this method tests still pass.
There was a problem hiding this comment.
Interesting. Looks like a protected method is visible to spock tests. Pretty useful for avoiding this problem of escalating exposure for testing. Removing this method.
| boolean applicationDidNotDeadlock = true | ||
|
|
||
| then: | ||
| applicationDidNotDeadlock |
There was a problem hiding this comment.
Failure of this test would result in test runs just hanging forever. Would it be possible to implement this so test actually exits on failure? E.g. using two additional threads and making 'main' thread just wait reasonable amount of time?
There was a problem hiding this comment.
👍 I added another thread and used spock's timeout annotation to fail this test after 1 minute.
mar-kolya
force-pushed
the
ark/parallel-dd-loader
branch
2 times, most recently
from
a66df17
to
2d8102c
Compare
realark
dismissed
mar-kolya’s stale review
Added test timeout and removed classloading lock exposure. Please review again.
