Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow trace to persist across netty connect. #451

Merged
merged 1 commit into from Aug 23, 2018
Merged

Allow trace to persist across netty connect. #451

merged 1 commit into from Aug 23, 2018

Conversation

tylerbenson
Copy link
Contributor

Also create span with error on connection failure.

Add tests for connection failure.

@tylerbenson tylerbenson added this to the 0.13.0 milestone Aug 21, 2018
@tylerbenson
Copy link
Contributor Author

Should resolve the issue mentioned here

CC @karkum-rally @htmldoug

I'm going to rebase #443 on this so you can get a new build to try that includes both. I didn't do it the other way around because this might be able to merge first.

@tylerbenson tylerbenson force-pushed the tyler/netty-client-fixes branch 3 times, most recently from 3265b7d to 470fd53 Compare August 21, 2018 09:42
@tylerbenson
Allow trace to persist across netty connect.
898647e 
Also create span with error on connection failure.

Add tests for connection failure.
realark
realark approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@realark realark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@tylerbenson tylerbenson merged commit 36b49c7 into master Aug 23, 2018
@tylerbenson tylerbenson deleted the tyler/netty-client-fixes branch August 23, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realark realark realark approved these changes

Assignees
No one assigned
Labels
inst: others All other instrumentations type: bug type: enhancement
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tylerbenson @realark