Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable netty by default #455

Merged
merged 1 commit into from Aug 23, 2018
Merged

Enable netty by default #455

merged 1 commit into from Aug 23, 2018

Conversation

tylerbenson
Copy link
Contributor

@tylerbenson tylerbenson commented Aug 22, 2018 •
edited

Netty 4+

@tylerbenson tylerbenson added the inst: others All other instrumentations label Aug 22, 2018
@tylerbenson tylerbenson added this to the 0.13.0 milestone Aug 22, 2018
realark
realark suggested changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@realark realark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to release netty because we've vetted it. For the others we'll need muzzle scanning before we can safely release.

@tylerbenson
Copy link
Contributor Author

@realark I reduced the list to things I'm comfortable with and think can be enabled. Are you still uncomfortable with this list?

@tylerbenson tylerbenson changed the title Enable integrations by default Enable netty by default Aug 22, 2018
@tylerbenson
Copy link
Contributor Author

@realark ok, I've scaled it back to just netty.

@tylerbenson tylerbenson merged commit 5a62159 into master Aug 23, 2018
@tylerbenson tylerbenson deleted the tyler/enable-integrations branch August 23, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realark realark realark approved these changes

@mar-kolya mar-kolya Awaiting requested review from mar-kolya

Assignees
No one assigned
Labels
inst: others All other instrumentations
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tylerbenson @realark