Improve error handling for ThreadPoolExecutorInstrumentation #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If other exceptions are thrown when trying to test the queue, it generates lots of log noise. This should handle it better.
tylerbenson
added
comp: core
mar-kolya
reviewed
Nov 27, 2018
| ExecutorInstrumentation.ConcurrentUtils.disableExecutor(executor); | ||
| } catch (final Exception e) { | ||
| // Other errors might indicate the queue is not fully initialized. | ||
| // We might want to disable for those too, but for now just ignore. |
There was a problem hiding this comment.
We actually had this in #564, but yours seems to have more comments :)
There was a problem hiding this comment.
I thought we had this somewhere. I couldn't remember where it was though. I wasn't sure if it was lost somehow.
mar-kolya
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If other exceptions are thrown when trying to test the queue, it generates lots of log noise. This should handle it better.