Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot-patch for J9 profiler regression #6243

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Hot-patch for J9 profiler regression #6243

merged 1 commit into from
Nov 17, 2023

Conversation

jbachorik
Copy link
Contributor

What Does This Do

Bumps ddprof to 0.84.1

Motivation

Include DataDog/java-profiler#46

Additional Notes

Jira ticket: PROF-8660

@jbachorik jbachorik requested a review from a team as a code owner November 17, 2023 20:27
@jbachorik jbachorik enabled auto-merge (squash) November 17, 2023 20:35
@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.25.0-SNAPSHOT~743bacde52 1.25.0-SNAPSHOT~0cd021c1e2
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.25.0-SNAPSHOT~0cd021c1e2, baseline=1.25.0-SNAPSHOT~743bacde52

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1033618
Total [baseline] (9.312 s) : 0, 9312431
Agent [candidate] (1.039 s) : 0, 1039217
Total [candidate] (9.311 s) : 0, 9310621
section appsec
Agent [baseline] (1.131 s) : 0, 1130723
Total [baseline] (9.411 s) : 0, 9411276
Agent [candidate] (1.129 s) : 0, 1128646
Total [candidate] (9.375 s) : 0, 9375144
section iast
Agent [baseline] (1.159 s) : 0, 1158635
Total [baseline] (9.486 s) : 0, 9486180
Agent [candidate] (1.157 s) : 0, 1156932
Total [candidate] (9.514 s) : 0, 9514436
section profiling
Agent [baseline] (1.225 s) : 0, 1225384
Total [baseline] (9.585 s) : 0, 9584847
Agent [candidate] (1.218 s) : 0, 1218313
Total [candidate] (9.525 s) : 0, 9525476
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.034 s -
Agent appsec 1.131 s 97.105 ms (9.4%)
Agent iast 1.159 s 125.017 ms (12.1%)
Agent profiling 1.225 s 191.766 ms (18.6%)
Total tracing 9.312 s -
Total appsec 9.411 s 98.845 ms (1.1%)
Total iast 9.486 s 173.749 ms (1.9%)
Total profiling 9.585 s 272.415 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent appsec 1.129 s 89.429 ms (8.6%)
Agent iast 1.157 s 117.715 ms (11.3%)
Agent profiling 1.218 s 179.096 ms (17.2%)
Total tracing 9.311 s -
Total appsec 9.375 s 64.523 ms (0.7%)
Total iast 9.514 s 203.815 ms (2.2%)
Total profiling 9.525 s 214.856 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.25.0-SNAPSHOT~0cd021c1e2, baseline=1.25.0-SNAPSHOT~743bacde52

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (647.178 ms) : 0, 647178
BytebuddyAgent [candidate] (651.47 ms) : 0, 651470
GlobalTracer [baseline] (295.072 ms) : 0, 295072
GlobalTracer [candidate] (296.561 ms) : 0, 296561
AppSec [baseline] (49.213 ms) : 0, 49213
AppSec [candidate] (48.576 ms) : 0, 48576
Remote Config [baseline] (671.49 µs) : 0, 671
Remote Config [candidate] (656.781 µs) : 0, 657
Telemetry [baseline] (7.263 ms) : 0, 7263
Telemetry [candidate] (7.238 ms) : 0, 7238
section appsec
BytebuddyAgent [baseline] (651.968 ms) : 0, 651968
BytebuddyAgent [candidate] (651.16 ms) : 0, 651160
GlobalTracer [baseline] (297.316 ms) : 0, 297316
GlobalTracer [candidate] (296.216 ms) : 0, 296216
AppSec [baseline] (139.378 ms) : 0, 139378
AppSec [candidate] (139.184 ms) : 0, 139184
Remote Config [baseline] (646.885 µs) : 0, 647
Remote Config [candidate] (649.911 µs) : 0, 650
Telemetry [baseline] (6.834 ms) : 0, 6834
Telemetry [candidate] (6.757 ms) : 0, 6757
section iast
BytebuddyAgent [baseline] (773.836 ms) : 0, 773836
BytebuddyAgent [candidate] (773.263 ms) : 0, 773263
GlobalTracer [baseline] (277.084 ms) : 0, 277084
GlobalTracer [candidate] (277.567 ms) : 0, 277567
AppSec [baseline] (46.979 ms) : 0, 46979
AppSec [candidate] (46.679 ms) : 0, 46679
Remote Config [baseline] (1.263 ms) : 0, 1263
Remote Config [candidate] (579.404 µs) : 0, 579
Telemetry [baseline] (7.918 ms) : 0, 7918
Telemetry [candidate] (8.56 ms) : 0, 8560
IAST [baseline] (16.836 ms) : 0, 16836
IAST [candidate] (15.62 ms) : 0, 15620
section profiling
ProfilingAgent [baseline] (88.416 ms) : 0, 88416
ProfilingAgent [candidate] (87.756 ms) : 0, 87756
BytebuddyAgent [baseline] (662.921 ms) : 0, 662921
BytebuddyAgent [candidate] (658.935 ms) : 0, 658935
GlobalTracer [baseline] (362.041 ms) : 0, 362041
GlobalTracer [candidate] (360.387 ms) : 0, 360387
AppSec [baseline] (49.017 ms) : 0, 49017
AppSec [candidate] (48.761 ms) : 0, 48761
Remote Config [baseline] (672.837 µs) : 0, 673
Remote Config [candidate] (646.127 µs) : 0, 646
Telemetry [baseline] (7.49 ms) : 0, 7490
Telemetry [candidate] (7.39 ms) : 0, 7390
Profiling [baseline] (88.44 ms) : 0, 88440
Profiling [candidate] (87.779 ms) : 0, 87779
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.25.0-SNAPSHOT~0cd021c1e2, baseline=1.25.0-SNAPSHOT~743bacde52

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1038511
Total [baseline] (8.769 s) : 0, 8769423
Agent [candidate] (1.036 s) : 0, 1035781
Total [candidate] (8.808 s) : 0, 8807639
section iast
Agent [baseline] (1.159 s) : 0, 1158682
Total [baseline] (9.339 s) : 0, 9339272
Agent [candidate] (1.152 s) : 0, 1151736
Total [candidate] (9.356 s) : 0, 9355729
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1151613
Total [baseline] (9.287 s) : 0, 9287079
Agent [candidate] (1.145 s) : 0, 1144941
Total [candidate] (9.281 s) : 0, 9281228
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent iast 1.159 s 120.171 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.152 s 113.103 ms (10.9%)
Total tracing 8.769 s -
Total iast 9.339 s 569.85 ms (6.5%)
Total iast_TELEMETRY_OFF 9.287 s 517.657 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent iast 1.152 s 115.955 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.145 s 109.16 ms (10.5%)
Total tracing 8.808 s -
Total iast 9.356 s 548.09 ms (6.2%)
Total iast_TELEMETRY_OFF 9.281 s 473.59 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.25.0-SNAPSHOT~0cd021c1e2, baseline=1.25.0-SNAPSHOT~743bacde52

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (650.522 ms) : 0, 650522
BytebuddyAgent [candidate] (648.24 ms) : 0, 648240
GlobalTracer [baseline] (296.829 ms) : 0, 296829
GlobalTracer [candidate] (295.959 ms) : 0, 295959
AppSec [baseline] (48.667 ms) : 0, 48667
AppSec [candidate] (49.225 ms) : 0, 49225
Remote Config [baseline] (665.502 µs) : 0, 666
Remote Config [candidate] (659.594 µs) : 0, 660
Telemetry [baseline] (7.231 ms) : 0, 7231
Telemetry [candidate] (7.203 ms) : 0, 7203
section iast
BytebuddyAgent [baseline] (773.295 ms) : 0, 773295
BytebuddyAgent [candidate] (768.802 ms) : 0, 768802
GlobalTracer [baseline] (276.731 ms) : 0, 276731
GlobalTracer [candidate] (275.96 ms) : 0, 275960
AppSec [baseline] (46.922 ms) : 0, 46922
AppSec [candidate] (46.872 ms) : 0, 46872
Remote Config [baseline] (622.802 µs) : 0, 623
Remote Config [candidate] (578.064 µs) : 0, 578
Telemetry [baseline] (8.662 ms) : 0, 8662
Telemetry [candidate] (8.51 ms) : 0, 8510
IAST [baseline] (17.796 ms) : 0, 17796
IAST [candidate] (16.46 ms) : 0, 16460
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (765.662 ms) : 0, 765662
BytebuddyAgent [candidate] (762.534 ms) : 0, 762534
GlobalTracer [baseline] (277.536 ms) : 0, 277536
GlobalTracer [candidate] (275.943 ms) : 0, 275943
AppSec [baseline] (47.023 ms) : 0, 47023
AppSec [candidate] (46.617 ms) : 0, 46617
Remote Config [baseline] (590.041 µs) : 0, 590
Remote Config [candidate] (569.029 µs) : 0, 569
Telemetry [baseline] (8.419 ms) : 0, 8419
Telemetry [candidate] (7.674 ms) : 0, 7674
IAST [baseline] (17.823 ms) : 0, 17823
IAST [candidate] (17.159 ms) : 0, 17159
Loading

Load

Parameters

Baseline Candidate
commit 1.25.0-SNAPSHOT~743bacde52 1.25.0-SNAPSHOT~0cd021c1e2
config baseline candidate
end_time 2023-11-17T20:49:44 2023-11-17T21:06:13
start_time 2023-11-17T20:49:31 2023-11-17T21:06:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~0cd021c1e2, baseline=1.25.0-SNAPSHOT~743bacde52
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.701 ms) : 1675, 1726
.   : milestone, 1701,
iast (1.472 ms) : 1448, 1496
.   : milestone, 1472,
profiling (1.47 ms) : 1446, 1495
.   : milestone, 1470,
tracing (1.469 ms) : 1444, 1493
.   : milestone, 1469,
section candidate
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.709 ms) : 1684, 1733
.   : milestone, 1709,
iast (1.484 ms) : 1461, 1508
.   : milestone, 1484,
profiling (1.497 ms) : 1470, 1523
.   : milestone, 1497,
tracing (1.461 ms) : 1437, 1486
.   : milestone, 1461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.365 ms] -
appsec 1.701 ms [1.675 ms, 1.726 ms] 354.925 µs (26.4%)
iast 1.472 ms [1.448 ms, 1.496 ms] 125.816 µs (9.3%)
profiling 1.47 ms [1.446 ms, 1.495 ms] 124.516 µs (9.3%)
tracing 1.469 ms [1.444 ms, 1.493 ms] 122.879 µs (9.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.709 ms [1.684 ms, 1.733 ms] 358.307 µs (26.5%)
iast 1.484 ms [1.461 ms, 1.508 ms] 134.111 µs (9.9%)
profiling 1.497 ms [1.47 ms, 1.523 ms] 146.193 µs (10.8%)
tracing 1.461 ms [1.437 ms, 1.486 ms] 111.01 µs (8.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~0cd021c1e2, baseline=1.25.0-SNAPSHOT~743bacde52
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.765 µs) : 342, 382
.   : milestone, 362,
iast (471.447 µs) : 451, 492
.   : milestone, 471,
iast_FULL (530.154 µs) : 509, 551
.   : milestone, 530,
iast_INACTIVE (442.147 µs) : 421, 464
.   : milestone, 442,
iast_TELEMETRY_OFF (462.119 µs) : 441, 483
.   : milestone, 462,
tracing (437.007 µs) : 417, 457
.   : milestone, 437,
section candidate
no_agent (363.575 µs) : 344, 384
.   : milestone, 364,
iast (469.593 µs) : 449, 490
.   : milestone, 470,
iast_FULL (532.403 µs) : 511, 553
.   : milestone, 532,
iast_INACTIVE (440.404 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (461.244 µs) : 440, 482
.   : milestone, 461,
tracing (445.843 µs) : 424, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.765 µs [341.726 µs, 381.805 µs] -
iast 471.447 µs [450.619 µs, 492.275 µs] 109.682 µs (30.3%)
iast_FULL 530.154 µs [509.316 µs, 550.991 µs] 168.388 µs (46.5%)
iast_INACTIVE 442.147 µs [420.5 µs, 463.793 µs] 80.381 µs (22.2%)
iast_TELEMETRY_OFF 462.119 µs [441.048 µs, 483.19 µs] 100.354 µs (27.7%)
tracing 437.007 µs [416.639 µs, 457.376 µs] 75.242 µs (20.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.575 µs [343.612 µs, 383.537 µs] -
iast 469.593 µs [448.869 µs, 490.317 µs] 106.018 µs (29.2%)
iast_FULL 532.403 µs [511.38 µs, 553.426 µs] 168.828 µs (46.4%)
iast_INACTIVE 440.404 µs [419.576 µs, 461.232 µs] 76.83 µs (21.1%)
iast_TELEMETRY_OFF 461.244 µs [440.481 µs, 482.007 µs] 97.669 µs (26.9%)
tracing 445.843 µs [424.399 µs, 467.287 µs] 82.268 µs (22.6%)

@jbachorik jbachorik merged commit a1f05ad into release/v1.24.x Nov 17, 2023
62 of 64 checks passed
@jbachorik jbachorik deleted the jb/ddprof_0.84.1 branch November 17, 2023 21:19
@jbachorik jbachorik added this to the 1.24.2 milestone Nov 17, 2023
@PerfectSlayer PerfectSlayer added tag: dependencies Dependencies related changes comp: profiling Profiling labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bm1549 bm1549 bm1549 approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling tag: dependencies Dependencies related changes
Projects
None yet
Milestone
1.24.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbachorik @bm1549 @PerfectSlayer