Workaround LogManager startup issue and add springboot test #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-kolya
reviewed
Jan 10, 2019
dd-smoke-tests/springboot/src/test/groovy/datadog/trace/agent/SpringBootSmokeTest.groovy
Show resolved
Hide resolved
realark
force-pushed
the
ark/java9-logmanager-fix
branch
2 times, most recently
from
63bfe8c
to
292ed4b
Compare
log server output to files. Fix server dependencies. Only run smoke tests on standard JVMs.
realark
force-pushed
the
ark/java9-logmanager-fix
branch
from
292ed4b
to
bfd6535
Compare
mar-kolya
approved these changes
Jan 10, 2019
realark
added
type: bug
comp: testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogManager$CleanerA long-term fix for java modules is still needed but this will prevent future regressions against springboot and workaround an immediate sore spot.