Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture JVM arguments in tracer-flare #6581

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 29, 2024

Motivation

Helps when triaging issues where there may be multiple -javaagent options passed into the JVM

Jira ticket: APMJAVA-1078

@mcculls mcculls added comp: core Tracer core tag: diagnostics Diagnostics related changes labels Jan 29, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/capture-jvmargs-in-tracer-flare
git_commit_date 1706546274 1706556955
git_commit_sha 0f8b948 aecc1da
release_version 1.29.0-SNAPSHOT~0f8b9487b6 1.29.0-SNAPSHOT~aecc1da381
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706559895 1706559895
ci_job_id 421032654 421032654
ci_pipeline_id 27350427 27350427
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-01-29T20:01:00 2024-01-29T20:19:54
git_branch master mcculls/capture-jvmargs-in-tracer-flare
git_commit_date 1706546274 1706556955
git_commit_sha 0f8b948 aecc1da
release_version 1.29.0-SNAPSHOT~0f8b9487b6 1.29.0-SNAPSHOT~aecc1da381
start_time 2024-01-29T20:00:48 2024-01-29T20:19:41
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706559895 1706559895
ci_job_id 421032654 421032654
ci_pipeline_id 27350427 27350427
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~aecc1da381, baseline=1.29.0-SNAPSHOT~0f8b9487b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.24 µs) : 349, 388
.   : milestone, 368,
iast (465.155 µs) : 445, 486
.   : milestone, 465,
iast_FULL (532.634 µs) : 512, 553
.   : milestone, 533,
iast_GLOBAL (503.344 µs) : 482, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (468.679 µs) : 448, 489
.   : milestone, 469,
iast_INACTIVE (440.31 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (468.061 µs) : 447, 489
.   : milestone, 468,
tracing (438.624 µs) : 418, 459
.   : milestone, 439,
section candidate
no_agent (362.819 µs) : 342, 383
.   : milestone, 363,
iast (474.464 µs) : 453, 496
.   : milestone, 474,
iast_FULL (534.474 µs) : 514, 555
.   : milestone, 534,
iast_GLOBAL (502.223 µs) : 479, 525
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (466.787 µs) : 445, 488
.   : milestone, 467,
iast_INACTIVE (446.342 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (468.422 µs) : 447, 490
.   : milestone, 468,
tracing (431.42 µs) : 411, 452
.   : milestone, 431,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.24 µs [348.573 µs, 387.906 µs] -
iast 465.155 µs [444.711 µs, 485.6 µs] 96.915 µs (26.3%)
iast_FULL 532.634 µs [512.055 µs, 553.213 µs] 164.394 µs (44.6%)
iast_GLOBAL 503.344 µs [481.725 µs, 524.963 µs] 135.104 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 468.679 µs [447.951 µs, 489.407 µs] 100.439 µs (27.3%)
iast_INACTIVE 440.31 µs [419.788 µs, 460.833 µs] 72.07 µs (19.6%)
iast_TELEMETRY_OFF 468.061 µs [446.647 µs, 489.475 µs] 99.821 µs (27.1%)
tracing 438.624 µs [418.271 µs, 458.976 µs] 70.384 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.819 µs [342.4 µs, 383.238 µs] -
iast 474.464 µs [452.925 µs, 496.003 µs] 111.645 µs (30.8%)
iast_FULL 534.474 µs [513.916 µs, 555.033 µs] 171.655 µs (47.3%)
iast_GLOBAL 502.223 µs [479.369 µs, 525.078 µs] 139.405 µs (38.4%)
iast_HARDCODED_SECRET_DISABLED 466.787 µs [445.278 µs, 488.296 µs] 103.968 µs (28.7%)
iast_INACTIVE 446.342 µs [425.214 µs, 467.47 µs] 83.523 µs (23.0%)
iast_TELEMETRY_OFF 468.422 µs [447.238 µs, 489.605 µs] 105.603 µs (29.1%)
tracing 431.42 µs [411.336 µs, 451.504 µs] 68.601 µs (18.9%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~aecc1da381, baseline=1.29.0-SNAPSHOT~0f8b9487b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.755 ms) : 1728, 1782
.   : milestone, 1755,
iast (1.539 ms) : 1514, 1563
.   : milestone, 1539,
profiling (1.511 ms) : 1486, 1537
.   : milestone, 1511,
tracing (1.475 ms) : 1450, 1501
.   : milestone, 1475,
section candidate
no_agent (1.352 ms) : 1333, 1371
.   : milestone, 1352,
appsec (1.755 ms) : 1729, 1782
.   : milestone, 1755,
iast (1.508 ms) : 1483, 1533
.   : milestone, 1508,
profiling (1.498 ms) : 1473, 1524
.   : milestone, 1498,
tracing (1.494 ms) : 1469, 1518
.   : milestone, 1494,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.367 ms] -
appsec 1.755 ms [1.728 ms, 1.782 ms] 407.362 µs (30.2%)
iast 1.539 ms [1.514 ms, 1.563 ms] 191.202 µs (14.2%)
profiling 1.511 ms [1.486 ms, 1.537 ms] 163.603 µs (12.1%)
tracing 1.475 ms [1.45 ms, 1.501 ms] 127.518 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.371 ms] -
appsec 1.755 ms [1.729 ms, 1.782 ms] 403.151 µs (29.8%)
iast 1.508 ms [1.483 ms, 1.533 ms] 156.077 µs (11.5%)
profiling 1.498 ms [1.473 ms, 1.524 ms] 146.354 µs (10.8%)
tracing 1.494 ms [1.469 ms, 1.518 ms] 141.435 µs (10.5%)

@mcculls mcculls marked this pull request as ready for review January 29, 2024 17:02
@mcculls mcculls requested a review from a team as a code owner January 29, 2024 17:02
@mcculls mcculls force-pushed the mcculls/capture-jvmargs-in-tracer-flare branch from 8f20ebe to d94d4d4 Compare January 29, 2024 17:11
@mcculls mcculls requested a review from am312 January 29, 2024 17:45
@mcculls mcculls force-pushed the mcculls/capture-jvmargs-in-tracer-flare branch from d94d4d4 to aecc1da Compare January 29, 2024 19:36
@mcculls mcculls merged commit 281e492 into master Jan 29, 2024
80 checks passed
@mcculls mcculls deleted the mcculls/capture-jvmargs-in-tracer-flare branch January 29, 2024 21:06
@github-actions github-actions bot added this to the 1.29.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: core Tracer core tag: diagnostics Diagnostics related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants