-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture JVM arguments in tracer-flare #6581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
comp: core
Tracer core
tag: diagnostics
Diagnostics related changes
labels
Jan 29, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~aecc1da381, baseline=1.29.0-SNAPSHOT~0f8b9487b6
dateFormat X
axisFormat %s
section baseline
no_agent (368.24 µs) : 349, 388
. : milestone, 368,
iast (465.155 µs) : 445, 486
. : milestone, 465,
iast_FULL (532.634 µs) : 512, 553
. : milestone, 533,
iast_GLOBAL (503.344 µs) : 482, 525
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (468.679 µs) : 448, 489
. : milestone, 469,
iast_INACTIVE (440.31 µs) : 420, 461
. : milestone, 440,
iast_TELEMETRY_OFF (468.061 µs) : 447, 489
. : milestone, 468,
tracing (438.624 µs) : 418, 459
. : milestone, 439,
section candidate
no_agent (362.819 µs) : 342, 383
. : milestone, 363,
iast (474.464 µs) : 453, 496
. : milestone, 474,
iast_FULL (534.474 µs) : 514, 555
. : milestone, 534,
iast_GLOBAL (502.223 µs) : 479, 525
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (466.787 µs) : 445, 488
. : milestone, 467,
iast_INACTIVE (446.342 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (468.422 µs) : 447, 490
. : milestone, 468,
tracing (431.42 µs) : 411, 452
. : milestone, 431,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~aecc1da381, baseline=1.29.0-SNAPSHOT~0f8b9487b6
dateFormat X
axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1367
. : milestone, 1348,
appsec (1.755 ms) : 1728, 1782
. : milestone, 1755,
iast (1.539 ms) : 1514, 1563
. : milestone, 1539,
profiling (1.511 ms) : 1486, 1537
. : milestone, 1511,
tracing (1.475 ms) : 1450, 1501
. : milestone, 1475,
section candidate
no_agent (1.352 ms) : 1333, 1371
. : milestone, 1352,
appsec (1.755 ms) : 1729, 1782
. : milestone, 1755,
iast (1.508 ms) : 1483, 1533
. : milestone, 1508,
profiling (1.498 ms) : 1473, 1524
. : milestone, 1498,
tracing (1.494 ms) : 1469, 1518
. : milestone, 1494,
|
mcculls
force-pushed
the
mcculls/capture-jvmargs-in-tracer-flare
branch
from
January 29, 2024 17:11
8f20ebe
to
d94d4d4
Compare
smola
approved these changes
Jan 29, 2024
mcculls
force-pushed
the
mcculls/capture-jvmargs-in-tracer-flare
branch
from
January 29, 2024 19:36
d94d4d4
to
aecc1da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Helps when triaging issues where there may be multiple
-javaagent
options passed into the JVMJira ticket: APMJAVA-1078