-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement telemetry for shell git commands #6665
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/ci-vis-git-commands-telemetry
Feb 13, 2024
Merged
Implement telemetry for shell git commands #6665
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/ci-vis-git-commands-telemetry
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5001f17
to
8936a3f
Compare
f7b8297
to
4d417ef
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~1321c2606c, baseline=1.31.0-SNAPSHOT~c471269d77
dateFormat X
axisFormat %s
section baseline
no_agent (359.48 µs) : 340, 379
. : milestone, 359,
iast (464.66 µs) : 444, 485
. : milestone, 465,
iast_FULL (531.248 µs) : 511, 552
. : milestone, 531,
iast_GLOBAL (490.434 µs) : 469, 512
. : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (467.305 µs) : 447, 488
. : milestone, 467,
iast_INACTIVE (442.249 µs) : 421, 464
. : milestone, 442,
iast_TELEMETRY_OFF (474.005 µs) : 452, 496
. : milestone, 474,
tracing (444.294 µs) : 423, 465
. : milestone, 444,
section candidate
no_agent (364.109 µs) : 345, 384
. : milestone, 364,
iast (478.283 µs) : 457, 499
. : milestone, 478,
iast_FULL (528.253 µs) : 508, 549
. : milestone, 528,
iast_GLOBAL (496.181 µs) : 474, 518
. : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (469.625 µs) : 449, 491
. : milestone, 470,
iast_INACTIVE (442.282 µs) : 422, 463
. : milestone, 442,
iast_TELEMETRY_OFF (472.326 µs) : 452, 493
. : milestone, 472,
tracing (442.29 µs) : 421, 464
. : milestone, 442,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~1321c2606c, baseline=1.31.0-SNAPSHOT~c471269d77
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1323, 1360
. : milestone, 1341,
appsec (1.752 ms) : 1726, 1777
. : milestone, 1752,
iast (1.505 ms) : 1480, 1529
. : milestone, 1505,
profiling (1.53 ms) : 1505, 1555
. : milestone, 1530,
tracing (1.475 ms) : 1450, 1499
. : milestone, 1475,
section candidate
no_agent (1.355 ms) : 1336, 1374
. : milestone, 1355,
appsec (1.774 ms) : 1748, 1799
. : milestone, 1774,
iast (1.504 ms) : 1479, 1528
. : milestone, 1504,
profiling (1.522 ms) : 1496, 1548
. : milestone, 1522,
tracing (1.48 ms) : 1455, 1505
. : milestone, 1480,
|
juan-fernandez
approved these changes
Feb 12, 2024
4d417ef
to
1321c26
Compare
jandro996
pushed a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Implements sending telemetry metrics for shell Git commands executed in CI Visibility module.
Motivation
Monitoring CI Visibility behaviour to detect unexpected errors/problems.
Jira ticket: CIVIS-2427