Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizations to check if string arrays can be tainted #6690

Merged
merged 3 commits into from Feb 16, 2024
Merged

Optimizations to check if string arrays can be tainted #6690

merged 3 commits into from Feb 16, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

What Does This Do

Creates an specialized version of the canBeTainted method working with String instead of CharSequence

Motivation

In some JVM implementation the difference between invokevirtual and invokeinterface for this method is noticeable making it worth it to have an specialized version.

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: performance Performance related changes comp: asm iast Application Security Management (IAST) labels Feb 16, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner February 16, 2024 10:53
@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-can-be-tainted-optimization
git_commit_date 1708081899 1708085092
git_commit_sha 167e8f7 1da6317
release_version 1.31.0-SNAPSHOT~167e8f7645 1.31.0-SNAPSHOT~1da6317692
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1708087845 1708087845
ci_job_id 436011298 436011298
ci_pipeline_id 28414683 28414683
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 5 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~1da6317692, baseline=1.31.0-SNAPSHOT~167e8f7645

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057311
Total [baseline] (9.152 s) : 0, 9152255
Agent [candidate] (1.056 s) : 0, 1056146
Total [candidate] (9.201 s) : 0, 9200636
section appsec
Agent [baseline] (1.151 s) : 0, 1150819
Total [baseline] (9.265 s) : 0, 9265414
Agent [candidate] (1.158 s) : 0, 1157955
Total [candidate] (9.337 s) : 0, 9336636
section iast
Agent [baseline] (1.183 s) : 0, 1183101
Total [baseline] (9.505 s) : 0, 9505388
Agent [candidate] (1.181 s) : 0, 1181031
Total [candidate] (9.432 s) : 0, 9432197
section profiling
Agent [baseline] (1.268 s) : 0, 1268264
Total [baseline] (9.365 s) : 0, 9365254
Agent [candidate] (1.271 s) : 0, 1271160
Total [candidate] (9.396 s) : 0, 9396270
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.151 s 93.508 ms (8.8%)
Agent iast 1.183 s 125.79 ms (11.9%)
Agent profiling 1.268 s 210.953 ms (20.0%)
Total tracing 9.152 s -
Total appsec 9.265 s 113.159 ms (1.2%)
Total iast 9.505 s 353.133 ms (3.9%)
Total profiling 9.365 s 212.999 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.158 s 101.809 ms (9.6%)
Agent iast 1.181 s 124.885 ms (11.8%)
Agent profiling 1.271 s 215.014 ms (20.4%)
Total tracing 9.201 s -
Total appsec 9.337 s 136.0 ms (1.5%)
Total iast 9.432 s 231.561 ms (2.5%)
Total profiling 9.396 s 195.634 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~1da6317692, baseline=1.31.0-SNAPSHOT~167e8f7645

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.193 ms) : 0, 668193
BytebuddyAgent [candidate] (666.284 ms) : 0, 666284
GlobalTracer [baseline] (294.823 ms) : 0, 294823
GlobalTracer [candidate] (295.548 ms) : 0, 295548
AppSec [baseline] (51.372 ms) : 0, 51372
AppSec [candidate] (51.748 ms) : 0, 51748
Remote Config [baseline] (709.541 µs) : 0, 710
Remote Config [candidate] (714.237 µs) : 0, 714
Telemetry [baseline] (7.676 ms) : 0, 7676
Telemetry [candidate] (7.616 ms) : 0, 7616
section appsec
BytebuddyAgent [baseline] (664.056 ms) : 0, 664056
BytebuddyAgent [candidate] (667.974 ms) : 0, 667974
GlobalTracer [baseline] (294.245 ms) : 0, 294245
GlobalTracer [candidate] (296.881 ms) : 0, 296881
AppSec [baseline] (150.831 ms) : 0, 150831
AppSec [candidate] (151.142 ms) : 0, 151142
Remote Config [baseline] (635.028 µs) : 0, 635
Remote Config [candidate] (641.492 µs) : 0, 641
Telemetry [baseline] (6.84 ms) : 0, 6840
Telemetry [candidate] (6.868 ms) : 0, 6868
section iast
BytebuddyAgent [baseline] (780.729 ms) : 0, 780729
BytebuddyAgent [candidate] (776.683 ms) : 0, 776683
GlobalTracer [baseline] (287.955 ms) : 0, 287955
GlobalTracer [candidate] (287.033 ms) : 0, 287033
AppSec [baseline] (50.098 ms) : 0, 50098
AppSec [candidate] (50.137 ms) : 0, 50137
Remote Config [baseline] (602.808 µs) : 0, 603
Remote Config [candidate] (615.912 µs) : 0, 616
Telemetry [baseline] (6.769 ms) : 0, 6769
Telemetry [candidate] (6.585 ms) : 0, 6585
IAST [baseline] (22.412 ms) : 0, 22412
IAST [candidate] (25.634 ms) : 0, 25634
section profiling
BytebuddyAgent [baseline] (659.296 ms) : 0, 659296
BytebuddyAgent [candidate] (661.3 ms) : 0, 661300
GlobalTracer [baseline] (378.42 ms) : 0, 378420
GlobalTracer [candidate] (379.223 ms) : 0, 379223
AppSec [baseline] (51.699 ms) : 0, 51699
AppSec [candidate] (51.863 ms) : 0, 51863
Remote Config [baseline] (659.331 µs) : 0, 659
Remote Config [candidate] (659.795 µs) : 0, 660
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.565 ms) : 0, 7565
ProfilingAgent [baseline] (116.03 ms) : 0, 116030
ProfilingAgent [candidate] (115.904 ms) : 0, 115904
Profiling [baseline] (116.055 ms) : 0, 116055
Profiling [candidate] (115.93 ms) : 0, 115930

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-16T12:27:06 2024-02-16T12:45:44
git_branch master malvarez/iast-can-be-tainted-optimization
git_commit_date 1708081899 1708085092
git_commit_sha 167e8f7 1da6317
release_version 1.31.0-SNAPSHOT~167e8f7645 1.31.0-SNAPSHOT~1da6317692
start_time 2024-02-16T12:26:53 2024-02-16T12:45:31
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1708087845 1708087845
ci_job_id 436011298 436011298
ci_pipeline_id 28414683 28414683
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~1da6317692, baseline=1.31.0-SNAPSHOT~167e8f7645
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.8 ms) : 1775, 1824
.   : milestone, 1800,
iast (1.511 ms) : 1487, 1534
.   : milestone, 1511,
profiling (1.55 ms) : 1526, 1574
.   : milestone, 1550,
tracing (1.528 ms) : 1504, 1551
.   : milestone, 1528,
section candidate
no_agent (1.341 ms) : 1322, 1360
.   : milestone, 1341,
appsec (1.81 ms) : 1786, 1834
.   : milestone, 1810,
iast (1.536 ms) : 1511, 1560
.   : milestone, 1536,
profiling (1.548 ms) : 1524, 1571
.   : milestone, 1548,
tracing (1.508 ms) : 1484, 1531
.   : milestone, 1508,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.8 ms [1.775 ms, 1.824 ms] 456.299 µs (34.0%)
iast 1.511 ms [1.487 ms, 1.534 ms] 167.32 µs (12.5%)
profiling 1.55 ms [1.526 ms, 1.574 ms] 206.811 µs (15.4%)
tracing 1.528 ms [1.504 ms, 1.551 ms] 184.365 µs (13.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.36 ms] -
appsec 1.81 ms [1.786 ms, 1.834 ms] 468.453 µs (34.9%)
iast 1.536 ms [1.511 ms, 1.56 ms] 194.644 µs (14.5%)
profiling 1.548 ms [1.524 ms, 1.571 ms] 206.26 µs (15.4%)
tracing 1.508 ms [1.484 ms, 1.531 ms] 166.452 µs (12.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~1da6317692, baseline=1.31.0-SNAPSHOT~167e8f7645
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.208 µs) : 346, 389
.   : milestone, 367,
iast (475.781 µs) : 455, 497
.   : milestone, 476,
iast_FULL (534.986 µs) : 515, 555
.   : milestone, 535,
iast_GLOBAL (494.725 µs) : 474, 515
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (482.103 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (445.868 µs) : 426, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (472.432 µs) : 452, 493
.   : milestone, 472,
tracing (448.164 µs) : 427, 469
.   : milestone, 448,
section candidate
no_agent (364.836 µs) : 345, 384
.   : milestone, 365,
iast (471.343 µs) : 451, 492
.   : milestone, 471,
iast_FULL (534.642 µs) : 514, 555
.   : milestone, 535,
iast_GLOBAL (495.317 µs) : 475, 516
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (476.379 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (452.163 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (470.08 µs) : 449, 491
.   : milestone, 470,
tracing (446.17 µs) : 426, 466
.   : milestone, 446,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.208 µs [345.833 µs, 388.583 µs] -
iast 475.781 µs [454.985 µs, 496.577 µs] 108.573 µs (29.6%)
iast_FULL 534.986 µs [514.683 µs, 555.29 µs] 167.778 µs (45.7%)
iast_GLOBAL 494.725 µs [474.404 µs, 515.046 µs] 127.517 µs (34.7%)
iast_HARDCODED_SECRET_DISABLED 482.103 µs [461.164 µs, 503.041 µs] 114.895 µs (31.3%)
iast_INACTIVE 445.868 µs [425.57 µs, 466.165 µs] 78.659 µs (21.4%)
iast_TELEMETRY_OFF 472.432 µs [451.709 µs, 493.155 µs] 105.224 µs (28.7%)
tracing 448.164 µs [427.451 µs, 468.876 µs] 80.956 µs (22.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.836 µs [345.469 µs, 384.204 µs] -
iast 471.343 µs [450.503 µs, 492.182 µs] 106.506 µs (29.2%)
iast_FULL 534.642 µs [514.184 µs, 555.1 µs] 169.806 µs (46.5%)
iast_GLOBAL 495.317 µs [474.962 µs, 515.673 µs] 130.481 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 476.379 µs [455.49 µs, 497.267 µs] 111.542 µs (30.6%)
iast_INACTIVE 452.163 µs [431.363 µs, 472.962 µs] 87.327 µs (23.9%)
iast_TELEMETRY_OFF 470.08 µs [449.29 µs, 490.87 µs] 105.244 µs (28.8%)
tracing 446.17 µs [426.327 µs, 466.013 µs] 81.334 µs (22.3%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 2072afb into master Feb 16, 2024
79 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-can-be-tainted-optimization branch February 16, 2024 13:13
@github-actions github-actions bot added this to the 1.31.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@anderruiz anderruiz anderruiz approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) tag: performance Performance related changes
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manuel-alvarez-alvarez @smola @anderruiz