Add support for kafka bytebuffers in 3.x #6736

manuel-alvarez-alvarez · 2024-02-26T09:37:07Z

What Does This Do

Adds required instrumentation to complete support under Kafka 3.x deserializer API based on byte buffers

Motivation

Additional Notes

Jira ticket: APPSEC-51975

pr-commenter · 2024-02-26T10:21:52Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-kafka-bytebuff
git_commit_date	1709707671	1709712986
git_commit_sha	`02d3cb7`	`9a13db1`

See matching parameters

	Baseline	Candidate
ci_job_date	1709714158	1709714158
ci_job_id	451996335	451996335
ci_pipeline_id	29588738	29588738
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.21	11.0.21
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.21+9-post-Ubuntu-0ubuntu122.04	11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	unsure [+3019.553op/s; +82884.933op/s] or [+0.169%; +4.642%]
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	unsure [+541.548op/s; +7221.578op/s] or [+0.300%; +4.000%]
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2024-02-26T10:33:18Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-kafka-bytebuff
git_commit_date	1709707671	1709712986
git_commit_sha	`02d3cb7`	`9a13db1`
release_version	1.32.0-SNAPSHOT~02d3cb7aac	1.32.0-SNAPSHOT~9a13db1d0a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1709716163	1709716163
ci_job_id	451996334	451996334
ci_pipeline_id	29588738	29588738
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~9a13db1d0a, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080381
Total [baseline] (8.578 s) : 0, 8578476
Agent [candidate] (1.089 s) : 0, 1089217
Total [candidate] (8.573 s) : 0, 8573474
section iast
Agent [baseline] (1.213 s) : 0, 1212801
Total [baseline] (9.069 s) : 0, 9068694
Agent [candidate] (1.208 s) : 0, 1207782
Total [candidate] (9.051 s) : 0, 9051374
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215241
Total [baseline] (9.056 s) : 0, 9056087
Agent [candidate] (1.211 s) : 0, 1210749
Total [candidate] (9.038 s) : 0, 9038111
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1206548
Total [baseline] (9.061 s) : 0, 9061146
Agent [candidate] (1.206 s) : 0, 1206135
Total [candidate] (9.059 s) : 0, 9058968

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	iast	1.213 s	132.42 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.215 s	134.861 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.207 s	126.167 ms (11.7%)
Total	tracing	8.578 s	-
Total	iast	9.069 s	490.218 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.056 s	477.612 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.061 s	482.67 ms (5.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	iast	1.208 s	118.566 ms (10.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.211 s	121.532 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.206 s	116.919 ms (10.7%)
Total	tracing	8.573 s	-
Total	iast	9.051 s	477.9 ms (5.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.038 s	464.637 ms (5.4%)
Total	iast_TELEMETRY_OFF	9.059 s	485.494 ms (5.7%)

gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~9a13db1d0a, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.18 ms) : 0, 696180
BytebuddyAgent [candidate] (701.402 ms) : 0, 701402
GlobalTracer [baseline] (290.932 ms) : 0, 290932
GlobalTracer [candidate] (293.813 ms) : 0, 293813
AppSec [baseline] (50.442 ms) : 0, 50442
AppSec [candidate] (50.782 ms) : 0, 50782
Remote Config [baseline] (727.057 µs) : 0, 727
Remote Config [candidate] (742.267 µs) : 0, 742
Telemetry [baseline] (7.74 ms) : 0, 7740
Telemetry [candidate] (7.858 ms) : 0, 7858
section iast
BytebuddyAgent [baseline] (805.579 ms) : 0, 805579
BytebuddyAgent [candidate] (801.182 ms) : 0, 801182
GlobalTracer [baseline] (289.298 ms) : 0, 289298
GlobalTracer [candidate] (289.305 ms) : 0, 289305
AppSec [baseline] (53.684 ms) : 0, 53684
AppSec [candidate] (54.276 ms) : 0, 54276
IAST [baseline] (21.642 ms) : 0, 21642
IAST [candidate] (21.386 ms) : 0, 21386
Remote Config [baseline] (588.519 µs) : 0, 589
Remote Config [candidate] (585.755 µs) : 0, 586
Telemetry [baseline] (7.474 ms) : 0, 7474
Telemetry [candidate] (6.68 ms) : 0, 6680
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.021 ms) : 0, 806021
BytebuddyAgent [candidate] (802.87 ms) : 0, 802870
GlobalTracer [baseline] (290.282 ms) : 0, 290282
GlobalTracer [candidate] (290.172 ms) : 0, 290172
AppSec [baseline] (51.295 ms) : 0, 51295
AppSec [candidate] (53.174 ms) : 0, 53174
IAST [baseline] (25.729 ms) : 0, 25729
IAST [candidate] (22.001 ms) : 0, 22001
Remote Config [baseline] (593.773 µs) : 0, 594
Remote Config [candidate] (586.491 µs) : 0, 586
Telemetry [baseline] (6.709 ms) : 0, 6709
Telemetry [candidate] (7.413 ms) : 0, 7413
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.744 ms) : 0, 796744
BytebuddyAgent [candidate] (797.221 ms) : 0, 797221
GlobalTracer [baseline] (291.618 ms) : 0, 291618
GlobalTracer [candidate] (291.48 ms) : 0, 291480
AppSec [baseline] (52.392 ms) : 0, 52392
AppSec [candidate] (52.287 ms) : 0, 52287
IAST [baseline] (23.396 ms) : 0, 23396
IAST [candidate] (22.795 ms) : 0, 22795
Remote Config [baseline] (595.361 µs) : 0, 595
Remote Config [candidate] (606.415 µs) : 0, 606
Telemetry [baseline] (7.319 ms) : 0, 7319
Telemetry [candidate] (7.343 ms) : 0, 7343

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~9a13db1d0a, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092706
Total [baseline] (9.19 s) : 0, 9189964
Agent [candidate] (1.085 s) : 0, 1085114
Total [candidate] (9.172 s) : 0, 9171970
section appsec
Agent [baseline] (1.209 s) : 0, 1209396
Total [baseline] (9.361 s) : 0, 9361130
Agent [candidate] (1.214 s) : 0, 1213688
Total [candidate] (9.389 s) : 0, 9388961
section iast
Agent [baseline] (1.211 s) : 0, 1210633
Total [baseline] (9.338 s) : 0, 9338420
Agent [candidate] (1.208 s) : 0, 1207616
Total [candidate] (9.333 s) : 0, 9332656
section profiling
Agent [baseline] (1.273 s) : 0, 1273475
Total [baseline] (9.331 s) : 0, 9330773
Agent [candidate] (1.276 s) : 0, 1275943
Total [candidate] (9.348 s) : 0, 9348228

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.093 s	-
Agent	appsec	1.209 s	116.69 ms (10.7%)
Agent	iast	1.211 s	117.927 ms (10.8%)
Agent	profiling	1.273 s	180.769 ms (16.5%)
Total	tracing	9.19 s	-
Total	appsec	9.361 s	171.166 ms (1.9%)
Total	iast	9.338 s	148.457 ms (1.6%)
Total	profiling	9.331 s	140.809 ms (1.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.085 s	-
Agent	appsec	1.214 s	128.574 ms (11.8%)
Agent	iast	1.208 s	122.501 ms (11.3%)
Agent	profiling	1.276 s	190.829 ms (17.6%)
Total	tracing	9.172 s	-
Total	appsec	9.389 s	216.992 ms (2.4%)
Total	iast	9.333 s	160.687 ms (1.8%)
Total	profiling	9.348 s	176.258 ms (1.9%)

gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~9a13db1d0a, baseline=1.32.0-SNAPSHOT~02d3cb7aac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (705.512 ms) : 0, 705512
BytebuddyAgent [candidate] (698.278 ms) : 0, 698278
GlobalTracer [baseline] (292.844 ms) : 0, 292844
GlobalTracer [candidate] (292.879 ms) : 0, 292879
AppSec [baseline] (51.011 ms) : 0, 51011
AppSec [candidate] (51.025 ms) : 0, 51025
Remote Config [baseline] (723.317 µs) : 0, 723
Remote Config [candidate] (725.637 µs) : 0, 726
Telemetry [baseline] (7.763 ms) : 0, 7763
Telemetry [candidate] (7.795 ms) : 0, 7795
section appsec
BytebuddyAgent [baseline] (700.994 ms) : 0, 700994
BytebuddyAgent [candidate] (702.258 ms) : 0, 702258
GlobalTracer [baseline] (292.626 ms) : 0, 292626
GlobalTracer [candidate] (294.052 ms) : 0, 294052
AppSec [baseline] (156.049 ms) : 0, 156049
AppSec [candidate] (157.123 ms) : 0, 157123
Remote Config [baseline] (604.331 µs) : 0, 604
Remote Config [candidate] (620.178 µs) : 0, 620
Telemetry [baseline] (6.839 ms) : 0, 6839
Telemetry [candidate] (6.982 ms) : 0, 6982
IAST [baseline] (17.681 ms) : 0, 17681
IAST [candidate] (18.11 ms) : 0, 18110
section iast
BytebuddyAgent [baseline] (803.27 ms) : 0, 803270
BytebuddyAgent [candidate] (800.759 ms) : 0, 800759
GlobalTracer [baseline] (289.086 ms) : 0, 289086
GlobalTracer [candidate] (288.904 ms) : 0, 288904
AppSec [baseline] (52.47 ms) : 0, 52470
AppSec [candidate] (52.493 ms) : 0, 52493
Remote Config [baseline] (586.786 µs) : 0, 587
Remote Config [candidate] (589.684 µs) : 0, 590
Telemetry [baseline] (6.724 ms) : 0, 6724
Telemetry [candidate] (6.656 ms) : 0, 6656
IAST [baseline] (23.994 ms) : 0, 23994
IAST [candidate] (23.931 ms) : 0, 23931
section profiling
BytebuddyAgent [baseline] (689.37 ms) : 0, 689370
BytebuddyAgent [candidate] (690.13 ms) : 0, 690130
GlobalTracer [baseline] (373.638 ms) : 0, 373638
GlobalTracer [candidate] (374.623 ms) : 0, 374623
AppSec [baseline] (52.418 ms) : 0, 52418
AppSec [candidate] (52.86 ms) : 0, 52860
Remote Config [baseline] (813.041 µs) : 0, 813
Remote Config [candidate] (786.822 µs) : 0, 787
Telemetry [baseline] (7.425 ms) : 0, 7425
Telemetry [candidate] (7.486 ms) : 0, 7486
ProfilingAgent [baseline] (93.525 ms) : 0, 93525
ProfilingAgent [candidate] (93.897 ms) : 0, 93897
Profiling [baseline] (93.55 ms) : 0, 93550
Profiling [candidate] (93.92 ms) : 0, 93920

Load

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~9a13db1d0a, baseline=1.32.0-SNAPSHOT~02d3cb7aac
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.274 µs) : 342, 382
.   : milestone, 362,
iast (469.344 µs) : 449, 490
.   : milestone, 469,
iast_FULL (542.458 µs) : 522, 563
.   : milestone, 542,
iast_GLOBAL (496.974 µs) : 476, 518
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (473.982 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (451.042 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (471.878 µs) : 451, 492
.   : milestone, 472,
tracing (445.413 µs) : 425, 466
.   : milestone, 445,
section candidate
no_agent (372.56 µs) : 351, 394
.   : milestone, 373,
iast (473.841 µs) : 450, 497
.   : milestone, 474,
iast_FULL (553.58 µs) : 533, 574
.   : milestone, 554,
iast_GLOBAL (494.396 µs) : 473, 515
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (473.988 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (451.807 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (472.865 µs) : 452, 494
.   : milestone, 473,
tracing (450.843 µs) : 430, 471
.   : milestone, 451,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	362.274 µs [342.321 µs, 382.227 µs]	-
iast	469.344 µs [448.903 µs, 489.785 µs]	107.07 µs (29.6%)
iast_FULL	542.458 µs [521.979 µs, 562.938 µs]	180.184 µs (49.7%)
iast_GLOBAL	496.974 µs [475.915 µs, 518.033 µs]	134.7 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED	473.982 µs [453.311 µs, 494.654 µs]	111.708 µs (30.8%)
iast_INACTIVE	451.042 µs [430.055 µs, 472.03 µs]	88.768 µs (24.5%)
iast_TELEMETRY_OFF	471.878 µs [451.414 µs, 492.342 µs]	109.604 µs (30.3%)
tracing	445.413 µs [424.821 µs, 466.004 µs]	83.139 µs (22.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.56 µs [351.425 µs, 393.694 µs]	-
iast	473.841 µs [450.443 µs, 497.239 µs]	101.281 µs (27.2%)
iast_FULL	553.58 µs [532.995 µs, 574.165 µs]	181.02 µs (48.6%)
iast_GLOBAL	494.396 µs [473.405 µs, 515.386 µs]	121.836 µs (32.7%)
iast_HARDCODED_SECRET_DISABLED	473.988 µs [453.419 µs, 494.558 µs]	101.429 µs (27.2%)
iast_INACTIVE	451.807 µs [430.347 µs, 473.266 µs]	79.247 µs (21.3%)
iast_TELEMETRY_OFF	472.865 µs [452.046 µs, 493.684 µs]	100.305 µs (26.9%)
tracing	450.843 µs [430.317 µs, 471.369 µs]	78.284 µs (21.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~9a13db1d0a, baseline=1.32.0-SNAPSHOT~02d3cb7aac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1383
.   : milestone, 1364,
appsec (1.802 ms) : 1779, 1825
.   : milestone, 1802,
iast (1.504 ms) : 1481, 1527
.   : milestone, 1504,
profiling (1.525 ms) : 1500, 1550
.   : milestone, 1525,
tracing (1.525 ms) : 1502, 1548
.   : milestone, 1525,
section candidate
no_agent (1.36 ms) : 1342, 1379
.   : milestone, 1360,
appsec (1.771 ms) : 1747, 1794
.   : milestone, 1771,
iast (1.53 ms) : 1506, 1554
.   : milestone, 1530,
profiling (1.612 ms) : 1588, 1636
.   : milestone, 1612,
tracing (1.502 ms) : 1479, 1526
.   : milestone, 1502,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.364 ms [1.345 ms, 1.383 ms]	-
appsec	1.802 ms [1.779 ms, 1.825 ms]	438.288 µs (32.1%)
iast	1.504 ms [1.481 ms, 1.527 ms]	140.267 µs (10.3%)
profiling	1.525 ms [1.5 ms, 1.55 ms]	161.384 µs (11.8%)
tracing	1.525 ms [1.502 ms, 1.548 ms]	161.21 µs (11.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.342 ms, 1.379 ms]	-
appsec	1.771 ms [1.747 ms, 1.794 ms]	410.149 µs (30.1%)
iast	1.53 ms [1.506 ms, 1.554 ms]	169.154 µs (12.4%)
profiling	1.612 ms [1.588 ms, 1.636 ms]	251.356 µs (18.5%)
tracing	1.502 ms [1.479 ms, 1.526 ms]	141.996 µs (10.4%)

pr-commenter · 2024-02-26T10:34:33Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-kafka-bytebuff
git_commit_date	1709707671	1709712986
git_commit_sha	`02d3cb7`	`9a13db1`

See matching parameters

	Baseline	Candidate
ci_job_date	1709714204	1709714204
ci_job_id	451996336	451996336
ci_pipeline_id	29588738	29588738
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.21	11.0.21
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.21+9-post-Ubuntu-0ubuntu122.04	11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	unsure [+2138.679op/s; +16478.802op/s] or [+0.711%; +5.479%]

PerfectSlayer · 2024-02-27T09:49:41Z

Hey Manuel,
Is a review from the Java client library team required?
Looks like you are merging commits on your own branches so it's unclear if I should review it?

manuel-alvarez-alvarez · 2024-02-27T16:48:17Z

Hey Manuel, Is a review from the Java client library team required? Looks like you are merging commits on your own branches so it's unclear if I should review it?

Hello @PerfectSlayer, sorry for the late reply. This is part of a stacked commit and, from a Java client library team member standpoint, only this commit makes sense to be reviewed (the rest are IAST related changes to deal with propagation of String and byte[]).

The PR focuses on the interface org.apache.kafka.common.serialization.Deserializer and instruments:

Default methods that were not covered previously
New ByteBuffer based methods

manuel-alvarez-alvarez added the comp: asm iast Application Security Management (IAST) label Feb 26, 2024

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch 3 times, most recently from dde095b to 0df35b8 Compare February 26, 2024 10:18

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from 0df35b8 to 8fc9354 Compare February 27, 2024 09:40

manuel-alvarez-alvarez changed the base branch from master to malvarez/iast-accurate-byte-array-tainting February 27, 2024 09:40

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from 8fc9354 to 6a46bef Compare February 27, 2024 09:44

manuel-alvarez-alvarez marked this pull request as ready for review February 27, 2024 09:46

manuel-alvarez-alvarez requested review from a team as code owners February 27, 2024 09:46

manuel-alvarez-alvarez requested review from smola, jandro996, dougqh and PerfectSlayer February 27, 2024 09:46

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch 2 times, most recently from 2c9cf72 to 5bb5bf2 Compare February 27, 2024 11:18

manuel-alvarez-alvarez force-pushed the malvarez/iast-accurate-byte-array-tainting branch from de4b6e7 to ed6082e Compare February 27, 2024 12:20

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from 5bb5bf2 to aff1552 Compare February 27, 2024 12:21

manuel-alvarez-alvarez force-pushed the malvarez/iast-accurate-byte-array-tainting branch from ed6082e to 403a2cb Compare February 27, 2024 13:46

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from aff1552 to b897a99 Compare February 27, 2024 13:47

dougqh approved these changes Feb 27, 2024

View reviewed changes

jandro996 approved these changes Feb 28, 2024

View reviewed changes

manuel-alvarez-alvarez force-pushed the malvarez/iast-accurate-byte-array-tainting branch from 403a2cb to acd9463 Compare February 28, 2024 11:56

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from 0b9fec4 to de15555 Compare February 28, 2024 12:00

manuel-alvarez-alvarez force-pushed the malvarez/iast-accurate-byte-array-tainting branch from acd9463 to f8ed665 Compare February 28, 2024 13:02

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from de15555 to be1aef8 Compare February 28, 2024 13:28

manuel-alvarez-alvarez force-pushed the malvarez/iast-accurate-byte-array-tainting branch from f8ed665 to ba3dfd3 Compare February 28, 2024 14:59

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from be1aef8 to 97a9505 Compare February 28, 2024 14:59

manuel-alvarez-alvarez added the run-tests: all Run all tests label Feb 28, 2024

manuel-alvarez-alvarez force-pushed the malvarez/iast-accurate-byte-array-tainting branch from ba3dfd3 to 8d997b5 Compare February 28, 2024 17:40

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from 97a9505 to 15c29f9 Compare February 28, 2024 17:40

manuel-alvarez-alvarez force-pushed the malvarez/iast-accurate-byte-array-tainting branch from 8d997b5 to 239a272 Compare February 29, 2024 08:20

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from 15c29f9 to f26e3e2 Compare February 29, 2024 08:33

Base automatically changed from malvarez/iast-accurate-byte-array-tainting to master February 29, 2024 10:50

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from f26e3e2 to df9fb8b Compare February 29, 2024 10:54

smola approved these changes Mar 1, 2024

View reviewed changes

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch 5 times, most recently from 61cf65f to 5e18a5d Compare March 5, 2024 17:25

manuel-alvarez-alvarez added 3 commits March 6, 2024 09:16

Add support for kafka bytebuffers in 3.x

a6a84c9

Remove debugger initialization from kafka 2.x smoke test

27dfb0e

Try to make kafka smoke tests non-flaky by using spring reply mechanism

9a13db1

manuel-alvarez-alvarez force-pushed the malvarez/iast-kafka-bytebuff branch from 5e18a5d to 9a13db1 Compare March 6, 2024 08:16

manuel-alvarez-alvarez merged commit 58e35cb into master Mar 6, 2024
131 checks passed

manuel-alvarez-alvarez deleted the malvarez/iast-kafka-bytebuff branch March 6, 2024 12:06

github-actions bot added this to the 1.32.0 milestone Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for kafka bytebuffers in 3.x #6736

Add support for kafka bytebuffers in 3.x #6736

manuel-alvarez-alvarez commented Feb 26, 2024 •

edited by jira bot

pr-commenter bot commented Feb 26, 2024 •

edited

pr-commenter bot commented Feb 26, 2024 •

edited

pr-commenter bot commented Feb 26, 2024 •

edited

PerfectSlayer commented Feb 27, 2024 •

edited

manuel-alvarez-alvarez commented Feb 27, 2024 •

edited

Add support for kafka bytebuffers in 3.x #6736

Add support for kafka bytebuffers in 3.x #6736

Conversation

manuel-alvarez-alvarez commented Feb 26, 2024 • edited by jira bot

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Feb 26, 2024 • edited

Kafka / producer-benchmark

Parameters

Summary

pr-commenter bot commented Feb 26, 2024 • edited

Benchmarks

Startup

Parameters

Summary

Load

pr-commenter bot commented Feb 26, 2024 • edited

Kafka / consumer-benchmark

Parameters

Summary

PerfectSlayer commented Feb 27, 2024 • edited

manuel-alvarez-alvarez commented Feb 27, 2024 • edited

manuel-alvarez-alvarez commented Feb 26, 2024 •

edited by jira bot

pr-commenter bot commented Feb 26, 2024 •

edited

pr-commenter bot commented Feb 26, 2024 •

edited

pr-commenter bot commented Feb 26, 2024 •

edited

PerfectSlayer commented Feb 27, 2024 •

edited

manuel-alvarez-alvarez commented Feb 27, 2024 •

edited