Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instrumentations to use InstrumenterModule as the service type #6808

Merged
merged 2 commits into from Mar 13, 2024
Merged

Update instrumentations to use InstrumenterModule as the service type #6808

merged 2 commits into from Mar 13, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 12, 2024 •
edited by jira bot

What Does This Do

This PR changes the key type used to register instrumentations from Instrumenter to InstrumenterModule.

Motivation

Previous PRs introduced the concept of InstrumenterModule for better alignment with OTel concepts. This continues that alignment by making InstrumenterModule the primary service type used to register and discover instrumentations. This lets us remove various instanceof checks and casts throughout the code.

Jira ticket: AIT-9441

@mcculls mcculls force-pushed the mcculls/instrumenter-module-first branch from 94a8ddf to f19b62c Compare March 12, 2024 23:40
@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2024 •
edited

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/instrumenter-module-first
git_commit_date 1710342911 1710364307
git_commit_sha cd18597 75f7315
See matching parameters
Baseline Candidate
ci_job_date 1710365522 1710365522
ci_job_id 459317701 459317701
ci_pipeline_id 30066789 30066789
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@mcculls mcculls force-pushed the mcculls/instrumenter-module-first branch from f19b62c to 3403482 Compare March 12, 2024 23:55
@pr-commenter
Copy link

pr-commenter bot commented Mar 13, 2024 •
edited

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/instrumenter-module-first
git_commit_date 1710342911 1710364307
git_commit_sha cd18597 75f7315
See matching parameters
Baseline Candidate
ci_job_date 1710365587 1710365587
ci_job_id 459317702 459317702
ci_pipeline_id 30066789 30066789
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario Δ mean throughput
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume better
[+5128.330op/s; +26779.637op/s] or [+1.708%; +8.920%]
See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume unsure
[+898.183op/s; +15429.031op/s] or [+0.301%; +5.167%]

@pr-commenter
Copy link

pr-commenter bot commented Mar 13, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/instrumenter-module-first
git_commit_date 1710342911 1710364307
git_commit_sha cd18597 75f7315
release_version 1.32.0-SNAPSHOT~cd18597747 1.32.0-SNAPSHOT~75f731518c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1710367537 1710367537
ci_job_id 459317700 459317700
ci_pipeline_id 30066789 30066789
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~75f731518c, baseline=1.32.0-SNAPSHOT~cd18597747

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080047
Total [baseline] (8.56 s) : 0, 8560264
Agent [candidate] (1.079 s) : 0, 1079414
Total [candidate] (8.6 s) : 0, 8600003
section iast
Agent [baseline] (1.204 s) : 0, 1203968
Total [baseline] (9.038 s) : 0, 9037585
Agent [candidate] (1.208 s) : 0, 1208229
Total [candidate] (9.059 s) : 0, 9058958
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1206003
Total [baseline] (9.016 s) : 0, 9015813
Agent [candidate] (1.219 s) : 0, 1219432
Total [candidate] (9.056 s) : 0, 9055852
section iast_TELEMETRY_OFF
Agent [baseline] (1.21 s) : 0, 1209538
Total [baseline] (9.088 s) : 0, 9087889
Agent [candidate] (1.199 s) : 0, 1199434
Total [candidate] (9.027 s) : 0, 9027020
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.204 s 123.921 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 125.956 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.21 s 129.492 ms (12.0%)
Total tracing 8.56 s -
Total iast 9.038 s 477.321 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.016 s 455.549 ms (5.3%)
Total iast_TELEMETRY_OFF 9.088 s 527.625 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent iast 1.208 s 128.815 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.219 s 140.018 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.199 s 120.02 ms (11.1%)
Total tracing 8.6 s -
Total iast 9.059 s 458.955 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.056 s 455.848 ms (5.3%)
Total iast_TELEMETRY_OFF 9.027 s 427.017 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~75f731518c, baseline=1.32.0-SNAPSHOT~cd18597747

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.494 ms) : 0, 696494
BytebuddyAgent [candidate] (695.974 ms) : 0, 695974
GlobalTracer [baseline] (291.507 ms) : 0, 291507
GlobalTracer [candidate] (291.697 ms) : 0, 291697
AppSec [baseline] (49.255 ms) : 0, 49255
AppSec [candidate] (49.048 ms) : 0, 49048
Remote Config [baseline] (737.569 µs) : 0, 738
Remote Config [candidate] (724.161 µs) : 0, 724
Telemetry [baseline] (7.707 ms) : 0, 7707
Telemetry [candidate] (7.736 ms) : 0, 7736
section iast
BytebuddyAgent [baseline] (800.681 ms) : 0, 800681
BytebuddyAgent [candidate] (802.819 ms) : 0, 802819
GlobalTracer [baseline] (287.89 ms) : 0, 287890
GlobalTracer [candidate] (289.631 ms) : 0, 289631
AppSec [baseline] (49.023 ms) : 0, 49023
AppSec [candidate] (49.691 ms) : 0, 49691
Remote Config [baseline] (605.93 µs) : 0, 606
Remote Config [candidate] (623.082 µs) : 0, 623
Telemetry [baseline] (6.588 ms) : 0, 6588
Telemetry [candidate] (6.687 ms) : 0, 6687
IAST [baseline] (24.762 ms) : 0, 24762
IAST [candidate] (24.143 ms) : 0, 24143
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.806 ms) : 0, 800806
BytebuddyAgent [candidate] (810.918 ms) : 0, 810918
GlobalTracer [baseline] (289.14 ms) : 0, 289140
GlobalTracer [candidate] (290.972 ms) : 0, 290972
AppSec [baseline] (50.253 ms) : 0, 50253
AppSec [candidate] (50.601 ms) : 0, 50601
Remote Config [baseline] (627.659 µs) : 0, 628
Remote Config [candidate] (624.291 µs) : 0, 624
Telemetry [baseline] (7.446 ms) : 0, 7446
Telemetry [candidate] (6.841 ms) : 0, 6841
IAST [baseline] (23.215 ms) : 0, 23215
IAST [candidate] (24.581 ms) : 0, 24581
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.342 ms) : 0, 801342
BytebuddyAgent [candidate] (794.162 ms) : 0, 794162
GlobalTracer [baseline] (291.798 ms) : 0, 291798
GlobalTracer [candidate] (290.025 ms) : 0, 290025
AppSec [baseline] (50.386 ms) : 0, 50386
AppSec [candidate] (51.297 ms) : 0, 51297
Remote Config [baseline] (583.392 µs) : 0, 583
Remote Config [candidate] (580.084 µs) : 0, 580
Telemetry [baseline] (8.043 ms) : 0, 8043
Telemetry [candidate] (6.516 ms) : 0, 6516
IAST [baseline] (22.724 ms) : 0, 22724
IAST [candidate] (22.406 ms) : 0, 22406
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~75f731518c, baseline=1.32.0-SNAPSHOT~cd18597747

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080992
Total [baseline] (9.171 s) : 0, 9171294
Agent [candidate] (1.09 s) : 0, 1090295
Total [candidate] (9.231 s) : 0, 9231022
section appsec
Agent [baseline] (1.198 s) : 0, 1198302
Total [baseline] (9.277 s) : 0, 9276724
Agent [candidate] (1.205 s) : 0, 1204713
Total [candidate] (9.299 s) : 0, 9299294
section iast
Agent [baseline] (1.212 s) : 0, 1212134
Total [baseline] (9.398 s) : 0, 9397513
Agent [candidate] (1.214 s) : 0, 1214183
Total [candidate] (9.398 s) : 0, 9398371
section profiling
Agent [baseline] (1.282 s) : 0, 1281644
Total [baseline] (9.372 s) : 0, 9372385
Agent [candidate] (1.273 s) : 0, 1272912
Total [candidate] (9.333 s) : 0, 9332712
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.198 s 117.311 ms (10.9%)
Agent iast 1.212 s 131.142 ms (12.1%)
Agent profiling 1.282 s 200.652 ms (18.6%)
Total tracing 9.171 s -
Total appsec 9.277 s 105.429 ms (1.1%)
Total iast 9.398 s 226.218 ms (2.5%)
Total profiling 9.372 s 201.091 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent appsec 1.205 s 114.418 ms (10.5%)
Agent iast 1.214 s 123.888 ms (11.4%)
Agent profiling 1.273 s 182.616 ms (16.7%)
Total tracing 9.231 s -
Total appsec 9.299 s 68.272 ms (0.7%)
Total iast 9.398 s 167.349 ms (1.8%)
Total profiling 9.333 s 101.69 ms (1.1%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~75f731518c, baseline=1.32.0-SNAPSHOT~cd18597747

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.199 ms) : 0, 697199
BytebuddyAgent [candidate] (702.493 ms) : 0, 702493
GlobalTracer [baseline] (291.894 ms) : 0, 291894
GlobalTracer [candidate] (295.045 ms) : 0, 295045
AppSec [baseline] (49.074 ms) : 0, 49074
AppSec [candidate] (49.505 ms) : 0, 49505
Remote Config [baseline] (725.303 µs) : 0, 725
Remote Config [candidate] (746.55 µs) : 0, 747
Telemetry [baseline] (7.707 ms) : 0, 7707
Telemetry [candidate] (7.801 ms) : 0, 7801
section appsec
BytebuddyAgent [baseline] (694.804 ms) : 0, 694804
BytebuddyAgent [candidate] (698.247 ms) : 0, 698247
GlobalTracer [baseline] (290.584 ms) : 0, 290584
GlobalTracer [candidate] (292.766 ms) : 0, 292766
AppSec [baseline] (153.16 ms) : 0, 153160
AppSec [candidate] (153.772 ms) : 0, 153772
Remote Config [baseline] (607.26 µs) : 0, 607
Remote Config [candidate] (611.63 µs) : 0, 612
Telemetry [baseline] (6.91 ms) : 0, 6910
Telemetry [candidate] (6.934 ms) : 0, 6934
IAST [baseline] (17.87 ms) : 0, 17870
IAST [candidate] (17.944 ms) : 0, 17944
section iast
BytebuddyAgent [baseline] (805.86 ms) : 0, 805860
BytebuddyAgent [candidate] (807.544 ms) : 0, 807544
GlobalTracer [baseline] (289.877 ms) : 0, 289877
GlobalTracer [candidate] (290.884 ms) : 0, 290884
AppSec [baseline] (50.365 ms) : 0, 50365
AppSec [candidate] (51.537 ms) : 0, 51537
Remote Config [baseline] (610.176 µs) : 0, 610
Remote Config [candidate] (614.23 µs) : 0, 614
Telemetry [baseline] (6.724 ms) : 0, 6724
Telemetry [candidate] (6.737 ms) : 0, 6737
IAST [baseline] (23.904 ms) : 0, 23904
IAST [candidate] (22.033 ms) : 0, 22033
section profiling
BytebuddyAgent [baseline] (694.125 ms) : 0, 694125
BytebuddyAgent [candidate] (688.555 ms) : 0, 688555
GlobalTracer [baseline] (378.089 ms) : 0, 378089
GlobalTracer [candidate] (376.382 ms) : 0, 376382
AppSec [baseline] (49.892 ms) : 0, 49892
AppSec [candidate] (49.729 ms) : 0, 49729
Remote Config [baseline] (796.467 µs) : 0, 796
Remote Config [candidate] (779.84 µs) : 0, 780
Telemetry [baseline] (7.457 ms) : 0, 7457
Telemetry [candidate] (7.402 ms) : 0, 7402
ProfilingAgent [baseline] (94.778 ms) : 0, 94778
ProfilingAgent [candidate] (94.03 ms) : 0, 94030
Profiling [baseline] (94.801 ms) : 0, 94801
Profiling [candidate] (94.053 ms) : 0, 94053

Load

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~75f731518c, baseline=1.32.0-SNAPSHOT~cd18597747
    dateFormat X
    axisFormat %s
section baseline
no_agent (358.92 µs) : 339, 379
.   : milestone, 359,
iast (465.829 µs) : 446, 486
.   : milestone, 466,
iast_FULL (532.366 µs) : 512, 553
.   : milestone, 532,
iast_GLOBAL (495.383 µs) : 474, 517
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (468.009 µs) : 448, 488
.   : milestone, 468,
iast_INACTIVE (444.312 µs) : 424, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (470.074 µs) : 449, 491
.   : milestone, 470,
tracing (442.673 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (362.811 µs) : 343, 383
.   : milestone, 363,
iast (470.036 µs) : 449, 491
.   : milestone, 470,
iast_FULL (533.648 µs) : 513, 554
.   : milestone, 534,
iast_GLOBAL (490.413 µs) : 469, 512
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (470.565 µs) : 450, 491
.   : milestone, 471,
iast_INACTIVE (445.045 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (471.98 µs) : 451, 493
.   : milestone, 472,
tracing (438.042 µs) : 418, 458
.   : milestone, 438,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.92 µs [339.117 µs, 378.722 µs] -
iast 465.829 µs [445.599 µs, 486.06 µs] 106.91 µs (29.8%)
iast_FULL 532.366 µs [511.935 µs, 552.798 µs] 173.447 µs (48.3%)
iast_GLOBAL 495.383 µs [473.579 µs, 517.187 µs] 136.463 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 468.009 µs [447.526 µs, 488.493 µs] 109.09 µs (30.4%)
iast_INACTIVE 444.312 µs [423.644 µs, 464.98 µs] 85.392 µs (23.8%)
iast_TELEMETRY_OFF 470.074 µs [449.489 µs, 490.659 µs] 111.155 µs (31.0%)
tracing 442.673 µs [421.615 µs, 463.73 µs] 83.753 µs (23.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.811 µs [342.789 µs, 382.834 µs] -
iast 470.036 µs [449.345 µs, 490.726 µs] 107.224 µs (29.6%)
iast_FULL 533.648 µs [513.166 µs, 554.129 µs] 170.836 µs (47.1%)
iast_GLOBAL 490.413 µs [469.011 µs, 511.816 µs] 127.602 µs (35.2%)
iast_HARDCODED_SECRET_DISABLED 470.565 µs [450.107 µs, 491.022 µs] 107.753 µs (29.7%)
iast_INACTIVE 445.045 µs [424.543 µs, 465.546 µs] 82.233 µs (22.7%)
iast_TELEMETRY_OFF 471.98 µs [450.683 µs, 493.278 µs] 109.169 µs (30.1%)
tracing 438.042 µs [417.604 µs, 458.48 µs] 75.23 µs (20.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~75f731518c, baseline=1.32.0-SNAPSHOT~cd18597747
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.757 ms) : 1733, 1781
.   : milestone, 1757,
iast (1.532 ms) : 1509, 1555
.   : milestone, 1532,
profiling (1.505 ms) : 1482, 1529
.   : milestone, 1505,
tracing (1.488 ms) : 1465, 1512
.   : milestone, 1488,
section candidate
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.756 ms) : 1733, 1780
.   : milestone, 1756,
iast (1.544 ms) : 1521, 1567
.   : milestone, 1544,
profiling (1.564 ms) : 1540, 1589
.   : milestone, 1564,
tracing (1.48 ms) : 1456, 1503
.   : milestone, 1480,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.757 ms [1.733 ms, 1.781 ms] 414.191 µs (30.8%)
iast 1.532 ms [1.509 ms, 1.555 ms] 188.743 µs (14.1%)
profiling 1.505 ms [1.482 ms, 1.529 ms] 161.93 µs (12.1%)
tracing 1.488 ms [1.465 ms, 1.512 ms] 145.314 µs (10.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.332 ms, 1.37 ms] -
appsec 1.756 ms [1.733 ms, 1.78 ms] 405.151 µs (30.0%)
iast 1.544 ms [1.521 ms, 1.567 ms] 192.994 µs (14.3%)
profiling 1.564 ms [1.54 ms, 1.589 ms] 213.001 µs (15.8%)
tracing 1.48 ms [1.456 ms, 1.503 ms] 128.288 µs (9.5%)

@mcculls mcculls force-pushed the mcculls/instrumenter-module-first branch 4 times, most recently from 0cc0084 to 2d967ae Compare March 13, 2024 12:46
@mcculls mcculls changed the title [WIP] Iterate over InstrumenterModule services instead of Instrumenters Update instrumentations to use InstrumenterModule as the service type Mar 13, 2024
@mcculls mcculls added comp: core Tracer core and removed tag: do not merge Do not merge changes labels Mar 13, 2024
@mcculls mcculls marked this pull request as ready for review March 13, 2024 12:57
@mcculls mcculls requested review from a team as code owners March 13, 2024 12:57
@am312
Copy link
Contributor

am312 commented Mar 13, 2024

I'll update the docs to recommend InstrumenterModule.class instead of Instrumenter.class.

@am312 am312 mentioned this pull request Mar 13, 2024
Closed
@mcculls
Copy link
Contributor Author

mcculls commented Mar 13, 2024

@am312 this PR already updates the docs, see the diffs right at the end :)

@mcculls mcculls force-pushed the mcculls/instrumenter-module-first branch from 2d967ae to 75f7315 Compare March 13, 2024 21:12
@mcculls mcculls merged commit ee9c0f8 into master Mar 13, 2024
82 checks passed
@mcculls mcculls deleted the mcculls/instrumenter-module-first branch March 13, 2024 22:15
@github-actions github-actions bot added this to the 1.32.0 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

@am312 am312 am312 approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog nikita-tkachenko-datadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: core Tracer core type: refactoring
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcculls @am312 @dougqh