Fix spurious context clear when thread detached from wallclock profiling #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbachorik
approved these changes
Mar 22, 2024
PerfectSlayer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
#6261 introduced a regression by conflating detachment from wallclock profiling with clearing profiling context, but sometimes we have to detach the current thread to avoid signalling it when it goes off CPU in certain states (e.g. to workaround a JDK bug where interrupted socket connects do not reduce the timeout before resuming) but the current thread should retain its context for all purposes.
Motivation
Additional Notes
Jira ticket: [PROJ-IDENT]