Upgrade ddprof to 1.3.0 #6845

richardstartin · 2024-03-26T09:22:46Z

What Does This Do

Two minor changes:

Change the way queue timestamps are recorded
Add a start time to internal counters to make the .jfr files we produce readable by the JFR CLI tool

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-03-26T10:30:11Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/upgrade-ddprof-1.3.0
git_commit_date	1711366976	1711444848
git_commit_sha	`bfd3a15`	`79491e6`
release_version	1.32.0-SNAPSHOT~bfd3a15e17	1.32.0-SNAPSHOT~79491e662b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1711448962	1711448962
ci_job_id	469303875	469303875
ci_pipeline_id	30810518	30810518
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~79491e662b, baseline=1.32.0-SNAPSHOT~bfd3a15e17

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079719
Total [baseline] (10.423 s) : 0, 10423134
Agent [candidate] (1.076 s) : 0, 1075777
Total [candidate] (10.375 s) : 0, 10375439
section appsec
Agent [baseline] (1.198 s) : 0, 1197957
Total [baseline] (10.48 s) : 0, 10480438
Agent [candidate] (1.199 s) : 0, 1198544
Total [candidate] (10.536 s) : 0, 10536052
section iast
Agent [baseline] (1.207 s) : 0, 1207135
Total [baseline] (10.882 s) : 0, 10882338
Agent [candidate] (1.198 s) : 0, 1198225
Total [candidate] (10.999 s) : 0, 10998593
section profiling
Agent [baseline] (1.271 s) : 0, 1270523
Total [baseline] (10.624 s) : 0, 10624024
Agent [candidate] (1.277 s) : 0, 1276608
Total [candidate] (10.59 s) : 0, 10589594

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	appsec	1.198 s	118.237 ms (11.0%)
Agent	iast	1.207 s	127.415 ms (11.8%)
Agent	profiling	1.271 s	190.804 ms (17.7%)
Total	tracing	10.423 s	-
Total	appsec	10.48 s	57.305 ms (0.5%)
Total	iast	10.882 s	459.205 ms (4.4%)
Total	profiling	10.624 s	200.89 ms (1.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	appsec	1.199 s	122.767 ms (11.4%)
Agent	iast	1.198 s	122.448 ms (11.4%)
Agent	profiling	1.277 s	200.831 ms (18.7%)
Total	tracing	10.375 s	-
Total	appsec	10.536 s	160.613 ms (1.5%)
Total	iast	10.999 s	623.154 ms (6.0%)
Total	profiling	10.59 s	214.155 ms (2.1%)

gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~79491e662b, baseline=1.32.0-SNAPSHOT~bfd3a15e17

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.763 ms) : 0, 688763
BytebuddyAgent [candidate] (685.141 ms) : 0, 685141
GlobalTracer [baseline] (298.429 ms) : 0, 298429
GlobalTracer [candidate] (298.3 ms) : 0, 298300
AppSec [baseline] (49.426 ms) : 0, 49426
AppSec [candidate] (49.337 ms) : 0, 49337
Remote Config [baseline] (1.066 ms) : 0, 1066
Remote Config [candidate] (1.052 ms) : 0, 1052
Telemetry [baseline] (7.525 ms) : 0, 7525
Telemetry [candidate] (7.483 ms) : 0, 7483
section appsec
BytebuddyAgent [baseline] (693.179 ms) : 0, 693179
BytebuddyAgent [candidate] (693.142 ms) : 0, 693142
GlobalTracer [baseline] (290.89 ms) : 0, 290890
GlobalTracer [candidate] (291.467 ms) : 0, 291467
AppSec [baseline] (153.569 ms) : 0, 153569
AppSec [candidate] (153.56 ms) : 0, 153560
IAST [baseline] (18.635 ms) : 0, 18635
IAST [candidate] (18.639 ms) : 0, 18639
Remote Config [baseline] (605.191 µs) : 0, 605
Remote Config [candidate] (602.28 µs) : 0, 602
Telemetry [baseline] (6.743 ms) : 0, 6743
Telemetry [candidate] (6.74 ms) : 0, 6740
section iast
BytebuddyAgent [baseline] (799.946 ms) : 0, 799946
BytebuddyAgent [candidate] (792.84 ms) : 0, 792840
GlobalTracer [baseline] (290.526 ms) : 0, 290526
GlobalTracer [candidate] (288.646 ms) : 0, 288646
AppSec [baseline] (49.502 ms) : 0, 49502
AppSec [candidate] (47.663 ms) : 0, 47663
IAST [baseline] (24.501 ms) : 0, 24501
IAST [candidate] (26.82 ms) : 0, 26820
Remote Config [baseline] (578.853 µs) : 0, 579
Remote Config [candidate] (586.49 µs) : 0, 586
Telemetry [baseline] (7.446 ms) : 0, 7446
Telemetry [candidate] (7.408 ms) : 0, 7408
section profiling
BytebuddyAgent [baseline] (679.744 ms) : 0, 679744
BytebuddyAgent [candidate] (681.993 ms) : 0, 681993
GlobalTracer [baseline] (380.325 ms) : 0, 380325
GlobalTracer [candidate] (383.542 ms) : 0, 383542
AppSec [baseline] (50.041 ms) : 0, 50041
AppSec [candidate] (50.274 ms) : 0, 50274
Remote Config [baseline] (809.323 µs) : 0, 809
Remote Config [candidate] (888.495 µs) : 0, 888
Telemetry [baseline] (7.488 ms) : 0, 7488
Telemetry [candidate] (7.522 ms) : 0, 7522
ProfilingAgent [baseline] (95.552 ms) : 0, 95552
ProfilingAgent [candidate] (95.771 ms) : 0, 95771
Profiling [baseline] (95.576 ms) : 0, 95576
Profiling [candidate] (95.795 ms) : 0, 95795

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~79491e662b, baseline=1.32.0-SNAPSHOT~bfd3a15e17

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073930
Total [baseline] (8.555 s) : 0, 8554901
Agent [candidate] (1.074 s) : 0, 1073633
Total [candidate] (8.568 s) : 0, 8567594
section iast
Agent [baseline] (1.196 s) : 0, 1195587
Total [baseline] (9.1 s) : 0, 9100328
Agent [candidate] (1.207 s) : 0, 1207272
Total [candidate] (9.131 s) : 0, 9130907
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1198484
Total [baseline] (9.069 s) : 0, 9069388
Agent [candidate] (1.201 s) : 0, 1201097
Total [candidate] (9.082 s) : 0, 9082014
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1192687
Total [baseline] (9.027 s) : 0, 9026636
Agent [candidate] (1.203 s) : 0, 1203123
Total [candidate] (9.065 s) : 0, 9065000

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.074 s	-
Agent	iast	1.196 s	121.656 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.198 s	124.554 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.193 s	118.757 ms (11.1%)
Total	tracing	8.555 s	-
Total	iast	9.1 s	545.427 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.069 s	514.486 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.027 s	471.734 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.074 s	-
Agent	iast	1.207 s	133.64 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.201 s	127.464 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.203 s	129.49 ms (12.1%)
Total	tracing	8.568 s	-
Total	iast	9.131 s	563.313 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.082 s	514.419 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.065 s	497.406 ms (5.8%)

gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~79491e662b, baseline=1.32.0-SNAPSHOT~bfd3a15e17

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.811 ms) : 0, 684811
BytebuddyAgent [candidate] (684.439 ms) : 0, 684439
GlobalTracer [baseline] (296.99 ms) : 0, 296990
GlobalTracer [candidate] (296.951 ms) : 0, 296951
AppSec [baseline] (49.176 ms) : 0, 49176
AppSec [candidate] (49.222 ms) : 0, 49222
Remote Config [baseline] (1.042 ms) : 0, 1042
Remote Config [candidate] (1.045 ms) : 0, 1045
Telemetry [baseline] (7.495 ms) : 0, 7495
Telemetry [candidate] (7.613 ms) : 0, 7613
section iast
BytebuddyAgent [baseline] (791.657 ms) : 0, 791657
BytebuddyAgent [candidate] (799.157 ms) : 0, 799157
GlobalTracer [baseline] (287.758 ms) : 0, 287758
GlobalTracer [candidate] (290.715 ms) : 0, 290715
AppSec [baseline] (51.847 ms) : 0, 51847
AppSec [candidate] (52.275 ms) : 0, 52275
IAST [baseline] (22.034 ms) : 0, 22034
IAST [candidate] (23.194 ms) : 0, 23194
Remote Config [baseline] (581.161 µs) : 0, 581
Remote Config [candidate] (594.895 µs) : 0, 595
Telemetry [baseline] (7.445 ms) : 0, 7445
Telemetry [candidate] (6.763 ms) : 0, 6763
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.35 ms) : 0, 793350
BytebuddyAgent [candidate] (795.266 ms) : 0, 795266
GlobalTracer [baseline] (288.869 ms) : 0, 288869
GlobalTracer [candidate] (289.734 ms) : 0, 289734
AppSec [baseline] (50.254 ms) : 0, 50254
AppSec [candidate] (49.477 ms) : 0, 49477
IAST [baseline] (23.513 ms) : 0, 23513
IAST [candidate] (23.473 ms) : 0, 23473
Remote Config [baseline] (580.962 µs) : 0, 581
Remote Config [candidate] (588.506 µs) : 0, 589
Telemetry [baseline] (7.426 ms) : 0, 7426
Telemetry [candidate] (8.153 ms) : 0, 8153
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.078 ms) : 0, 789078
BytebuddyAgent [candidate] (795.284 ms) : 0, 795284
GlobalTracer [baseline] (287.886 ms) : 0, 287886
GlobalTracer [candidate] (291.071 ms) : 0, 291071
AppSec [baseline] (48.855 ms) : 0, 48855
AppSec [candidate] (50.236 ms) : 0, 50236
IAST [baseline] (25.555 ms) : 0, 25555
IAST [candidate] (24.082 ms) : 0, 24082
Remote Config [baseline] (565.668 µs) : 0, 566
Remote Config [candidate] (577.692 µs) : 0, 578
Telemetry [baseline] (6.457 ms) : 0, 6457
Telemetry [candidate] (7.285 ms) : 0, 7285

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-03-26T10:01:32	2024-03-26T10:23:35
git_branch	master	rgs/upgrade-ddprof-1.3.0
git_commit_date	1711366976	1711444848
git_commit_sha	`bfd3a15`	`79491e6`
release_version	1.32.0-SNAPSHOT~bfd3a15e17	1.32.0-SNAPSHOT~79491e662b
start_time	2024-03-26T10:01:19	2024-03-26T10:23:22

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1711448962	1711448962
ci_job_id	469303875	469303875
ci_pipeline_id	30810518	30810518
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~79491e662b, baseline=1.32.0-SNAPSHOT~bfd3a15e17
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1313, 1352
.   : milestone, 1332,
appsec (1.75 ms) : 1726, 1774
.   : milestone, 1750,
appsec_no_iast (1.751 ms) : 1727, 1774
.   : milestone, 1751,
iast (1.496 ms) : 1473, 1519
.   : milestone, 1496,
profiling (1.481 ms) : 1457, 1505
.   : milestone, 1481,
tracing (1.474 ms) : 1450, 1498
.   : milestone, 1474,
section candidate
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.768 ms) : 1744, 1793
.   : milestone, 1768,
appsec_no_iast (1.753 ms) : 1729, 1777
.   : milestone, 1753,
iast (1.481 ms) : 1458, 1505
.   : milestone, 1481,
profiling (1.498 ms) : 1474, 1522
.   : milestone, 1498,
tracing (1.483 ms) : 1460, 1506
.   : milestone, 1483,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.332 ms [1.313 ms, 1.352 ms]	-
appsec	1.75 ms [1.726 ms, 1.774 ms]	417.659 µs (31.3%)
appsec_no_iast	1.751 ms [1.727 ms, 1.774 ms]	418.158 µs (31.4%)
iast	1.496 ms [1.473 ms, 1.519 ms]	163.694 µs (12.3%)
profiling	1.481 ms [1.457 ms, 1.505 ms]	148.569 µs (11.2%)
tracing	1.474 ms [1.45 ms, 1.498 ms]	141.605 µs (10.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.348 ms [1.329 ms, 1.367 ms]	-
appsec	1.768 ms [1.744 ms, 1.793 ms]	420.549 µs (31.2%)
appsec_no_iast	1.753 ms [1.729 ms, 1.777 ms]	405.188 µs (30.1%)
iast	1.481 ms [1.458 ms, 1.505 ms]	133.605 µs (9.9%)
profiling	1.498 ms [1.474 ms, 1.522 ms]	150.227 µs (11.1%)
tracing	1.483 ms [1.46 ms, 1.506 ms]	135.104 µs (10.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~79491e662b, baseline=1.32.0-SNAPSHOT~bfd3a15e17
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.374 µs) : 351, 390
.   : milestone, 370,
iast (476.887 µs) : 456, 498
.   : milestone, 477,
iast_FULL (542.522 µs) : 522, 563
.   : milestone, 543,
iast_GLOBAL (500.175 µs) : 479, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (477.391 µs) : 457, 498
.   : milestone, 477,
iast_INACTIVE (447.019 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (477.502 µs) : 456, 499
.   : milestone, 478,
tracing (450.128 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (362.678 µs) : 343, 383
.   : milestone, 363,
iast (481.039 µs) : 461, 502
.   : milestone, 481,
iast_FULL (542.179 µs) : 522, 563
.   : milestone, 542,
iast_GLOBAL (490.006 µs) : 470, 510
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (471.103 µs) : 450, 492
.   : milestone, 471,
iast_INACTIVE (450.141 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (472.373 µs) : 451, 494
.   : milestone, 472,
tracing (445.278 µs) : 424, 467
.   : milestone, 445,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.374 µs [350.802 µs, 389.945 µs]	-
iast	476.887 µs [455.806 µs, 497.968 µs]	106.513 µs (28.8%)
iast_FULL	542.522 µs [521.736 µs, 563.307 µs]	172.148 µs (46.5%)
iast_GLOBAL	500.175 µs [479.351 µs, 520.999 µs]	129.801 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED	477.391 µs [456.667 µs, 498.115 µs]	107.017 µs (28.9%)
iast_INACTIVE	447.019 µs [425.743 µs, 468.295 µs]	76.645 µs (20.7%)
iast_TELEMETRY_OFF	477.502 µs [455.985 µs, 499.02 µs]	107.129 µs (28.9%)
tracing	450.128 µs [429.154 µs, 471.101 µs]	79.754 µs (21.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	362.678 µs [342.541 µs, 382.815 µs]	-
iast	481.039 µs [460.572 µs, 501.507 µs]	118.362 µs (32.6%)
iast_FULL	542.179 µs [521.751 µs, 562.606 µs]	179.501 µs (49.5%)
iast_GLOBAL	490.006 µs [469.718 µs, 510.294 µs]	127.328 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED	471.103 µs [450.347 µs, 491.858 µs]	108.425 µs (29.9%)
iast_INACTIVE	450.141 µs [429.477 µs, 470.804 µs]	87.463 µs (24.1%)
iast_TELEMETRY_OFF	472.373 µs [450.961 µs, 493.784 µs]	109.695 µs (30.2%)
tracing	445.278 µs [423.981 µs, 466.574 µs]	82.6 µs (22.8%)

Upgrade ddprof to 1.3.0

79491e6

richardstartin added the comp: profiling Profiling label Mar 26, 2024

jbachorik approved these changes Mar 26, 2024

View reviewed changes

richardstartin marked this pull request as ready for review March 26, 2024 12:18

richardstartin requested a review from a team as a code owner March 26, 2024 12:18

richardstartin requested review from dougqh and nayeem-kamal March 26, 2024 12:18

richardstartin merged commit 557e309 into master Mar 26, 2024
81 of 83 checks passed

richardstartin deleted the rgs/upgrade-ddprof-1.3.0 branch March 26, 2024 12:18

github-actions bot added this to the 1.32.0 milestone Mar 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ddprof to 1.3.0 #6845

Upgrade ddprof to 1.3.0 #6845

richardstartin commented Mar 26, 2024

pr-commenter bot commented Mar 26, 2024

Upgrade ddprof to 1.3.0 #6845

Upgrade ddprof to 1.3.0 #6845

Conversation

richardstartin commented Mar 26, 2024

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Mar 26, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary