Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump java-dogstatsd-client to 4.3.0 #6851

Merged
merged 2 commits into from Mar 27, 2024
Merged

Bump java-dogstatsd-client to 4.3.0 #6851

merged 2 commits into from Mar 27, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 27, 2024 •
edited

@mcculls mcculls added tag: dependencies Dependencies related changes tag: do not merge Do not merge changes labels Mar 27, 2024
@mcculls mcculls changed the title java-dogstatsd-client 4.3.0 [WIP] java-dogstatsd-client 4.3.0 Mar 27, 2024
@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/java-dogstatsd-client-4.3.0
git_commit_date 1711527778 1711534051
git_commit_sha 07789b4 dd03e23
release_version 1.32.0-SNAPSHOT~07789b497d 1.32.0-SNAPSHOT~dd03e23d90
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711537435 1711537435
ci_job_id 470560633 470560633
ci_pipeline_id 30903902 30903902
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~dd03e23d90, baseline=1.32.0-SNAPSHOT~07789b497d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074975
Total [baseline] (10.4 s) : 0, 10400233
Agent [candidate] (1.075 s) : 0, 1075076
Total [candidate] (10.507 s) : 0, 10507389
section appsec
Agent [baseline] (1.198 s) : 0, 1197972
Total [baseline] (10.6 s) : 0, 10599726
Agent [candidate] (1.199 s) : 0, 1199456
Total [candidate] (10.501 s) : 0, 10500882
section iast
Agent [baseline] (1.2 s) : 0, 1200177
Total [baseline] (10.873 s) : 0, 10873463
Agent [candidate] (1.211 s) : 0, 1211139
Total [candidate] (10.953 s) : 0, 10953056
section profiling
Agent [baseline] (1.269 s) : 0, 1269144
Total [baseline] (10.642 s) : 0, 10642435
Agent [candidate] (1.269 s) : 0, 1269467
Total [candidate] (10.583 s) : 0, 10583473
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.198 s 122.998 ms (11.4%)
Agent iast 1.2 s 125.202 ms (11.6%)
Agent profiling 1.269 s 194.169 ms (18.1%)
Total tracing 10.4 s -
Total appsec 10.6 s 199.493 ms (1.9%)
Total iast 10.873 s 473.23 ms (4.6%)
Total profiling 10.642 s 242.203 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.199 s 124.38 ms (11.6%)
Agent iast 1.211 s 136.063 ms (12.7%)
Agent profiling 1.269 s 194.391 ms (18.1%)
Total tracing 10.507 s -
Total appsec 10.501 s -6.507 ms (-0.1%)
Total iast 10.953 s 445.667 ms (4.2%)
Total profiling 10.583 s 76.084 ms (0.7%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~dd03e23d90, baseline=1.32.0-SNAPSHOT~07789b497d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.399 ms) : 0, 685399
BytebuddyAgent [candidate] (685.064 ms) : 0, 685064
GlobalTracer [baseline] (297.401 ms) : 0, 297401
GlobalTracer [candidate] (297.693 ms) : 0, 297693
AppSec [baseline] (49.26 ms) : 0, 49260
AppSec [candidate] (49.321 ms) : 0, 49321
Remote Config [baseline] (1.067 ms) : 0, 1067
Remote Config [candidate] (1.052 ms) : 0, 1052
Telemetry [baseline] (7.533 ms) : 0, 7533
Telemetry [candidate] (7.526 ms) : 0, 7526
section appsec
BytebuddyAgent [baseline] (693.633 ms) : 0, 693633
BytebuddyAgent [candidate] (693.169 ms) : 0, 693169
GlobalTracer [baseline] (290.726 ms) : 0, 290726
GlobalTracer [candidate] (292.098 ms) : 0, 292098
AppSec [baseline] (153.335 ms) : 0, 153335
AppSec [candidate] (153.745 ms) : 0, 153745
Remote Config [baseline] (599.71 µs) : 0, 600
Remote Config [candidate] (606.242 µs) : 0, 606
Telemetry [baseline] (6.752 ms) : 0, 6752
Telemetry [candidate] (6.75 ms) : 0, 6750
IAST [baseline] (18.677 ms) : 0, 18677
IAST [candidate] (18.66 ms) : 0, 18660
section iast
BytebuddyAgent [baseline] (794.49 ms) : 0, 794490
BytebuddyAgent [candidate] (802.533 ms) : 0, 802533
GlobalTracer [baseline] (288.975 ms) : 0, 288975
GlobalTracer [candidate] (291.603 ms) : 0, 291603
AppSec [baseline] (50.056 ms) : 0, 50056
AppSec [candidate] (50.84 ms) : 0, 50840
Remote Config [baseline] (592.026 µs) : 0, 592
Remote Config [candidate] (576.52 µs) : 0, 577
Telemetry [baseline] (6.574 ms) : 0, 6574
Telemetry [candidate] (6.632 ms) : 0, 6632
IAST [baseline] (25.053 ms) : 0, 25053
IAST [candidate] (24.24 ms) : 0, 24240
section profiling
ProfilingAgent [baseline] (95.679 ms) : 0, 95679
ProfilingAgent [candidate] (95.969 ms) : 0, 95969
BytebuddyAgent [baseline] (678.366 ms) : 0, 678366
BytebuddyAgent [candidate] (678.059 ms) : 0, 678059
GlobalTracer [baseline] (380.615 ms) : 0, 380615
GlobalTracer [candidate] (380.96 ms) : 0, 380960
AppSec [baseline] (49.87 ms) : 0, 49870
AppSec [candidate] (49.973 ms) : 0, 49973
Remote Config [baseline] (840.322 µs) : 0, 840
Remote Config [candidate] (831.418 µs) : 0, 831
Telemetry [baseline] (7.412 ms) : 0, 7412
Telemetry [candidate] (7.431 ms) : 0, 7431
Profiling [baseline] (95.703 ms) : 0, 95703
Profiling [candidate] (95.993 ms) : 0, 95993
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~dd03e23d90, baseline=1.32.0-SNAPSHOT~07789b497d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081418
Total [baseline] (8.568 s) : 0, 8568040
Agent [candidate] (1.081 s) : 0, 1081148
Total [candidate] (8.619 s) : 0, 8619355
section iast
Agent [baseline] (1.199 s) : 0, 1198742
Total [baseline] (9.063 s) : 0, 9062947
Agent [candidate] (1.204 s) : 0, 1203631
Total [candidate] (9.104 s) : 0, 9104480
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1204406
Total [baseline] (9.062 s) : 0, 9062076
Agent [candidate] (1.201 s) : 0, 1200920
Total [candidate] (9.07 s) : 0, 9070409
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1196467
Total [baseline] (9.049 s) : 0, 9049096
Agent [candidate] (1.205 s) : 0, 1204771
Total [candidate] (9.07 s) : 0, 9069932
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.199 s 117.324 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 122.988 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.196 s 115.049 ms (10.6%)
Total tracing 8.568 s -
Total iast 9.063 s 494.907 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.062 s 494.036 ms (5.8%)
Total iast_TELEMETRY_OFF 9.049 s 481.056 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.204 s 122.483 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 119.771 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.205 s 123.622 ms (11.4%)
Total tracing 8.619 s -
Total iast 9.104 s 485.125 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.07 s 451.054 ms (5.2%)
Total iast_TELEMETRY_OFF 9.07 s 450.577 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~dd03e23d90, baseline=1.32.0-SNAPSHOT~07789b497d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.618 ms) : 0, 689618
BytebuddyAgent [candidate] (690.097 ms) : 0, 690097
GlobalTracer [baseline] (299.07 ms) : 0, 299070
GlobalTracer [candidate] (298.258 ms) : 0, 298258
AppSec [baseline] (49.519 ms) : 0, 49519
AppSec [candidate] (49.44 ms) : 0, 49440
Remote Config [baseline] (1.117 ms) : 0, 1117
Remote Config [candidate] (1.091 ms) : 0, 1091
Telemetry [baseline] (7.53 ms) : 0, 7530
Telemetry [candidate] (7.548 ms) : 0, 7548
section iast
BytebuddyAgent [baseline] (794.09 ms) : 0, 794090
BytebuddyAgent [candidate] (798.059 ms) : 0, 798059
GlobalTracer [baseline] (288.264 ms) : 0, 288264
GlobalTracer [candidate] (289.273 ms) : 0, 289273
AppSec [baseline] (50.303 ms) : 0, 50303
AppSec [candidate] (51.772 ms) : 0, 51772
IAST [baseline] (24.391 ms) : 0, 24391
IAST [candidate] (22.757 ms) : 0, 22757
Remote Config [baseline] (584.444 µs) : 0, 584
Remote Config [candidate] (567.902 µs) : 0, 568
Telemetry [baseline] (6.696 ms) : 0, 6696
Telemetry [candidate] (6.605 ms) : 0, 6605
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.18 ms) : 0, 798180
BytebuddyAgent [candidate] (794.713 ms) : 0, 794713
GlobalTracer [baseline] (289.851 ms) : 0, 289851
GlobalTracer [candidate] (289.797 ms) : 0, 289797
AppSec [baseline] (51.175 ms) : 0, 51175
AppSec [candidate] (50.541 ms) : 0, 50541
IAST [baseline] (22.614 ms) : 0, 22614
IAST [candidate] (24.161 ms) : 0, 24161
Remote Config [baseline] (588.449 µs) : 0, 588
Remote Config [candidate] (595.992 µs) : 0, 596
Telemetry [baseline] (7.337 ms) : 0, 7337
Telemetry [candidate] (6.644 ms) : 0, 6644
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.078 ms) : 0, 792078
BytebuddyAgent [candidate] (796.656 ms) : 0, 796656
GlobalTracer [baseline] (288.986 ms) : 0, 288986
GlobalTracer [candidate] (291.299 ms) : 0, 291299
AppSec [baseline] (48.752 ms) : 0, 48752
AppSec [candidate] (50.151 ms) : 0, 50151
IAST [baseline] (24.423 ms) : 0, 24423
IAST [candidate] (24.157 ms) : 0, 24157
Remote Config [baseline] (567.268 µs) : 0, 567
Remote Config [candidate] (586.142 µs) : 0, 586
Telemetry [baseline] (7.244 ms) : 0, 7244
Telemetry [candidate] (7.319 ms) : 0, 7319

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-03-27T10:36:05 2024-03-27T10:58:08
git_branch master mcculls/java-dogstatsd-client-4.3.0
git_commit_date 1711527778 1711534051
git_commit_sha 07789b4 dd03e23
release_version 1.32.0-SNAPSHOT~07789b497d 1.32.0-SNAPSHOT~dd03e23d90
start_time 2024-03-27T10:35:52 2024-03-27T10:57:55
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711537435 1711537435
ci_job_id 470560633 470560633
ci_pipeline_id 30903902 30903902
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~dd03e23d90, baseline=1.32.0-SNAPSHOT~07789b497d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.729 ms) : 1705, 1754
.   : milestone, 1729,
appsec_no_iast (1.745 ms) : 1721, 1770
.   : milestone, 1745,
iast (1.497 ms) : 1474, 1521
.   : milestone, 1497,
profiling (1.49 ms) : 1466, 1515
.   : milestone, 1490,
tracing (1.487 ms) : 1463, 1511
.   : milestone, 1487,
section candidate
no_agent (1.334 ms) : 1315, 1353
.   : milestone, 1334,
appsec (1.753 ms) : 1729, 1778
.   : milestone, 1753,
appsec_no_iast (1.746 ms) : 1721, 1770
.   : milestone, 1746,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.542 ms) : 1516, 1567
.   : milestone, 1542,
tracing (1.491 ms) : 1467, 1514
.   : milestone, 1491,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.729 ms [1.705 ms, 1.754 ms] 384.537 µs (28.6%)
appsec_no_iast 1.745 ms [1.721 ms, 1.77 ms] 400.15 µs (29.8%)
iast 1.497 ms [1.474 ms, 1.521 ms] 152.367 µs (11.3%)
profiling 1.49 ms [1.466 ms, 1.515 ms] 145.338 µs (10.8%)
tracing 1.487 ms [1.463 ms, 1.511 ms] 142.319 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.353 ms] -
appsec 1.753 ms [1.729 ms, 1.778 ms] 419.403 µs (31.4%)
appsec_no_iast 1.746 ms [1.721 ms, 1.77 ms] 411.736 µs (30.9%)
iast 1.481 ms [1.458 ms, 1.504 ms] 146.946 µs (11.0%)
profiling 1.542 ms [1.516 ms, 1.567 ms] 207.758 µs (15.6%)
tracing 1.491 ms [1.467 ms, 1.514 ms] 156.846 µs (11.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~dd03e23d90, baseline=1.32.0-SNAPSHOT~07789b497d
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.922 µs) : 355, 395
.   : milestone, 375,
iast (474.164 µs) : 454, 495
.   : milestone, 474,
iast_FULL (536.914 µs) : 516, 557
.   : milestone, 537,
iast_GLOBAL (499.046 µs) : 478, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (478.76 µs) : 458, 499
.   : milestone, 479,
iast_INACTIVE (449.71 µs) : 428, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (466.881 µs) : 446, 488
.   : milestone, 467,
tracing (447.732 µs) : 426, 469
.   : milestone, 448,
section candidate
no_agent (366.907 µs) : 348, 386
.   : milestone, 367,
iast (476.941 µs) : 456, 498
.   : milestone, 477,
iast_FULL (548.217 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (491.653 µs) : 471, 512
.   : milestone, 492,
iast_HARDCODED_SECRET_DISABLED (473.106 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (451.817 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (469.756 µs) : 449, 491
.   : milestone, 470,
tracing (445.929 µs) : 425, 467
.   : milestone, 446,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.922 µs [354.981 µs, 394.863 µs] -
iast 474.164 µs [453.694 µs, 494.634 µs] 99.242 µs (26.5%)
iast_FULL 536.914 µs [516.34 µs, 557.488 µs] 161.992 µs (43.2%)
iast_GLOBAL 499.046 µs [477.993 µs, 520.099 µs] 124.124 µs (33.1%)
iast_HARDCODED_SECRET_DISABLED 478.76 µs [458.091 µs, 499.43 µs] 103.838 µs (27.7%)
iast_INACTIVE 449.71 µs [428.341 µs, 471.079 µs] 74.788 µs (19.9%)
iast_TELEMETRY_OFF 466.881 µs [446.204 µs, 487.559 µs] 91.959 µs (24.5%)
tracing 447.732 µs [426.447 µs, 469.017 µs] 72.81 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.907 µs [347.611 µs, 386.203 µs] -
iast 476.941 µs [456.214 µs, 497.669 µs] 110.034 µs (30.0%)
iast_FULL 548.217 µs [527.481 µs, 568.952 µs] 181.31 µs (49.4%)
iast_GLOBAL 491.653 µs [471.195 µs, 512.111 µs] 124.746 µs (34.0%)
iast_HARDCODED_SECRET_DISABLED 473.106 µs [452.42 µs, 493.792 µs] 106.199 µs (28.9%)
iast_INACTIVE 451.817 µs [430.533 µs, 473.1 µs] 84.91 µs (23.1%)
iast_TELEMETRY_OFF 469.756 µs [448.587 µs, 490.925 µs] 102.849 µs (28.0%)
tracing 445.929 µs [425.105 µs, 466.752 µs] 79.022 µs (21.5%)

@mcculls mcculls removed the tag: do not merge Do not merge changes label Mar 27, 2024
@mcculls mcculls changed the title [WIP] java-dogstatsd-client 4.3.0 java-dogstatsd-client 4.3.0 Mar 27, 2024
@mcculls mcculls marked this pull request as ready for review March 27, 2024 12:52
@mcculls mcculls requested a review from a team as a code owner March 27, 2024 12:52
@mcculls mcculls requested review from dougqh and am312 March 27, 2024 12:52
@mcculls mcculls merged commit 5a80fb6 into master Mar 27, 2024
77 checks passed
@mcculls mcculls deleted the mcculls/java-dogstatsd-client-4.3.0 branch March 27, 2024 13:09
@github-actions github-actions bot added this to the 1.32.0 milestone Mar 27, 2024
@PerfectSlayer PerfectSlayer changed the title java-dogstatsd-client 4.3.0 Bump java-dogstatsd-client to 4.3.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
tag: dependencies Dependencies related changes
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcculls @dougqh