Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KStreams with dynamic queue names #6857

Merged
merged 2 commits into from Mar 29, 2024
Merged

Fix KStreams with dynamic queue names #6857

merged 2 commits into from Mar 29, 2024

Conversation

kr-igor
Copy link
Contributor

@kr-igor kr-igor commented Mar 29, 2024 •
edited

What Does This Do

This PR fixes a bug reported by KStreams users. See this ticket for context.

Details

STREAMING_CONTEXT relies on topology builder to get all source / sink / system topics. The issue with this approach is that some topics may not be part of the topology when it's created. An example may be .to( call which uses some logic to determine the downstream sink. In the example below RE_KEYED_BACKLOGS topic will not be added to the streaming context, since it's not resolved when topology builder is invoked. The solution is to allow DSM checkpoints for all topics which are not known at the start of the application.

builder
   .<Integer, String>stream(RESOLVED_BACKLOGS)
   .selectKey((key, val) -> key + 1)
   .to((key, value, ctx) -> {
       ctx.headers().add("NEW_HEADER", "VALUE".getBytes(StandardCharsets.UTF_8));
       return RE_KEYED_BACKLOGS;
   });

@kr-igor kr-igor marked this pull request as ready for review March 29, 2024 17:00
@kr-igor kr-igor requested a review from a team as a code owner March 29, 2024 17:00
@kr-igor kr-igor requested review from mcculls and am312 March 29, 2024 17:00
@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024 •
edited

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master kr-igor/fix-kstreams-context
git_commit_date 1711667418 1711730635
git_commit_sha 08d7b46 f8acfb7
See matching parameters
Baseline Candidate
ci_job_date 1711731741 1711731741
ci_job_id 473626301 473626301
ci_pipeline_id 31121763 31121763
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024 •
edited

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master kr-igor/fix-kstreams-context
git_commit_date 1711667418 1711730635
git_commit_sha 08d7b46 f8acfb7
See matching parameters
Baseline Candidate
ci_job_date 1711731785 1711731785
ci_job_id 473626302 473626302
ci_pipeline_id 31121763 31121763
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume unsure
[-12390.512op/s; -227.903op/s] or [-4.157%; -0.076%]
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume unsure
[+1433.568op/s; +14345.262op/s] or [+0.473%; +4.731%]
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master kr-igor/fix-kstreams-context
git_commit_date 1711667418 1711729858
git_commit_sha 08d7b46 3bf87d6
release_version 1.32.0-SNAPSHOT~08d7b46260 1.32.0-SNAPSHOT~3bf87d6401
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711733212 1711733212
ci_job_id 473606085 473606085
ci_pipeline_id 31121064 31121064
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~3bf87d6401, baseline=1.32.0-SNAPSHOT~08d7b46260

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076079
Total [baseline] (10.4 s) : 0, 10399503
Agent [candidate] (1.075 s) : 0, 1075473
Total [candidate] (10.415 s) : 0, 10415114
section appsec
Agent [baseline] (1.194 s) : 0, 1193866
Total [baseline] (10.552 s) : 0, 10551622
Agent [candidate] (1.196 s) : 0, 1195546
Total [candidate] (10.582 s) : 0, 10582341
section iast
Agent [baseline] (1.199 s) : 0, 1199302
Total [baseline] (10.733 s) : 0, 10732742
Agent [candidate] (1.197 s) : 0, 1197400
Total [candidate] (10.767 s) : 0, 10767434
section profiling
Agent [baseline] (1.267 s) : 0, 1266613
Total [baseline] (10.603 s) : 0, 10603041
Agent [candidate] (1.268 s) : 0, 1268098
Total [candidate] (10.68 s) : 0, 10680414
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.194 s 117.787 ms (10.9%)
Agent iast 1.199 s 123.223 ms (11.5%)
Agent profiling 1.267 s 190.534 ms (17.7%)
Total tracing 10.4 s -
Total appsec 10.552 s 152.119 ms (1.5%)
Total iast 10.733 s 333.239 ms (3.2%)
Total profiling 10.603 s 203.539 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.196 s 120.072 ms (11.2%)
Agent iast 1.197 s 121.927 ms (11.3%)
Agent profiling 1.268 s 192.625 ms (17.9%)
Total tracing 10.415 s -
Total appsec 10.582 s 167.227 ms (1.6%)
Total iast 10.767 s 352.32 ms (3.4%)
Total profiling 10.68 s 265.3 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~3bf87d6401, baseline=1.32.0-SNAPSHOT~08d7b46260

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.37 ms) : 0, 686370
BytebuddyAgent [candidate] (685.437 ms) : 0, 685437
GlobalTracer [baseline] (297.415 ms) : 0, 297415
GlobalTracer [candidate] (297.864 ms) : 0, 297864
AppSec [baseline] (49.536 ms) : 0, 49536
AppSec [candidate] (49.457 ms) : 0, 49457
Remote Config [baseline] (673.882 µs) : 0, 674
Remote Config [candidate] (674.223 µs) : 0, 674
Telemetry [baseline] (7.659 ms) : 0, 7659
Telemetry [candidate] (7.585 ms) : 0, 7585
section appsec
BytebuddyAgent [baseline] (693.382 ms) : 0, 693382
BytebuddyAgent [candidate] (694.226 ms) : 0, 694226
GlobalTracer [baseline] (290.558 ms) : 0, 290558
GlobalTracer [candidate] (291.248 ms) : 0, 291248
AppSec [baseline] (149.691 ms) : 0, 149691
AppSec [candidate] (149.83 ms) : 0, 149830
IAST [baseline] (18.666 ms) : 0, 18666
IAST [candidate] (18.642 ms) : 0, 18642
Remote Config [baseline] (602.165 µs) : 0, 602
Remote Config [candidate] (604.954 µs) : 0, 605
Telemetry [baseline] (6.755 ms) : 0, 6755
Telemetry [candidate] (6.734 ms) : 0, 6734
section iast
BytebuddyAgent [baseline] (794.558 ms) : 0, 794558
BytebuddyAgent [candidate] (793.05 ms) : 0, 793050
GlobalTracer [baseline] (288.481 ms) : 0, 288481
GlobalTracer [candidate] (288.201 ms) : 0, 288201
AppSec [baseline] (50.926 ms) : 0, 50926
AppSec [candidate] (48.824 ms) : 0, 48824
IAST [baseline] (22.124 ms) : 0, 22124
IAST [candidate] (25.215 ms) : 0, 25215
Remote Config [baseline] (576.349 µs) : 0, 576
Remote Config [candidate] (573.281 µs) : 0, 573
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (7.294 ms) : 0, 7294
section profiling
BytebuddyAgent [baseline] (676.868 ms) : 0, 676868
BytebuddyAgent [candidate] (677.047 ms) : 0, 677047
GlobalTracer [baseline] (379.97 ms) : 0, 379970
GlobalTracer [candidate] (380.651 ms) : 0, 380651
AppSec [baseline] (50.148 ms) : 0, 50148
AppSec [candidate] (50.081 ms) : 0, 50081
Remote Config [baseline] (704.914 µs) : 0, 705
Remote Config [candidate] (698.685 µs) : 0, 699
Telemetry [baseline] (7.444 ms) : 0, 7444
Telemetry [candidate] (7.496 ms) : 0, 7496
ProfilingAgent [baseline] (95.367 ms) : 0, 95367
ProfilingAgent [candidate] (95.864 ms) : 0, 95864
Profiling [baseline] (95.391 ms) : 0, 95391
Profiling [candidate] (95.888 ms) : 0, 95888
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~3bf87d6401, baseline=1.32.0-SNAPSHOT~08d7b46260

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075059
Total [baseline] (8.558 s) : 0, 8558168
Agent [candidate] (1.091 s) : 0, 1091132
Total [candidate] (8.598 s) : 0, 8597723
section iast
Agent [baseline] (1.205 s) : 0, 1205322
Total [baseline] (9.116 s) : 0, 9115642
Agent [candidate] (1.201 s) : 0, 1200607
Total [candidate] (9.079 s) : 0, 9078576
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.208 s) : 0, 1207900
Total [baseline] (9.058 s) : 0, 9058108
Agent [candidate] (1.2 s) : 0, 1200322
Total [candidate] (9.086 s) : 0, 9085814
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1193596
Total [baseline] (9.093 s) : 0, 9092676
Agent [candidate] (1.199 s) : 0, 1198704
Total [candidate] (9.12 s) : 0, 9119771
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.205 s 130.263 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 132.841 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.194 s 118.537 ms (11.0%)
Total tracing 8.558 s -
Total iast 9.116 s 557.473 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.058 s 499.94 ms (5.8%)
Total iast_TELEMETRY_OFF 9.093 s 534.507 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.201 s 109.474 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 109.19 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.199 s 107.572 ms (9.9%)
Total tracing 8.598 s -
Total iast 9.079 s 480.853 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.086 s 488.092 ms (5.7%)
Total iast_TELEMETRY_OFF 9.12 s 522.048 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~3bf87d6401, baseline=1.32.0-SNAPSHOT~08d7b46260

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.52 ms) : 0, 685520
BytebuddyAgent [candidate] (695.552 ms) : 0, 695552
GlobalTracer [baseline] (297.244 ms) : 0, 297244
GlobalTracer [candidate] (302.081 ms) : 0, 302081
AppSec [baseline] (49.664 ms) : 0, 49664
AppSec [candidate] (50.133 ms) : 0, 50133
Remote Config [baseline] (656.775 µs) : 0, 657
Remote Config [candidate] (676.23 µs) : 0, 676
Telemetry [baseline] (7.579 ms) : 0, 7579
Telemetry [candidate] (7.716 ms) : 0, 7716
section iast
BytebuddyAgent [baseline] (799.622 ms) : 0, 799622
BytebuddyAgent [candidate] (795.156 ms) : 0, 795156
GlobalTracer [baseline] (289.204 ms) : 0, 289204
GlobalTracer [candidate] (289.457 ms) : 0, 289457
AppSec [baseline] (48.888 ms) : 0, 48888
AppSec [candidate] (52.415 ms) : 0, 52415
IAST [baseline] (24.417 ms) : 0, 24417
IAST [candidate] (21.124 ms) : 0, 21124
Remote Config [baseline] (572.642 µs) : 0, 573
Remote Config [candidate] (573.532 µs) : 0, 574
Telemetry [baseline] (8.063 ms) : 0, 8063
Telemetry [candidate] (7.414 ms) : 0, 7414
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.356 ms) : 0, 800356
BytebuddyAgent [candidate] (794.487 ms) : 0, 794487
GlobalTracer [baseline] (290.546 ms) : 0, 290546
GlobalTracer [candidate] (289.477 ms) : 0, 289477
AppSec [baseline] (50.551 ms) : 0, 50551
AppSec [candidate] (49.529 ms) : 0, 49529
IAST [baseline] (24.468 ms) : 0, 24468
IAST [candidate] (23.616 ms) : 0, 23616
Remote Config [baseline] (592.828 µs) : 0, 593
Remote Config [candidate] (582.448 µs) : 0, 582
Telemetry [baseline] (6.601 ms) : 0, 6601
Telemetry [candidate] (8.099 ms) : 0, 8099
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.302 ms) : 0, 790302
BytebuddyAgent [candidate] (792.554 ms) : 0, 792554
GlobalTracer [baseline] (287.76 ms) : 0, 287760
GlobalTracer [candidate] (289.586 ms) : 0, 289586
AppSec [baseline] (48.83 ms) : 0, 48830
AppSec [candidate] (50.201 ms) : 0, 50201
IAST [baseline] (23.896 ms) : 0, 23896
IAST [candidate] (23.902 ms) : 0, 23902
Remote Config [baseline] (574.704 µs) : 0, 575
Remote Config [candidate] (608.622 µs) : 0, 609
Telemetry [baseline] (7.939 ms) : 0, 7939
Telemetry [candidate] (7.347 ms) : 0, 7347

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-03-29T16:59:01 2024-03-29T17:21:05
git_branch master kr-igor/fix-kstreams-context
git_commit_date 1711667418 1711729858
git_commit_sha 08d7b46 3bf87d6
release_version 1.32.0-SNAPSHOT~08d7b46260 1.32.0-SNAPSHOT~3bf87d6401
start_time 2024-03-29T16:58:48 2024-03-29T17:20:52
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711733212 1711733212
ci_job_id 473606085 473606085
ci_pipeline_id 31121064 31121064
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~3bf87d6401, baseline=1.32.0-SNAPSHOT~08d7b46260
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.734 ms) : 1711, 1758
.   : milestone, 1734,
appsec_no_iast (1.725 ms) : 1702, 1749
.   : milestone, 1725,
iast (1.496 ms) : 1474, 1519
.   : milestone, 1496,
profiling (1.54 ms) : 1515, 1565
.   : milestone, 1540,
tracing (1.471 ms) : 1448, 1494
.   : milestone, 1471,
section candidate
no_agent (1.348 ms) : 1328, 1368
.   : milestone, 1348,
appsec (1.738 ms) : 1713, 1763
.   : milestone, 1738,
appsec_no_iast (1.729 ms) : 1704, 1754
.   : milestone, 1729,
iast (1.507 ms) : 1483, 1531
.   : milestone, 1507,
profiling (1.525 ms) : 1500, 1550
.   : milestone, 1525,
tracing (1.473 ms) : 1448, 1497
.   : milestone, 1473,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.734 ms [1.711 ms, 1.758 ms] 383.99 µs (28.4%)
appsec_no_iast 1.725 ms [1.702 ms, 1.749 ms] 375.31 µs (27.8%)
iast 1.496 ms [1.474 ms, 1.519 ms] 146.324 µs (10.8%)
profiling 1.54 ms [1.515 ms, 1.565 ms] 190.168 µs (14.1%)
tracing 1.471 ms [1.448 ms, 1.494 ms] 121.102 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.368 ms] -
appsec 1.738 ms [1.713 ms, 1.763 ms] 389.809 µs (28.9%)
appsec_no_iast 1.729 ms [1.704 ms, 1.754 ms] 381.5 µs (28.3%)
iast 1.507 ms [1.483 ms, 1.531 ms] 159.238 µs (11.8%)
profiling 1.525 ms [1.5 ms, 1.55 ms] 176.897 µs (13.1%)
tracing 1.473 ms [1.448 ms, 1.497 ms] 124.727 µs (9.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~3bf87d6401, baseline=1.32.0-SNAPSHOT~08d7b46260
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.005 µs) : 355, 395
.   : milestone, 375,
iast (478.647 µs) : 458, 499
.   : milestone, 479,
iast_FULL (549.384 µs) : 529, 570
.   : milestone, 549,
iast_GLOBAL (508.887 µs) : 486, 532
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (479.388 µs) : 459, 500
.   : milestone, 479,
iast_INACTIVE (454.214 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (480.423 µs) : 460, 501
.   : milestone, 480,
tracing (449.26 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (380.948 µs) : 361, 401
.   : milestone, 381,
iast (485.707 µs) : 465, 506
.   : milestone, 486,
iast_FULL (545.585 µs) : 525, 566
.   : milestone, 546,
iast_GLOBAL (505.374 µs) : 485, 526
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (479.384 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (455.97 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (477.377 µs) : 456, 498
.   : milestone, 477,
tracing (455.397 µs) : 435, 476
.   : milestone, 455,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.005 µs [355.293 µs, 394.716 µs] -
iast 478.647 µs [457.981 µs, 499.312 µs] 103.642 µs (27.6%)
iast_FULL 549.384 µs [528.683 µs, 570.085 µs] 174.379 µs (46.5%)
iast_GLOBAL 508.887 µs [486.193 µs, 531.58 µs] 133.882 µs (35.7%)
iast_HARDCODED_SECRET_DISABLED 479.388 µs [458.796 µs, 499.98 µs] 104.383 µs (27.8%)
iast_INACTIVE 454.214 µs [433.109 µs, 475.319 µs] 79.209 µs (21.1%)
iast_TELEMETRY_OFF 480.423 µs [459.53 µs, 501.316 µs] 105.418 µs (28.1%)
tracing 449.26 µs [428.453 µs, 470.067 µs] 74.255 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.948 µs [361.27 µs, 400.625 µs] -
iast 485.707 µs [465.131 µs, 506.282 µs] 104.759 µs (27.5%)
iast_FULL 545.585 µs [524.863 µs, 566.307 µs] 164.637 µs (43.2%)
iast_GLOBAL 505.374 µs [484.887 µs, 525.862 µs] 124.427 µs (32.7%)
iast_HARDCODED_SECRET_DISABLED 479.384 µs [458.482 µs, 500.287 µs] 98.437 µs (25.8%)
iast_INACTIVE 455.97 µs [434.758 µs, 477.182 µs] 75.022 µs (19.7%)
iast_TELEMETRY_OFF 477.377 µs [456.33 µs, 498.424 µs] 96.43 µs (25.3%)
tracing 455.397 µs [434.624 µs, 476.17 µs] 74.449 µs (19.5%)

@kr-igor kr-igor merged commit ddd2f31 into master Mar 29, 2024
79 checks passed
@kr-igor kr-igor deleted the kr-igor/fix-kstreams-context branch March 29, 2024 19:20
@github-actions github-actions bot added this to the 1.32.0 milestone Mar 29, 2024
@PerfectSlayer PerfectSlayer changed the title [DSM] - Fix KStreams with dynamic queue names Fix KStreams with dynamic queue names Apr 4, 2024
@PerfectSlayer PerfectSlayer added type: bug comp: data streams Data Streams Monitoring labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am312 am312 am312 approved these changes

@piochelepiotr piochelepiotr piochelepiotr approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: data streams Data Streams Monitoring type: bug
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kr-igor @am312 @piochelepiotr @PerfectSlayer