Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update byte-buddy to 1.14.13 #6861

Merged
merged 1 commit into from Apr 2, 2024
Merged

Update byte-buddy to 1.14.13 #6861

merged 1 commit into from Apr 2, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Apr 1, 2024 •
edited

Changes of note since last upgrade (1.14.12)

  • Avoid resolving type variables when generic type processing is disabled.
  • Improve error message for Byte Buddy agent external attach.
  • Fix build for modular jars when using later version than Java 8.

There is a commit included in this release that affects IAST, it fixes this issue

@manuel-alvarez-alvarez manuel-alvarez-alvarez added the tag: dependencies Dependencies related changes label Apr 1, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner April 1, 2024 07:16
@pr-commenter
Copy link

pr-commenter bot commented Apr 1, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/byte-buddy-1.14.13
git_commit_date 1711742224 1711955577
git_commit_sha e49f1a1 ee09703
release_version 1.32.0-SNAPSHOT~e49f1a1efb 1.32.0-SNAPSHOT~ee09703d77
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711958986 1711958986
ci_job_id 474141003 474141003
ci_pipeline_id 31163927 31163927
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~ee09703d77, baseline=1.32.0-SNAPSHOT~e49f1a1efb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074323
Total [baseline] (8.558 s) : 0, 8557849
Agent [candidate] (1.085 s) : 0, 1084826
Total [candidate] (8.583 s) : 0, 8583037
section iast
Agent [baseline] (1.197 s) : 0, 1196638
Total [baseline] (9.038 s) : 0, 9038340
Agent [candidate] (1.198 s) : 0, 1197952
Total [candidate] (9.068 s) : 0, 9067709
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1197501
Total [baseline] (9.036 s) : 0, 9035700
Agent [candidate] (1.198 s) : 0, 1198265
Total [candidate] (9.022 s) : 0, 9022013
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1193372
Total [baseline] (9.09 s) : 0, 9089615
Agent [candidate] (1.205 s) : 0, 1205302
Total [candidate] (9.093 s) : 0, 9092858
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.197 s 122.315 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 123.178 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.193 s 119.049 ms (11.1%)
Total tracing 8.558 s -
Total iast 9.038 s 480.491 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.036 s 477.851 ms (5.6%)
Total iast_TELEMETRY_OFF 9.09 s 531.765 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.198 s 113.126 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 113.44 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.205 s 120.477 ms (11.1%)
Total tracing 8.583 s -
Total iast 9.068 s 484.672 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.022 s 438.976 ms (5.1%)
Total iast_TELEMETRY_OFF 9.093 s 509.821 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~ee09703d77, baseline=1.32.0-SNAPSHOT~e49f1a1efb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.257 ms) : 0, 672257
BytebuddyAgent [candidate] (678.951 ms) : 0, 678951
GlobalTracer [baseline] (309.353 ms) : 0, 309353
GlobalTracer [candidate] (312.788 ms) : 0, 312788
AppSec [baseline] (49.876 ms) : 0, 49876
AppSec [candidate] (49.96 ms) : 0, 49960
Remote Config [baseline] (666.807 µs) : 0, 667
Remote Config [candidate] (674.806 µs) : 0, 675
Telemetry [baseline] (7.655 ms) : 0, 7655
Telemetry [candidate] (7.694 ms) : 0, 7694
section iast
BytebuddyAgent [baseline] (793.586 ms) : 0, 793586
BytebuddyAgent [candidate] (793.19 ms) : 0, 793190
GlobalTracer [baseline] (287.772 ms) : 0, 287772
GlobalTracer [candidate] (288.183 ms) : 0, 288183
AppSec [baseline] (50.933 ms) : 0, 50933
AppSec [candidate] (51.303 ms) : 0, 51303
IAST [baseline] (21.981 ms) : 0, 21981
IAST [candidate] (23.007 ms) : 0, 23007
Remote Config [baseline] (566.388 µs) : 0, 566
Remote Config [candidate] (595.142 µs) : 0, 595
Telemetry [baseline] (7.379 ms) : 0, 7379
Telemetry [candidate] (7.332 ms) : 0, 7332
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.208 ms) : 0, 793208
BytebuddyAgent [candidate] (793.455 ms) : 0, 793455
GlobalTracer [baseline] (287.977 ms) : 0, 287977
GlobalTracer [candidate] (288.683 ms) : 0, 288683
AppSec [baseline] (49.514 ms) : 0, 49514
AppSec [candidate] (50.312 ms) : 0, 50312
IAST [baseline] (22.938 ms) : 0, 22938
IAST [candidate] (21.886 ms) : 0, 21886
Remote Config [baseline] (566.367 µs) : 0, 566
Remote Config [candidate] (572.141 µs) : 0, 572
Telemetry [baseline] (8.788 ms) : 0, 8788
Telemetry [candidate] (8.86 ms) : 0, 8860
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.121 ms) : 0, 790121
BytebuddyAgent [candidate] (797.728 ms) : 0, 797728
GlobalTracer [baseline] (287.753 ms) : 0, 287753
GlobalTracer [candidate] (290.787 ms) : 0, 290787
AppSec [baseline] (47.857 ms) : 0, 47857
AppSec [candidate] (49.187 ms) : 0, 49187
IAST [baseline] (25.503 ms) : 0, 25503
IAST [candidate] (23.527 ms) : 0, 23527
Remote Config [baseline] (577.181 µs) : 0, 577
Remote Config [candidate] (592.34 µs) : 0, 592
Telemetry [baseline] (7.267 ms) : 0, 7267
Telemetry [candidate] (8.813 ms) : 0, 8813
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~ee09703d77, baseline=1.32.0-SNAPSHOT~e49f1a1efb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073688
Total [baseline] (10.392 s) : 0, 10392468
Agent [candidate] (1.076 s) : 0, 1075690
Total [candidate] (10.444 s) : 0, 10444395
section appsec
Agent [baseline] (1.196 s) : 0, 1196267
Total [baseline] (10.579 s) : 0, 10578649
Agent [candidate] (1.194 s) : 0, 1193677
Total [candidate] (10.521 s) : 0, 10520610
section iast
Agent [baseline] (1.202 s) : 0, 1201621
Total [baseline] (10.751 s) : 0, 10751327
Agent [candidate] (1.197 s) : 0, 1196817
Total [candidate] (10.776 s) : 0, 10775592
section profiling
Agent [baseline] (1.265 s) : 0, 1264668
Total [baseline] (10.61 s) : 0, 10609707
Agent [candidate] (1.271 s) : 0, 1271226
Total [candidate] (10.607 s) : 0, 10606569
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.196 s 122.578 ms (11.4%)
Agent iast 1.202 s 127.933 ms (11.9%)
Agent profiling 1.265 s 190.98 ms (17.8%)
Total tracing 10.392 s -
Total appsec 10.579 s 186.181 ms (1.8%)
Total iast 10.751 s 358.858 ms (3.5%)
Total profiling 10.61 s 217.239 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.194 s 117.987 ms (11.0%)
Agent iast 1.197 s 121.127 ms (11.3%)
Agent profiling 1.271 s 195.536 ms (18.2%)
Total tracing 10.444 s -
Total appsec 10.521 s 76.214 ms (0.7%)
Total iast 10.776 s 331.197 ms (3.2%)
Total profiling 10.607 s 162.174 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~ee09703d77, baseline=1.32.0-SNAPSHOT~e49f1a1efb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.825 ms) : 0, 671825
BytebuddyAgent [candidate] (672.774 ms) : 0, 672774
GlobalTracer [baseline] (309.32 ms) : 0, 309320
GlobalTracer [candidate] (310.566 ms) : 0, 310566
AppSec [baseline] (49.776 ms) : 0, 49776
AppSec [candidate] (49.759 ms) : 0, 49759
Remote Config [baseline] (663.859 µs) : 0, 664
Remote Config [candidate] (661.647 µs) : 0, 662
Telemetry [baseline] (7.654 ms) : 0, 7654
Telemetry [candidate] (7.577 ms) : 0, 7577
section appsec
BytebuddyAgent [baseline] (694.931 ms) : 0, 694931
BytebuddyAgent [candidate] (693.057 ms) : 0, 693057
GlobalTracer [baseline] (291.105 ms) : 0, 291105
GlobalTracer [candidate] (290.71 ms) : 0, 290710
AppSec [baseline] (149.616 ms) : 0, 149616
AppSec [candidate] (149.446 ms) : 0, 149446
IAST [baseline] (18.762 ms) : 0, 18762
IAST [candidate] (18.797 ms) : 0, 18797
Remote Config [baseline] (603.244 µs) : 0, 603
Remote Config [candidate] (598.765 µs) : 0, 599
Telemetry [baseline] (6.793 ms) : 0, 6793
Telemetry [candidate] (6.762 ms) : 0, 6762
section iast
BytebuddyAgent [baseline] (798.461 ms) : 0, 798461
BytebuddyAgent [candidate] (792.181 ms) : 0, 792181
GlobalTracer [baseline] (287.767 ms) : 0, 287767
GlobalTracer [candidate] (288.263 ms) : 0, 288263
AppSec [baseline] (48.4 ms) : 0, 48400
AppSec [candidate] (49.457 ms) : 0, 49457
IAST [baseline] (24.539 ms) : 0, 24539
IAST [candidate] (23.761 ms) : 0, 23761
Remote Config [baseline] (578.679 µs) : 0, 579
Remote Config [candidate] (584.17 µs) : 0, 584
Telemetry [baseline] (7.389 ms) : 0, 7389
Telemetry [candidate] (8.228 ms) : 0, 8228
section profiling
BytebuddyAgent [baseline] (676.048 ms) : 0, 676048
BytebuddyAgent [candidate] (678.688 ms) : 0, 678688
GlobalTracer [baseline] (379.491 ms) : 0, 379491
GlobalTracer [candidate] (381.636 ms) : 0, 381636
AppSec [baseline] (49.805 ms) : 0, 49805
AppSec [candidate] (50.302 ms) : 0, 50302
Remote Config [baseline] (690.453 µs) : 0, 690
Remote Config [candidate] (726.058 µs) : 0, 726
Telemetry [baseline] (7.43 ms) : 0, 7430
Telemetry [candidate] (7.541 ms) : 0, 7541
ProfilingAgent [baseline] (95.082 ms) : 0, 95082
ProfilingAgent [candidate] (96.045 ms) : 0, 96045
Profiling [baseline] (95.107 ms) : 0, 95107
Profiling [candidate] (96.069 ms) : 0, 96069

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-01T07:42:07 2024-04-01T08:04:04
git_branch master malvarez/byte-buddy-1.14.13
git_commit_date 1711742224 1711955577
git_commit_sha e49f1a1 ee09703
release_version 1.32.0-SNAPSHOT~e49f1a1efb 1.32.0-SNAPSHOT~ee09703d77
start_time 2024-04-01T07:41:54 2024-04-01T08:03:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1711958986 1711958986
ci_job_id 474141003 474141003
ci_pipeline_id 31163927 31163927
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~ee09703d77, baseline=1.32.0-SNAPSHOT~e49f1a1efb
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.714 µs) : 350, 389
.   : milestone, 370,
iast (469.82 µs) : 449, 490
.   : milestone, 470,
iast_FULL (549.54 µs) : 529, 570
.   : milestone, 550,
iast_GLOBAL (484.695 µs) : 464, 505
.   : milestone, 485,
iast_HARDCODED_SECRET_DISABLED (466.014 µs) : 445, 487
.   : milestone, 466,
iast_INACTIVE (438.408 µs) : 418, 459
.   : milestone, 438,
iast_TELEMETRY_OFF (462.318 µs) : 442, 483
.   : milestone, 462,
tracing (435.143 µs) : 414, 456
.   : milestone, 435,
section candidate
no_agent (360.499 µs) : 341, 380
.   : milestone, 360,
iast (469.435 µs) : 449, 490
.   : milestone, 469,
iast_FULL (535.438 µs) : 515, 556
.   : milestone, 535,
iast_GLOBAL (481.782 µs) : 461, 503
.   : milestone, 482,
iast_HARDCODED_SECRET_DISABLED (465.7 µs) : 445, 486
.   : milestone, 466,
iast_INACTIVE (446.232 µs) : 424, 468
.   : milestone, 446,
iast_TELEMETRY_OFF (467.243 µs) : 446, 488
.   : milestone, 467,
tracing (443.945 µs) : 422, 466
.   : milestone, 444,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.714 µs [349.994 µs, 389.434 µs] -
iast 469.82 µs [449.265 µs, 490.376 µs] 100.106 µs (27.1%)
iast_FULL 549.54 µs [528.811 µs, 570.27 µs] 179.826 µs (48.6%)
iast_GLOBAL 484.695 µs [464.25 µs, 505.14 µs] 114.981 µs (31.1%)
iast_HARDCODED_SECRET_DISABLED 466.014 µs [445.407 µs, 486.62 µs] 96.3 µs (26.0%)
iast_INACTIVE 438.408 µs [418.176 µs, 458.64 µs] 68.694 µs (18.6%)
iast_TELEMETRY_OFF 462.318 µs [442.132 µs, 482.504 µs] 92.604 µs (25.0%)
tracing 435.143 µs [414.428 µs, 455.857 µs] 65.429 µs (17.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.499 µs [340.523 µs, 380.475 µs] -
iast 469.435 µs [448.729 µs, 490.14 µs] 108.936 µs (30.2%)
iast_FULL 535.438 µs [514.842 µs, 556.034 µs] 174.939 µs (48.5%)
iast_GLOBAL 481.782 µs [460.986 µs, 502.579 µs] 121.283 µs (33.6%)
iast_HARDCODED_SECRET_DISABLED 465.7 µs [444.983 µs, 486.417 µs] 105.201 µs (29.2%)
iast_INACTIVE 446.232 µs [424.478 µs, 467.986 µs] 85.733 µs (23.8%)
iast_TELEMETRY_OFF 467.243 µs [446.434 µs, 488.051 µs] 106.744 µs (29.6%)
tracing 443.945 µs [422.369 µs, 465.521 µs] 83.446 µs (23.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~ee09703d77, baseline=1.32.0-SNAPSHOT~e49f1a1efb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.333 ms) : 1313, 1352
.   : milestone, 1333,
appsec (1.694 ms) : 1669, 1720
.   : milestone, 1694,
appsec_no_iast (1.721 ms) : 1697, 1745
.   : milestone, 1721,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.486 ms) : 1462, 1510
.   : milestone, 1486,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
section candidate
no_agent (1.339 ms) : 1320, 1359
.   : milestone, 1339,
appsec (1.707 ms) : 1683, 1732
.   : milestone, 1707,
appsec_no_iast (1.703 ms) : 1678, 1728
.   : milestone, 1703,
iast (1.5 ms) : 1477, 1524
.   : milestone, 1500,
profiling (1.473 ms) : 1449, 1497
.   : milestone, 1473,
tracing (1.469 ms) : 1445, 1494
.   : milestone, 1469,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.313 ms, 1.352 ms] -
appsec 1.694 ms [1.669 ms, 1.72 ms] 361.946 µs (27.2%)
appsec_no_iast 1.721 ms [1.697 ms, 1.745 ms] 388.315 µs (29.1%)
iast 1.478 ms [1.455 ms, 1.501 ms] 145.599 µs (10.9%)
profiling 1.486 ms [1.462 ms, 1.51 ms] 153.584 µs (11.5%)
tracing 1.473 ms [1.448 ms, 1.498 ms] 140.438 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.359 ms] -
appsec 1.707 ms [1.683 ms, 1.732 ms] 368.103 µs (27.5%)
appsec_no_iast 1.703 ms [1.678 ms, 1.728 ms] 364.074 µs (27.2%)
iast 1.5 ms [1.477 ms, 1.524 ms] 161.017 µs (12.0%)
profiling 1.473 ms [1.449 ms, 1.497 ms] 134.086 µs (10.0%)
tracing 1.469 ms [1.445 ms, 1.494 ms] 129.931 µs (9.7%)

@mcculls mcculls merged commit 387464f into master Apr 2, 2024
79 checks passed
@mcculls mcculls deleted the malvarez/byte-buddy-1.14.13 branch April 2, 2024 23:28
@github-actions github-actions bot added this to the 1.32.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
tag: dependencies Dependencies related changes
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuel-alvarez-alvarez @mcculls