Bump JMXFetch to 0.49.2 #6935

carlosroman · 2024-04-23T10:20:21Z

What Does This Do

Motivation

Bumps JMXFetch to 0.49.2 as it adds ZGC Major and Minor Cycles and ZGC Major and Minor Pauses beans support out of the box (Generational ZGC support).

Additional Notes

Changes since last update:

mcculls

There are still some failing JMXFetch tests that need fixing before this can be merged

pr-commenter · 2024-05-29T23:05:45Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	carlosroman/AMLII-1643-bump-jmxfetch
git_commit_date	1717774928	1717780037
git_commit_sha	`bff441b`	`40d4473`
release_version	1.36.0-SNAPSHOT~bff441bbdf	1.36.0-SNAPSHOT~40d4473e0c

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1717783144	1717783144
ci_job_id	536382883	536382883
ci_pipeline_id	36184294	36184294
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060592
Total [baseline] (10.434 s) : 0, 10433666
Agent [candidate] (1.066 s) : 0, 1066374
Total [candidate] (10.368 s) : 0, 10368026
section appsec
Agent [baseline] (1.181 s) : 0, 1180751
Total [baseline] (10.469 s) : 0, 10468598
Agent [candidate] (1.191 s) : 0, 1190832
Total [candidate] (10.52 s) : 0, 10519632
section iast
Agent [baseline] (1.169 s) : 0, 1169064
Total [baseline] (10.79 s) : 0, 10789753
Agent [candidate] (1.168 s) : 0, 1168175
Total [candidate] (10.717 s) : 0, 10716731
section profiling
Agent [baseline] (1.276 s) : 0, 1276145
Total [baseline] (10.61 s) : 0, 10610107
Agent [candidate] (1.26 s) : 0, 1260265
Total [candidate] (10.621 s) : 0, 10621069

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.181 s	120.159 ms (11.3%)
Agent	iast	1.169 s	108.472 ms (10.2%)
Agent	profiling	1.276 s	215.553 ms (20.3%)
Total	tracing	10.434 s	-
Total	appsec	10.469 s	34.931 ms (0.3%)
Total	iast	10.79 s	356.087 ms (3.4%)
Total	profiling	10.61 s	176.441 ms (1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	appsec	1.191 s	124.458 ms (11.7%)
Agent	iast	1.168 s	101.802 ms (9.5%)
Agent	profiling	1.26 s	193.891 ms (18.2%)
Total	tracing	10.368 s	-
Total	appsec	10.52 s	151.606 ms (1.5%)
Total	iast	10.717 s	348.705 ms (3.4%)
Total	profiling	10.621 s	253.042 ms (2.4%)

gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.251 ms) : 0, 664251
BytebuddyAgent [candidate] (668.064 ms) : 0, 668064
GlobalTracer [baseline] (303.478 ms) : 0, 303478
GlobalTracer [candidate] (305.01 ms) : 0, 305010
AppSec [baseline] (49.912 ms) : 0, 49912
AppSec [candidate] (50.186 ms) : 0, 50186
Logs Intake [baseline] (412.323 µs) : 0, 412
Logs Intake [candidate] (393.05 µs) : 0, 393
Remote Config [baseline] (659.667 µs) : 0, 660
Remote Config [candidate] (673.213 µs) : 0, 673
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.589 ms) : 0, 7589
section appsec
BytebuddyAgent [baseline] (676.311 ms) : 0, 676311
BytebuddyAgent [candidate] (683.559 ms) : 0, 683559
GlobalTracer [baseline] (297.251 ms) : 0, 297251
GlobalTracer [candidate] (300.195 ms) : 0, 300195
AppSec [baseline] (152.727 ms) : 0, 152727
AppSec [candidate] (153.645 ms) : 0, 153645
IAST [baseline] (21.866 ms) : 0, 21866
IAST [candidate] (20.24 ms) : 0, 20240
Logs Intake [baseline] (328.404 µs) : 0, 328
Logs Intake [candidate] (334.297 µs) : 0, 334
Remote Config [baseline] (645.43 µs) : 0, 645
Remote Config [candidate] (629.761 µs) : 0, 630
Telemetry [baseline] (8.178 ms) : 0, 8178
Telemetry [candidate] (7.596 ms) : 0, 7596
section iast
BytebuddyAgent [baseline] (780.07 ms) : 0, 780070
BytebuddyAgent [candidate] (779.855 ms) : 0, 779855
GlobalTracer [baseline] (293.616 ms) : 0, 293616
GlobalTracer [candidate] (293.741 ms) : 0, 293741
AppSec [baseline] (46.929 ms) : 0, 46929
AppSec [candidate] (47.17 ms) : 0, 47170
IAST [baseline] (25.046 ms) : 0, 25046
IAST [candidate] (25.478 ms) : 0, 25478
Logs Intake [baseline] (303.429 µs) : 0, 303
Logs Intake [candidate] (299.358 µs) : 0, 299
Remote Config [baseline] (593.058 µs) : 0, 593
Remote Config [candidate] (577.917 µs) : 0, 578
Telemetry [baseline] (9.243 ms) : 0, 9243
Telemetry [candidate] (7.822 ms) : 0, 7822
section profiling
BytebuddyAgent [baseline] (670.687 ms) : 0, 670687
BytebuddyAgent [candidate] (662.818 ms) : 0, 662818
GlobalTracer [baseline] (390.008 ms) : 0, 390008
GlobalTracer [candidate] (386.049 ms) : 0, 386049
AppSec [baseline] (51.469 ms) : 0, 51469
AppSec [candidate] (50.895 ms) : 0, 50895
Logs Intake [baseline] (346.591 µs) : 0, 347
Logs Intake [candidate] (325.103 µs) : 0, 325
Remote Config [baseline] (750.381 µs) : 0, 750
Remote Config [candidate] (757.487 µs) : 0, 757
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.332 ms) : 0, 7332
ProfilingAgent [baseline] (98.035 ms) : 0, 98035
ProfilingAgent [candidate] (95.436 ms) : 0, 95436
Profiling [baseline] (98.059 ms) : 0, 98059
Profiling [candidate] (95.46 ms) : 0, 95460

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070004
Total [baseline] (8.539 s) : 0, 8539475
Agent [candidate] (1.061 s) : 0, 1060835
Total [candidate] (8.539 s) : 0, 8538695
section iast
Agent [baseline] (1.175 s) : 0, 1175463
Total [baseline] (9.004 s) : 0, 9003807
Agent [candidate] (1.177 s) : 0, 1176732
Total [candidate] (8.987 s) : 0, 8987262
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179044
Total [baseline] (8.966 s) : 0, 8966041
Agent [candidate] (1.169 s) : 0, 1169417
Total [candidate] (8.974 s) : 0, 8974086
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1164960
Total [baseline] (8.995 s) : 0, 8995284
Agent [candidate] (1.172 s) : 0, 1171905
Total [candidate] (8.973 s) : 0, 8973381

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.07 s	-
Agent	iast	1.175 s	105.459 ms (9.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	109.04 ms (10.2%)
Agent	iast_TELEMETRY_OFF	1.165 s	94.957 ms (8.9%)
Total	tracing	8.539 s	-
Total	iast	9.004 s	464.332 ms (5.4%)
Total	iast_HARDCODED_SECRET_DISABLED	8.966 s	426.567 ms (5.0%)
Total	iast_TELEMETRY_OFF	8.995 s	455.809 ms (5.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	iast	1.177 s	115.897 ms (10.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.169 s	108.583 ms (10.2%)
Agent	iast_TELEMETRY_OFF	1.172 s	111.07 ms (10.5%)
Total	tracing	8.539 s	-
Total	iast	8.987 s	448.567 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.974 s	435.391 ms (5.1%)
Total	iast_TELEMETRY_OFF	8.973 s	434.686 ms (5.1%)

gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.499 ms) : 0, 670499
BytebuddyAgent [candidate] (664.134 ms) : 0, 664134
GlobalTracer [baseline] (305.598 ms) : 0, 305598
GlobalTracer [candidate] (303.775 ms) : 0, 303775
AppSec [baseline] (50.446 ms) : 0, 50446
AppSec [candidate] (49.972 ms) : 0, 49972
Logs Intake [baseline] (393.387 µs) : 0, 393
Logs Intake [candidate] (417.758 µs) : 0, 418
Remote Config [baseline] (700.35 µs) : 0, 700
Remote Config [candidate] (670.221 µs) : 0, 670
Telemetry [baseline] (7.699 ms) : 0, 7699
Telemetry [candidate] (7.512 ms) : 0, 7512
section iast
BytebuddyAgent [baseline] (784.674 ms) : 0, 784674
BytebuddyAgent [candidate] (784.113 ms) : 0, 784113
GlobalTracer [baseline] (294.793 ms) : 0, 294793
GlobalTracer [candidate] (295.292 ms) : 0, 295292
AppSec [baseline] (47.425 ms) : 0, 47425
AppSec [candidate] (47.362 ms) : 0, 47362
IAST [baseline] (25.688 ms) : 0, 25688
IAST [candidate] (25.694 ms) : 0, 25694
Logs Intake [baseline] (301.364 µs) : 0, 301
Logs Intake [candidate] (299.811 µs) : 0, 300
Remote Config [baseline] (590.1 µs) : 0, 590
Remote Config [candidate] (601.382 µs) : 0, 601
Telemetry [baseline] (8.595 ms) : 0, 8595
Telemetry [candidate] (10.002 ms) : 0, 10002
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.147 ms) : 0, 786147
BytebuddyAgent [candidate] (779.072 ms) : 0, 779072
GlobalTracer [baseline] (296.449 ms) : 0, 296449
GlobalTracer [candidate] (294.124 ms) : 0, 294124
AppSec [baseline] (46.791 ms) : 0, 46791
AppSec [candidate] (46.47 ms) : 0, 46470
IAST [baseline] (27.784 ms) : 0, 27784
IAST [candidate] (27.85 ms) : 0, 27850
Logs Intake [baseline] (303.282 µs) : 0, 303
Logs Intake [candidate] (302.605 µs) : 0, 303
Remote Config [baseline] (575.693 µs) : 0, 576
Remote Config [candidate] (568.734 µs) : 0, 569
Telemetry [baseline] (7.568 ms) : 0, 7568
Telemetry [candidate] (7.688 ms) : 0, 7688
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.237 ms) : 0, 777237
BytebuddyAgent [candidate] (781.769 ms) : 0, 781769
GlobalTracer [baseline] (293.357 ms) : 0, 293357
GlobalTracer [candidate] (295.647 ms) : 0, 295647
AppSec [baseline] (48.541 ms) : 0, 48541
AppSec [candidate] (48.275 ms) : 0, 48275
IAST [baseline] (23.292 ms) : 0, 23292
IAST [candidate] (23.598 ms) : 0, 23598
Logs Intake [baseline] (299.543 µs) : 0, 300
Logs Intake [candidate] (302.102 µs) : 0, 302
Remote Config [baseline] (555.446 µs) : 0, 555
Remote Config [candidate] (566.299 µs) : 0, 566
Telemetry [baseline] (8.333 ms) : 0, 8333
Telemetry [candidate] (8.359 ms) : 0, 8359

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-07T17:30:16	2024-06-07T17:37:04
git_branch	master	carlosroman/AMLII-1643-bump-jmxfetch
git_commit_date	1717774928	1717780037
git_commit_sha	`bff441b`	`40d4473`
release_version	1.36.0-SNAPSHOT~bff441bbdf	1.36.0-SNAPSHOT~40d4473e0c
start_time	2024-06-07T17:30:02	2024-06-07T17:36:51

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1717782168	1717782168
ci_job_id	536382885	536382885
ci_pipeline_id	36184294	36184294
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.708 µs) : 347, 386
.   : milestone, 367,
iast (480.305 µs) : 459, 502
.   : milestone, 480,
iast_FULL (542.821 µs) : 522, 564
.   : milestone, 543,
iast_GLOBAL (498.489 µs) : 478, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (478.409 µs) : 457, 500
.   : milestone, 478,
iast_INACTIVE (461.488 µs) : 440, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (467.516 µs) : 446, 489
.   : milestone, 468,
tracing (435.123 µs) : 414, 456
.   : milestone, 435,
section candidate
no_agent (365.942 µs) : 345, 387
.   : milestone, 366,
iast (477.139 µs) : 456, 498
.   : milestone, 477,
iast_FULL (543.414 µs) : 522, 565
.   : milestone, 543,
iast_GLOBAL (503.19 µs) : 481, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (479.203 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (453.1 µs) : 431, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (461.504 µs) : 441, 482
.   : milestone, 462,
tracing (437.419 µs) : 417, 458
.   : milestone, 437,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	366.708 µs [347.128 µs, 386.287 µs]	-
iast	480.305 µs [458.868 µs, 501.743 µs]	113.598 µs (31.0%)
iast_FULL	542.821 µs [521.741 µs, 563.9 µs]	176.113 µs (48.0%)
iast_GLOBAL	498.489 µs [477.551 µs, 519.426 µs]	131.781 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED	478.409 µs [457.188 µs, 499.63 µs]	111.702 µs (30.5%)
iast_INACTIVE	461.488 µs [440.32 µs, 482.655 µs]	94.78 µs (25.8%)
iast_TELEMETRY_OFF	467.516 µs [445.799 µs, 489.232 µs]	100.808 µs (27.5%)
tracing	435.123 µs [414.151 µs, 456.095 µs]	68.415 µs (18.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.942 µs [345.084 µs, 386.799 µs]	-
iast	477.139 µs [456.179 µs, 498.1 µs]	111.198 µs (30.4%)
iast_FULL	543.414 µs [522.033 µs, 564.795 µs]	177.472 µs (48.5%)
iast_GLOBAL	503.19 µs [481.112 µs, 525.268 µs]	137.248 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED	479.203 µs [458.087 µs, 500.32 µs]	113.261 µs (31.0%)
iast_INACTIVE	453.1 µs [430.902 µs, 475.299 µs]	87.159 µs (23.8%)
iast_TELEMETRY_OFF	461.504 µs [440.706 µs, 482.302 µs]	95.562 µs (26.1%)
tracing	437.419 µs [416.973 µs, 457.865 µs]	71.477 µs (19.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.702 ms) : 1678, 1726
.   : milestone, 1702,
appsec_no_iast (1.726 ms) : 1701, 1750
.   : milestone, 1726,
iast (1.478 ms) : 1455, 1500
.   : milestone, 1478,
profiling (1.527 ms) : 1495, 1559
.   : milestone, 1527,
tracing (1.449 ms) : 1426, 1473
.   : milestone, 1449,
section candidate
no_agent (1.355 ms) : 1335, 1376
.   : milestone, 1355,
appsec (1.717 ms) : 1692, 1742
.   : milestone, 1717,
appsec_no_iast (1.709 ms) : 1684, 1733
.   : milestone, 1709,
iast (1.465 ms) : 1443, 1487
.   : milestone, 1465,
profiling (1.488 ms) : 1463, 1513
.   : milestone, 1488,
tracing (1.474 ms) : 1450, 1498
.   : milestone, 1474,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.337 ms, 1.375 ms]	-
appsec	1.702 ms [1.678 ms, 1.726 ms]	346.217 µs (25.5%)
appsec_no_iast	1.726 ms [1.701 ms, 1.75 ms]	369.713 µs (27.3%)
iast	1.478 ms [1.455 ms, 1.5 ms]	121.707 µs (9.0%)
profiling	1.527 ms [1.495 ms, 1.559 ms]	170.876 µs (12.6%)
tracing	1.449 ms [1.426 ms, 1.473 ms]	93.667 µs (6.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.376 ms]	-
appsec	1.717 ms [1.692 ms, 1.742 ms]	361.546 µs (26.7%)
appsec_no_iast	1.709 ms [1.684 ms, 1.733 ms]	353.309 µs (26.1%)
iast	1.465 ms [1.443 ms, 1.487 ms]	109.777 µs (8.1%)
profiling	1.488 ms [1.463 ms, 1.513 ms]	132.329 µs (9.8%)
tracing	1.474 ms [1.45 ms, 1.498 ms]	118.673 µs (8.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	carlosroman/AMLII-1643-bump-jmxfetch
git_commit_date	1717774928	1717780037
git_commit_sha	`bff441b`	`40d4473`
release_version	1.36.0-SNAPSHOT~bff441bbdf	1.36.0-SNAPSHOT~40d4473e0c

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1717782698	1717782698
ci_job_id	536382887	536382887
ci_pipeline_id	36184294	36184294
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1470
.   : milestone, 1459,
appsec (2.191 ms) : 2158, 2225
.   : milestone, 2191,
iast (1.961 ms) : 1920, 2002
.   : milestone, 1961,
iast_GLOBAL (2.004 ms) : 1962, 2045
.   : milestone, 2004,
profiling (1.842 ms) : 1808, 1876
.   : milestone, 1842,
tracing (1.833 ms) : 1801, 1865
.   : milestone, 1833,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.194 ms) : 2161, 2228
.   : milestone, 2194,
iast (1.959 ms) : 1919, 2000
.   : milestone, 1959,
iast_GLOBAL (2.0 ms) : 1959, 2041
.   : milestone, 2000,
profiling (1.857 ms) : 1824, 1890
.   : milestone, 1857,
tracing (1.836 ms) : 1803, 1868
.   : milestone, 1836,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.459 ms [1.448 ms, 1.47 ms]	-
appsec	2.191 ms [2.158 ms, 2.225 ms]	732.258 µs (50.2%)
iast	1.961 ms [1.92 ms, 2.002 ms]	502.182 µs (34.4%)
iast_GLOBAL	2.004 ms [1.962 ms, 2.045 ms]	544.795 µs (37.3%)
profiling	1.842 ms [1.808 ms, 1.876 ms]	383.181 µs (26.3%)
tracing	1.833 ms [1.801 ms, 1.865 ms]	374.084 µs (25.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.462 ms [1.451 ms, 1.474 ms]	-
appsec	2.194 ms [2.161 ms, 2.228 ms]	732.008 µs (50.1%)
iast	1.959 ms [1.919 ms, 2.0 ms]	497.236 µs (34.0%)
iast_GLOBAL	2.0 ms [1.959 ms, 2.041 ms]	537.56 µs (36.8%)
profiling	1.857 ms [1.824 ms, 1.89 ms]	394.924 µs (27.0%)
tracing	1.836 ms [1.803 ms, 1.868 ms]	373.597 µs (25.5%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~40d4473e0c, baseline=1.36.0-SNAPSHOT~bff441bbdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
appsec (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,
iast (19.137 s) : 19137000, 19137000
.   : milestone, 19137000,
iast_GLOBAL (17.79 s) : 17790000, 17790000
.   : milestone, 17790000,
profiling (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
tracing (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
section candidate
no_agent (15.463 s) : 15463000, 15463000
.   : milestone, 15463000,
appsec (15.25 s) : 15250000, 15250000
.   : milestone, 15250000,
iast (19.008 s) : 19008000, 19008000
.   : milestone, 19008000,
iast_GLOBAL (17.951 s) : 17951000, 17951000
.   : milestone, 17951000,
profiling (14.908 s) : 14908000, 14908000
.   : milestone, 14908000,
tracing (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.999 s [14.999 s, 14.999 s]	-
appsec	15.054 s [15.054 s, 15.054 s]	55.0 ms (0.4%)
iast	19.137 s [19.137 s, 19.137 s]	4.138 s (27.6%)
iast_GLOBAL	17.79 s [17.79 s, 17.79 s]	2.791 s (18.6%)
profiling	14.988 s [14.988 s, 14.988 s]	-11.0 ms (-0.1%)
tracing	15.178 s [15.178 s, 15.178 s]	179.0 ms (1.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.463 s [15.463 s, 15.463 s]	-
appsec	15.25 s [15.25 s, 15.25 s]	-213.0 ms (-1.4%)
iast	19.008 s [19.008 s, 19.008 s]	3.545 s (22.9%)
iast_GLOBAL	17.951 s [17.951 s, 17.951 s]	2.488 s (16.1%)
profiling	14.908 s [14.908 s, 14.908 s]	-555.0 ms (-3.6%)
tracing	15.152 s [15.152 s, 15.152 s]	-311.0 ms (-2.0%)

mcculls · 2024-05-30T08:49:45Z

FYI, the failing tests are because the JMXFetch App class is attempting to register an MBean in its constructor: https://github.com/DataDog/jmxfetch/blob/0.49.1/src/main/java/org/datadog/jmxfetch/App.java#L136

When JMXFetch is embedded and the user's application is using a custom MBean manager this may fail, which is what the failing tests have detected.

Ideally JMXFetch would only attempt to register the telemetry MBean if telemetry was enabled in AppConfig, or perhaps when AppConfig.isEmbedded() is false. That would require a new release of JMXFetch, but would be the cleanest solution.

Alternatively the call to register the telemetry MBean could be moved from the App constructor to the init method (since that would also require a change to JMXFetch it would be good to still add a way to turn off registration of the telemetry MBean as discussed above.)

Without a new release of JMXFetch the two options are:

add the updated new-gc-default-jmx-metrics.yaml file to dd-java-agent/agent-jmxfetch/src/main/resources/ so it overrides the file from 0.49.0 when everything is packed into the final dd-java-agent jar (this is the main reason for the upgrade I believe)
- we'll have to remember to remove this file when we next update JMXFetch, but this is a safe workaround
Rework the way we start JMXFetch to catch failures in the constructor and retry
- This is more risky because the constructor might be setting up other resources, and since the new MBean registration is at the bottom of the constructor those resources might not be cleaned up properly if/when the registration fails

carlosroman · 2024-05-30T09:02:08Z

@mcculls I'll have a look and see what can be done. Happy to do a new release of JMXFetch to fix this properly.

mcculls · 2024-05-30T09:08:15Z

thanks @carlosroman!

mcculls

+1 once we have a non-snapshot version

mcculls

LGTM, thanks!

carlosroman added the comp: metrics Metrics label Apr 23, 2024

carlosroman requested a review from a team as a code owner April 23, 2024 10:20

carlosroman requested review from dougqh and am312 April 23, 2024 10:20

carlosroman force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 03f771f to 08455e3 Compare April 23, 2024 10:28

PerfectSlayer added the tag: dependencies Dependencies related changes label Apr 23, 2024

PerfectSlayer changed the title ~~JMXFetch 0.49.1~~ Bump JMXFetch to 0.49.1 Apr 23, 2024

dougqh approved these changes Apr 29, 2024

View reviewed changes

mcculls approved these changes Apr 29, 2024

View reviewed changes

lcaproni-pp mentioned this pull request May 29, 2024

Question: When will the next release happen? #7088

Closed

mcculls force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 08455e3 to 5fc113f Compare May 29, 2024 22:16

mcculls requested changes May 29, 2024

View reviewed changes

carlosroman force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 5fc113f to 5d2bf85 Compare May 30, 2024 08:01

carlosroman mentioned this pull request May 30, 2024

[AMLII-1815] Telemetry is no longer initialized when telemetry disabled DataDog/jmxfetch#522

Merged

carlosroman force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 5d2bf85 to 239076c Compare June 5, 2024 11:30

carlosroman changed the title ~~Bump JMXFetch to 0.49.1~~ Bump JMXFetch to 0.49.2 Jun 5, 2024

mcculls self-requested a review June 5, 2024 12:36

mcculls approved these changes Jun 7, 2024

View reviewed changes

JMXFetch 0.49.2

40d4473

carlosroman force-pushed the carlosroman/AMLII-1643-bump-jmxfetch branch from 239076c to 40d4473 Compare June 7, 2024 17:07

mcculls approved these changes Jun 7, 2024

View reviewed changes

carlosroman merged commit 57d6042 into master Jun 10, 2024
81 checks passed

carlosroman deleted the carlosroman/AMLII-1643-bump-jmxfetch branch June 10, 2024 11:35

github-actions bot added this to the 1.36.0 milestone Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump JMXFetch to 0.49.2 #6935

Bump JMXFetch to 0.49.2 #6935

carlosroman commented Apr 23, 2024 •

edited

Loading

mcculls left a comment

pr-commenter bot commented May 29, 2024 •

edited

Loading

mcculls commented May 30, 2024 •

edited

Loading

carlosroman commented May 30, 2024

mcculls commented May 30, 2024

mcculls left a comment

mcculls left a comment

Bump JMXFetch to 0.49.2 #6935

Bump JMXFetch to 0.49.2 #6935

Conversation

carlosroman commented Apr 23, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

mcculls left a comment

Choose a reason for hiding this comment

pr-commenter bot commented May 29, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

mcculls commented May 30, 2024 • edited Loading

carlosroman commented May 30, 2024

mcculls commented May 30, 2024

mcculls left a comment

Choose a reason for hiding this comment

mcculls left a comment

Choose a reason for hiding this comment

carlosroman commented Apr 23, 2024 •

edited

Loading

pr-commenter bot commented May 29, 2024 •

edited

Loading

mcculls commented May 30, 2024 •

edited

Loading