Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check target super-class implements FieldBackedContextAccessor before delegating to it #6950

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Check target super-class implements FieldBackedContextAccessor before delegating to it #6950

merged 1 commit into from
Apr 30, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Apr 26, 2024

Motivation

This avoids the need to create (and catch) NoSuchMethodErrors when we fail to inject the super-class.

For example starting the profiler before byte-buddy can trigger loading of various JDK concurrent classes that we would usually inject context into. This is more noticeable on Java 22+ where more of these JDK classes are sub-classed.

@mcculls mcculls added comp: core Tracer core tag: performance Performance related changes labels Apr 26, 2024
@mcculls mcculls force-pushed the mcculls/superstore-check-assignable branch from e0ed9a8 to cb2f8b3 Compare April 26, 2024 11:19
@pr-commenter
Copy link

pr-commenter bot commented Apr 26, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/superstore-check-assignable
git_commit_date 1714168290 1714222774
git_commit_sha 2a8627d 25357f3
release_version 1.34.0-SNAPSHOT~2a8627d103 1.34.0-SNAPSHOT~25357f3dd9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714225558 1714225558
ci_job_id 499006160 499006160
ci_pipeline_id 33081763 33081763
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072688
Total [baseline] (8.535 s) : 0, 8534938
Agent [candidate] (1.076 s) : 0, 1076496
Total [candidate] (8.545 s) : 0, 8545230
section iast
Agent [baseline] (1.211 s) : 0, 1211174
Total [baseline] (9.035 s) : 0, 9035453
Agent [candidate] (1.2 s) : 0, 1199957
Total [candidate] (8.999 s) : 0, 8999025
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1201742
Total [baseline] (9.041 s) : 0, 9041034
Agent [candidate] (1.201 s) : 0, 1200675
Total [candidate] (8.945 s) : 0, 8944616
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1207332
Total [baseline] (9.041 s) : 0, 9040513
Agent [candidate] (1.197 s) : 0, 1197227
Total [candidate] (9.002 s) : 0, 9002276
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.211 s 138.486 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 129.054 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.207 s 134.644 ms (12.6%)
Total tracing 8.535 s -
Total iast 9.035 s 500.515 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.041 s 506.097 ms (5.9%)
Total iast_TELEMETRY_OFF 9.041 s 505.576 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.2 s 123.461 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 124.178 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.197 s 120.73 ms (11.2%)
Total tracing 8.545 s -
Total iast 8.999 s 453.795 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.945 s 399.386 ms (4.7%)
Total iast_TELEMETRY_OFF 9.002 s 457.047 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.07 ms) : 0, 672070
BytebuddyAgent [candidate] (674.46 ms) : 0, 674460
GlobalTracer [baseline] (308.657 ms) : 0, 308657
GlobalTracer [candidate] (309.96 ms) : 0, 309960
AppSec [baseline] (49.478 ms) : 0, 49478
AppSec [candidate] (49.453 ms) : 0, 49453
Remote Config [baseline] (656.427 µs) : 0, 656
Remote Config [candidate] (657.928 µs) : 0, 658
Telemetry [baseline] (7.532 ms) : 0, 7532
Telemetry [candidate] (7.63 ms) : 0, 7630
section iast
BytebuddyAgent [baseline] (801.79 ms) : 0, 801790
BytebuddyAgent [candidate] (794.413 ms) : 0, 794413
GlobalTracer [baseline] (291.806 ms) : 0, 291806
GlobalTracer [candidate] (288.425 ms) : 0, 288425
AppSec [baseline] (50.854 ms) : 0, 50854
AppSec [candidate] (50.451 ms) : 0, 50451
IAST [baseline] (24.275 ms) : 0, 24275
IAST [candidate] (25.125 ms) : 0, 25125
Remote Config [baseline] (579.048 µs) : 0, 579
Remote Config [candidate] (595.111 µs) : 0, 595
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (6.604 ms) : 0, 6604
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.644 ms) : 0, 794644
BytebuddyAgent [candidate] (794.972 ms) : 0, 794972
GlobalTracer [baseline] (289.484 ms) : 0, 289484
GlobalTracer [candidate] (288.324 ms) : 0, 288324
AppSec [baseline] (51.666 ms) : 0, 51666
AppSec [candidate] (52.902 ms) : 0, 52902
IAST [baseline] (24.156 ms) : 0, 24156
IAST [candidate] (22.754 ms) : 0, 22754
Remote Config [baseline] (632.131 µs) : 0, 632
Remote Config [candidate] (574.896 µs) : 0, 575
Telemetry [baseline] (6.61 ms) : 0, 6610
Telemetry [candidate] (6.723 ms) : 0, 6723
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.491 ms) : 0, 799491
BytebuddyAgent [candidate] (792.005 ms) : 0, 792005
GlobalTracer [baseline] (289.716 ms) : 0, 289716
GlobalTracer [candidate] (288.434 ms) : 0, 288434
AppSec [baseline] (48.842 ms) : 0, 48842
AppSec [candidate] (49.066 ms) : 0, 49066
IAST [baseline] (26.446 ms) : 0, 26446
IAST [candidate] (25.397 ms) : 0, 25397
Remote Config [baseline] (591.44 µs) : 0, 591
Remote Config [candidate] (588.448 µs) : 0, 588
Telemetry [baseline] (7.416 ms) : 0, 7416
Telemetry [candidate] (7.371 ms) : 0, 7371
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077992
Total [baseline] (10.437 s) : 0, 10436761
Agent [candidate] (1.083 s) : 0, 1083298
Total [candidate] (10.423 s) : 0, 10422603
section appsec
Agent [baseline] (1.192 s) : 0, 1191978
Total [baseline] (10.466 s) : 0, 10465786
Agent [candidate] (1.194 s) : 0, 1194446
Total [candidate] (10.493 s) : 0, 10493280
section iast
Agent [baseline] (1.208 s) : 0, 1208164
Total [baseline] (10.685 s) : 0, 10685458
Agent [candidate] (1.202 s) : 0, 1202193
Total [candidate] (10.853 s) : 0, 10853366
section profiling
Agent [baseline] (1.276 s) : 0, 1275840
Total [baseline] (10.622 s) : 0, 10621549
Agent [candidate] (1.268 s) : 0, 1267831
Total [candidate] (10.558 s) : 0, 10557509
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.192 s 113.985 ms (10.6%)
Agent iast 1.208 s 130.172 ms (12.1%)
Agent profiling 1.276 s 197.848 ms (18.4%)
Total tracing 10.437 s -
Total appsec 10.466 s 29.025 ms (0.3%)
Total iast 10.685 s 248.697 ms (2.4%)
Total profiling 10.622 s 184.788 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.194 s 111.148 ms (10.3%)
Agent iast 1.202 s 118.895 ms (11.0%)
Agent profiling 1.268 s 184.533 ms (17.0%)
Total tracing 10.423 s -
Total appsec 10.493 s 70.678 ms (0.7%)
Total iast 10.853 s 430.763 ms (4.1%)
Total profiling 10.558 s 134.906 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.218 ms) : 0, 674218
BytebuddyAgent [candidate] (678.839 ms) : 0, 678839
GlobalTracer [baseline] (311.403 ms) : 0, 311403
GlobalTracer [candidate] (311.79 ms) : 0, 311790
AppSec [baseline] (49.784 ms) : 0, 49784
AppSec [candidate] (49.785 ms) : 0, 49785
Remote Config [baseline] (663.364 µs) : 0, 663
Remote Config [candidate] (665.517 µs) : 0, 666
Telemetry [baseline] (7.62 ms) : 0, 7620
Telemetry [candidate] (7.624 ms) : 0, 7624
section appsec
BytebuddyAgent [baseline] (697.603 ms) : 0, 697603
BytebuddyAgent [candidate] (700.329 ms) : 0, 700329
GlobalTracer [baseline] (292.326 ms) : 0, 292326
GlobalTracer [candidate] (292.307 ms) : 0, 292307
AppSec [baseline] (149.339 ms) : 0, 149339
AppSec [candidate] (148.799 ms) : 0, 148799
Remote Config [baseline] (625.87 µs) : 0, 626
Remote Config [candidate] (617.464 µs) : 0, 617
Telemetry [baseline] (7.919 ms) : 0, 7919
Telemetry [candidate] (8.144 ms) : 0, 8144
IAST [baseline] (19.199 ms) : 0, 19199
IAST [candidate] (19.238 ms) : 0, 19238
section iast
BytebuddyAgent [baseline] (800.493 ms) : 0, 800493
BytebuddyAgent [candidate] (795.719 ms) : 0, 795719
GlobalTracer [baseline] (289.635 ms) : 0, 289635
GlobalTracer [candidate] (288.751 ms) : 0, 288751
AppSec [baseline] (50.026 ms) : 0, 50026
AppSec [candidate] (49.323 ms) : 0, 49323
Remote Config [baseline] (1.294 ms) : 0, 1294
Remote Config [candidate] (583.378 µs) : 0, 583
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (8.26 ms) : 0, 8260
IAST [baseline] (24.581 ms) : 0, 24581
IAST [candidate] (25.018 ms) : 0, 25018
section profiling
BytebuddyAgent [baseline] (682.233 ms) : 0, 682233
BytebuddyAgent [candidate] (677.639 ms) : 0, 677639
GlobalTracer [baseline] (382.189 ms) : 0, 382189
GlobalTracer [candidate] (380.279 ms) : 0, 380279
AppSec [baseline] (50.59 ms) : 0, 50590
AppSec [candidate] (49.988 ms) : 0, 49988
Remote Config [baseline] (712.633 µs) : 0, 713
Remote Config [candidate] (703.852 µs) : 0, 704
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (7.459 ms) : 0, 7459
ProfilingAgent [baseline] (95.768 ms) : 0, 95768
ProfilingAgent [candidate] (95.325 ms) : 0, 95325
Profiling [baseline] (95.793 ms) : 0, 95793
Profiling [candidate] (95.349 ms) : 0, 95349

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-27T13:16:48 2024-04-27T13:23:35
git_branch master mcculls/superstore-check-assignable
git_commit_date 1714168290 1714222774
git_commit_sha 2a8627d 25357f3
release_version 1.34.0-SNAPSHOT~2a8627d103 1.34.0-SNAPSHOT~25357f3dd9
start_time 2024-04-27T13:16:35 2024-04-27T13:23:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714224559 1714224559
ci_job_id 499006161 499006161
ci_pipeline_id 33081763 33081763
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1320, 1361
.   : milestone, 1341,
appsec (1.728 ms) : 1704, 1752
.   : milestone, 1728,
appsec_no_iast (1.716 ms) : 1692, 1740
.   : milestone, 1716,
iast (1.473 ms) : 1451, 1496
.   : milestone, 1473,
profiling (1.521 ms) : 1495, 1547
.   : milestone, 1521,
tracing (1.477 ms) : 1453, 1500
.   : milestone, 1477,
section candidate
no_agent (1.352 ms) : 1333, 1371
.   : milestone, 1352,
appsec (1.703 ms) : 1679, 1728
.   : milestone, 1703,
appsec_no_iast (1.736 ms) : 1712, 1760
.   : milestone, 1736,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.507 ms) : 1483, 1531
.   : milestone, 1507,
tracing (1.49 ms) : 1465, 1514
.   : milestone, 1490,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.32 ms, 1.361 ms] -
appsec 1.728 ms [1.704 ms, 1.752 ms] 387.009 µs (28.9%)
appsec_no_iast 1.716 ms [1.692 ms, 1.74 ms] 375.36 µs (28.0%)
iast 1.473 ms [1.451 ms, 1.496 ms] 132.886 µs (9.9%)
profiling 1.521 ms [1.495 ms, 1.547 ms] 180.131 µs (13.4%)
tracing 1.477 ms [1.453 ms, 1.5 ms] 135.972 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.371 ms] -
appsec 1.703 ms [1.679 ms, 1.728 ms] 351.697 µs (26.0%)
appsec_no_iast 1.736 ms [1.712 ms, 1.76 ms] 384.009 µs (28.4%)
iast 1.489 ms [1.466 ms, 1.512 ms] 137.205 µs (10.2%)
profiling 1.507 ms [1.483 ms, 1.531 ms] 155.483 µs (11.5%)
tracing 1.49 ms [1.465 ms, 1.514 ms] 138.235 µs (10.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.686 µs) : 344, 383
.   : milestone, 364,
iast (472.791 µs) : 452, 494
.   : milestone, 473,
iast_FULL (538.48 µs) : 517, 560
.   : milestone, 538,
iast_GLOBAL (490.316 µs) : 470, 511
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (473.282 µs) : 451, 495
.   : milestone, 473,
iast_INACTIVE (443.8 µs) : 423, 464
.   : milestone, 444,
iast_TELEMETRY_OFF (468.526 µs) : 447, 490
.   : milestone, 469,
tracing (445.01 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (365.688 µs) : 346, 385
.   : milestone, 366,
iast (472.9 µs) : 452, 494
.   : milestone, 473,
iast_FULL (542.45 µs) : 522, 563
.   : milestone, 542,
iast_GLOBAL (492.702 µs) : 472, 514
.   : milestone, 493,
iast_HARDCODED_SECRET_DISABLED (472.384 µs) : 451, 494
.   : milestone, 472,
iast_INACTIVE (437.228 µs) : 417, 457
.   : milestone, 437,
iast_TELEMETRY_OFF (470.632 µs) : 449, 492
.   : milestone, 471,
tracing (440.243 µs) : 420, 461
.   : milestone, 440,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.686 µs [344.246 µs, 383.125 µs] -
iast 472.791 µs [451.996 µs, 493.587 µs] 109.106 µs (30.0%)
iast_FULL 538.48 µs [516.976 µs, 559.983 µs] 174.794 µs (48.1%)
iast_GLOBAL 490.316 µs [469.848 µs, 510.785 µs] 126.631 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 473.282 µs [451.178 µs, 495.386 µs] 109.597 µs (30.1%)
iast_INACTIVE 443.8 µs [423.161 µs, 464.439 µs] 80.114 µs (22.0%)
iast_TELEMETRY_OFF 468.526 µs [447.018 µs, 490.035 µs] 104.841 µs (28.8%)
tracing 445.01 µs [423.942 µs, 466.078 µs] 81.324 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.688 µs [346.443 µs, 384.932 µs] -
iast 472.9 µs [452.25 µs, 493.55 µs] 107.212 µs (29.3%)
iast_FULL 542.45 µs [521.894 µs, 563.007 µs] 176.763 µs (48.3%)
iast_GLOBAL 492.702 µs [471.802 µs, 513.601 µs] 127.014 µs (34.7%)
iast_HARDCODED_SECRET_DISABLED 472.384 µs [450.701 µs, 494.068 µs] 106.697 µs (29.2%)
iast_INACTIVE 437.228 µs [416.98 µs, 457.477 µs] 71.541 µs (19.6%)
iast_TELEMETRY_OFF 470.632 µs [449.203 µs, 492.06 µs] 104.944 µs (28.7%)
tracing 440.243 µs [419.827 µs, 460.658 µs] 74.555 µs (20.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/superstore-check-assignable
git_commit_date 1714168290 1714222774
git_commit_sha 2a8627d 25357f3
release_version 1.34.0-SNAPSHOT~2a8627d103 1.34.0-SNAPSHOT~25357f3dd9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714225052 1714225052
ci_job_id 499006162 499006162
ci_pipeline_id 33081763 33081763
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.193 ms) : 2159, 2226
.   : milestone, 2193,
iast (1.879 ms) : 1843, 1914
.   : milestone, 1879,
iast_GLOBAL (1.906 ms) : 1872, 1941
.   : milestone, 1906,
profiling (1.832 ms) : 1799, 1866
.   : milestone, 1832,
tracing (1.824 ms) : 1792, 1855
.   : milestone, 1824,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.186 ms) : 2153, 2220
.   : milestone, 2186,
iast (1.872 ms) : 1837, 1907
.   : milestone, 1872,
iast_GLOBAL (1.906 ms) : 1871, 1941
.   : milestone, 1906,
profiling (1.837 ms) : 1805, 1870
.   : milestone, 1837,
tracing (1.826 ms) : 1794, 1858
.   : milestone, 1826,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.193 ms [2.159 ms, 2.226 ms] 732.581 µs (50.2%)
iast 1.879 ms [1.843 ms, 1.914 ms] 418.664 µs (28.7%)
iast_GLOBAL 1.906 ms [1.872 ms, 1.941 ms] 446.272 µs (30.6%)
profiling 1.832 ms [1.799 ms, 1.866 ms] 371.978 µs (25.5%)
tracing 1.824 ms [1.792 ms, 1.855 ms] 363.774 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.186 ms [2.153 ms, 2.22 ms] 724.659 µs (49.6%)
iast 1.872 ms [1.837 ms, 1.907 ms] 410.237 µs (28.1%)
iast_GLOBAL 1.906 ms [1.871 ms, 1.941 ms] 444.318 µs (30.4%)
profiling 1.837 ms [1.805 ms, 1.87 ms] 375.435 µs (25.7%)
tracing 1.826 ms [1.794 ms, 1.858 ms] 364.525 µs (24.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~25357f3dd9, baseline=1.34.0-SNAPSHOT~2a8627d103
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
appsec (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
iast (18.468 s) : 18468000, 18468000
.   : milestone, 18468000,
iast_GLOBAL (18.018 s) : 18018000, 18018000
.   : milestone, 18018000,
profiling (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
tracing (14.919 s) : 14919000, 14919000
.   : milestone, 14919000,
section candidate
no_agent (14.844 s) : 14844000, 14844000
.   : milestone, 14844000,
appsec (14.768 s) : 14768000, 14768000
.   : milestone, 14768000,
iast (19.242 s) : 19242000, 19242000
.   : milestone, 19242000,
iast_GLOBAL (17.757 s) : 17757000, 17757000
.   : milestone, 17757000,
profiling (15.115 s) : 15115000, 15115000
.   : milestone, 15115000,
tracing (14.846 s) : 14846000, 14846000
.   : milestone, 14846000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.033 s [15.033 s, 15.033 s] -
appsec 15.058 s [15.058 s, 15.058 s] 25.0 ms (0.2%)
iast 18.468 s [18.468 s, 18.468 s] 3.435 s (22.8%)
iast_GLOBAL 18.018 s [18.018 s, 18.018 s] 2.985 s (19.9%)
profiling 15.143 s [15.143 s, 15.143 s] 110.0 ms (0.7%)
tracing 14.919 s [14.919 s, 14.919 s] -114.0 ms (-0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.844 s [14.844 s, 14.844 s] -
appsec 14.768 s [14.768 s, 14.768 s] -76.0 ms (-0.5%)
iast 19.242 s [19.242 s, 19.242 s] 4.398 s (29.6%)
iast_GLOBAL 17.757 s [17.757 s, 17.757 s] 2.913 s (19.6%)
profiling 15.115 s [15.115 s, 15.115 s] 271.0 ms (1.8%)
tracing 14.846 s [14.846 s, 14.846 s] 2.0 ms (0.0%)

@mcculls mcculls marked this pull request as ready for review April 26, 2024 12:58
@mcculls mcculls requested a review from a team as a code owner April 26, 2024 12:58
@mcculls mcculls force-pushed the mcculls/superstore-check-assignable branch 7 times, most recently from 25357f3 to 160360d Compare April 27, 2024 13:00
@mcculls
Check target super-class implements FieldBackedContextAccessor befo…
06d5777 
…re delegating to it

This avoids the need to create (and catch) `NoSuchMethodError`s when we fail to inject the super-class.

For example starting the profiler before byte-buddy can trigger loading of various JDK concurrent classes that we would usually inject context into.
@mcculls mcculls force-pushed the mcculls/superstore-check-assignable branch from 160360d to 06d5777 Compare April 27, 2024 13:02
@mcculls mcculls merged commit 2b0502c into master Apr 30, 2024
80 checks passed
@mcculls mcculls deleted the mcculls/superstore-check-assignable branch April 30, 2024 10:23
@github-actions github-actions bot added this to the 1.34.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: performance Performance related changes
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcculls @dougqh