unwrap akka `TaskInvocation` and scala `CallbackRunnable` #6975

richardstartin · 2024-04-30T13:06:51Z

What Does This Do

Makes akka TaskInvocation instances unwrappable so we can access the name of the Runnable they carry.

final case class TaskInvocation(eventStream: _root_.akka.event.EventStream, runnable: _root_.java.lang.Runnable, cleanup: () => _root_.scala.Unit) extends _root_.akka.dispatch.Batchable {
  override final def isBatchable: _root_.scala.Boolean = ???

  def run(): _root_.scala.Unit = ???
}

Also allows access to Scala's CalbackRunnable's onComplete field.

Motivation

This will allow the time spent queueing by TaskInvocations to be disaggregated.

Additional Notes

Jira ticket: PROF-9696

pr-commenter · 2024-04-30T13:54:07Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/unwrap-akka-taskinvocation
git_commit_date	1714482408	1714483611
git_commit_sha	`fcfaf54`	`13553ae`
release_version	1.34.0-SNAPSHOT~fcfaf54d06	1.34.0-SNAPSHOT~13553aefad

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714486149	1714486149
ci_job_id	500799219	500799219
ci_pipeline_id	33249855	33249855
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074197
Total [baseline] (8.549 s) : 0, 8548679
Agent [candidate] (1.077 s) : 0, 1077016
Total [candidate] (8.578 s) : 0, 8577574
section iast
Agent [baseline] (1.212 s) : 0, 1212331
Total [baseline] (9.069 s) : 0, 9069057
Agent [candidate] (1.202 s) : 0, 1202388
Total [candidate] (9.015 s) : 0, 9015264
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1202981
Total [baseline] (8.985 s) : 0, 8984956
Agent [candidate] (1.199 s) : 0, 1198670
Total [candidate] (9.0 s) : 0, 8999906
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1206351
Total [baseline] (9.04 s) : 0, 9039931
Agent [candidate] (1.205 s) : 0, 1204974
Total [candidate] (9.011 s) : 0, 9010939

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.074 s	-
Agent	iast	1.212 s	138.134 ms (12.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.203 s	128.784 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.206 s	132.154 ms (12.3%)
Total	tracing	8.549 s	-
Total	iast	9.069 s	520.379 ms (6.1%)
Total	iast_HARDCODED_SECRET_DISABLED	8.985 s	436.278 ms (5.1%)
Total	iast_TELEMETRY_OFF	9.04 s	491.252 ms (5.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.077 s	-
Agent	iast	1.202 s	125.372 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.199 s	121.654 ms (11.3%)
Agent	iast_TELEMETRY_OFF	1.205 s	127.958 ms (11.9%)
Total	tracing	8.578 s	-
Total	iast	9.015 s	437.689 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.0 s	422.331 ms (4.9%)
Total	iast_TELEMETRY_OFF	9.011 s	433.364 ms (5.1%)

gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.705 ms) : 0, 672705
BytebuddyAgent [candidate] (674.377 ms) : 0, 674377
GlobalTracer [baseline] (309.343 ms) : 0, 309343
GlobalTracer [candidate] (310.244 ms) : 0, 310244
AppSec [baseline] (49.512 ms) : 0, 49512
AppSec [candidate] (49.672 ms) : 0, 49672
Remote Config [baseline] (663.588 µs) : 0, 664
Remote Config [candidate] (670.631 µs) : 0, 671
Telemetry [baseline] (7.645 ms) : 0, 7645
Telemetry [candidate] (7.672 ms) : 0, 7672
section iast
BytebuddyAgent [baseline] (803.105 ms) : 0, 803105
BytebuddyAgent [candidate] (795.883 ms) : 0, 795883
GlobalTracer [baseline] (291.246 ms) : 0, 291246
GlobalTracer [candidate] (289.35 ms) : 0, 289350
AppSec [baseline] (50.314 ms) : 0, 50314
AppSec [candidate] (50.456 ms) : 0, 50456
IAST [baseline] (25.745 ms) : 0, 25745
IAST [candidate] (24.986 ms) : 0, 24986
Remote Config [baseline] (593.973 µs) : 0, 594
Remote Config [candidate] (737.774 µs) : 0, 738
Telemetry [baseline] (6.643 ms) : 0, 6643
Telemetry [candidate] (6.652 ms) : 0, 6652
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.515 ms) : 0, 796515
BytebuddyAgent [candidate] (793.45 ms) : 0, 793450
GlobalTracer [baseline] (289.194 ms) : 0, 289194
GlobalTracer [candidate] (288.812 ms) : 0, 288812
AppSec [baseline] (50.345 ms) : 0, 50345
AppSec [candidate] (49.082 ms) : 0, 49082
IAST [baseline] (24.415 ms) : 0, 24415
IAST [candidate] (24.886 ms) : 0, 24886
Remote Config [baseline] (1.347 ms) : 0, 1347
Remote Config [candidate] (1.304 ms) : 0, 1304
Telemetry [baseline] (6.752 ms) : 0, 6752
Telemetry [candidate] (6.709 ms) : 0, 6709
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.524 ms) : 0, 798524
BytebuddyAgent [candidate] (797.599 ms) : 0, 797599
GlobalTracer [baseline] (290.126 ms) : 0, 290126
GlobalTracer [candidate] (290.461 ms) : 0, 290461
AppSec [baseline] (51.224 ms) : 0, 51224
AppSec [candidate] (52.246 ms) : 0, 52246
IAST [baseline] (24.668 ms) : 0, 24668
IAST [candidate] (22.835 ms) : 0, 22835
Remote Config [baseline] (588.575 µs) : 0, 589
Remote Config [candidate] (583.082 µs) : 0, 583
Telemetry [baseline] (6.691 ms) : 0, 6691
Telemetry [candidate] (6.631 ms) : 0, 6631

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076250
Total [baseline] (10.47 s) : 0, 10470405
Agent [candidate] (1.077 s) : 0, 1077211
Total [candidate] (10.377 s) : 0, 10377011
section appsec
Agent [baseline] (1.198 s) : 0, 1198325
Total [baseline] (10.518 s) : 0, 10517927
Agent [candidate] (1.194 s) : 0, 1194008
Total [candidate] (10.534 s) : 0, 10533530
section iast
Agent [baseline] (1.202 s) : 0, 1202023
Total [baseline] (10.823 s) : 0, 10822927
Agent [candidate] (1.209 s) : 0, 1209031
Total [candidate] (10.794 s) : 0, 10793508
section profiling
Agent [baseline] (1.268 s) : 0, 1268484
Total [baseline] (10.541 s) : 0, 10541483
Agent [candidate] (1.268 s) : 0, 1268135
Total [candidate] (10.614 s) : 0, 10613910

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	appsec	1.198 s	122.074 ms (11.3%)
Agent	iast	1.202 s	125.772 ms (11.7%)
Agent	profiling	1.268 s	192.234 ms (17.9%)
Total	tracing	10.47 s	-
Total	appsec	10.518 s	47.522 ms (0.5%)
Total	iast	10.823 s	352.522 ms (3.4%)
Total	profiling	10.541 s	71.078 ms (0.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.077 s	-
Agent	appsec	1.194 s	116.797 ms (10.8%)
Agent	iast	1.209 s	131.82 ms (12.2%)
Agent	profiling	1.268 s	190.924 ms (17.7%)
Total	tracing	10.377 s	-
Total	appsec	10.534 s	156.519 ms (1.5%)
Total	iast	10.794 s	416.497 ms (4.0%)
Total	profiling	10.614 s	236.899 ms (2.3%)

gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.219 ms) : 0, 674219
BytebuddyAgent [candidate] (674.863 ms) : 0, 674863
GlobalTracer [baseline] (310.088 ms) : 0, 310088
GlobalTracer [candidate] (310.265 ms) : 0, 310265
AppSec [baseline] (49.304 ms) : 0, 49304
AppSec [candidate] (49.409 ms) : 0, 49409
Remote Config [baseline] (660.003 µs) : 0, 660
Remote Config [candidate] (652.805 µs) : 0, 653
Telemetry [baseline] (7.618 ms) : 0, 7618
Telemetry [candidate] (7.556 ms) : 0, 7556
section appsec
BytebuddyAgent [baseline] (702.274 ms) : 0, 702274
BytebuddyAgent [candidate] (698.1 ms) : 0, 698100
GlobalTracer [baseline] (293.1 ms) : 0, 293100
GlobalTracer [candidate] (292.908 ms) : 0, 292908
AppSec [baseline] (149.665 ms) : 0, 149665
AppSec [candidate] (149.372 ms) : 0, 149372
Remote Config [baseline] (628.771 µs) : 0, 629
Remote Config [candidate] (628.162 µs) : 0, 628
Telemetry [baseline] (8.249 ms) : 0, 8249
Telemetry [candidate] (8.82 ms) : 0, 8820
IAST [baseline] (19.322 ms) : 0, 19322
IAST [candidate] (19.242 ms) : 0, 19242
section iast
BytebuddyAgent [baseline] (796.001 ms) : 0, 796001
BytebuddyAgent [candidate] (800.8 ms) : 0, 800800
GlobalTracer [baseline] (289.021 ms) : 0, 289021
GlobalTracer [candidate] (290.416 ms) : 0, 290416
AppSec [baseline] (48.948 ms) : 0, 48948
AppSec [candidate] (50.814 ms) : 0, 50814
Remote Config [baseline] (1.28 ms) : 0, 1280
Remote Config [candidate] (2.102 ms) : 0, 2102
Telemetry [baseline] (7.352 ms) : 0, 7352
Telemetry [candidate] (7.517 ms) : 0, 7517
IAST [baseline] (25.041 ms) : 0, 25041
IAST [candidate] (22.744 ms) : 0, 22744
section profiling
ProfilingAgent [baseline] (95.506 ms) : 0, 95506
ProfilingAgent [candidate] (95.6 ms) : 0, 95600
BytebuddyAgent [baseline] (677.914 ms) : 0, 677914
BytebuddyAgent [candidate] (677.465 ms) : 0, 677465
GlobalTracer [baseline] (380.25 ms) : 0, 380250
GlobalTracer [candidate] (380.592 ms) : 0, 380592
AppSec [baseline] (50.23 ms) : 0, 50230
AppSec [candidate] (49.968 ms) : 0, 49968
Remote Config [baseline] (710.773 µs) : 0, 711
Remote Config [candidate] (697.135 µs) : 0, 697
Telemetry [baseline] (7.456 ms) : 0, 7456
Telemetry [candidate] (7.442 ms) : 0, 7442
Profiling [baseline] (95.53 ms) : 0, 95530
Profiling [candidate] (95.624 ms) : 0, 95624

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-04-30T13:41:26	2024-04-30T13:48:16
git_branch	master	rgs/unwrap-akka-taskinvocation
git_commit_date	1714482408	1714483611
git_commit_sha	`fcfaf54`	`13553ae`
release_version	1.34.0-SNAPSHOT~fcfaf54d06	1.34.0-SNAPSHOT~13553aefad
start_time	2024-04-30T13:41:13	2024-04-30T13:48:03

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714485241	1714485241
ci_job_id	500799220	500799220
ci_pipeline_id	33249855	33249855
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.515 µs) : 351, 392
.   : milestone, 372,
iast (477.267 µs) : 457, 498
.   : milestone, 477,
iast_FULL (547.013 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (505.968 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (478.837 µs) : 457, 500
.   : milestone, 479,
iast_INACTIVE (453.565 µs) : 433, 474
.   : milestone, 454,
iast_TELEMETRY_OFF (476.035 µs) : 455, 497
.   : milestone, 476,
tracing (455.295 µs) : 435, 476
.   : milestone, 455,
section candidate
no_agent (373.975 µs) : 355, 393
.   : milestone, 374,
iast (481.879 µs) : 461, 503
.   : milestone, 482,
iast_FULL (546.203 µs) : 526, 567
.   : milestone, 546,
iast_GLOBAL (498.614 µs) : 478, 519
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (478.114 µs) : 456, 500
.   : milestone, 478,
iast_INACTIVE (459.484 µs) : 438, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (477.603 µs) : 456, 499
.   : milestone, 478,
tracing (451.952 µs) : 431, 473
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.515 µs [350.764 µs, 392.267 µs]	-
iast	477.267 µs [456.815 µs, 497.719 µs]	105.751 µs (28.5%)
iast_FULL	547.013 µs [526.453 µs, 567.574 µs]	175.498 µs (47.2%)
iast_GLOBAL	505.968 µs [484.793 µs, 527.143 µs]	134.453 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED	478.837 µs [457.28 µs, 500.394 µs]	107.321 µs (28.9%)
iast_INACTIVE	453.565 µs [433.046 µs, 474.085 µs]	82.05 µs (22.1%)
iast_TELEMETRY_OFF	476.035 µs [454.742 µs, 497.328 µs]	104.519 µs (28.1%)
tracing	455.295 µs [434.675 µs, 475.916 µs]	83.78 µs (22.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.975 µs [354.535 µs, 393.414 µs]	-
iast	481.879 µs [461.198 µs, 502.56 µs]	107.904 µs (28.9%)
iast_FULL	546.203 µs [525.762 µs, 566.644 µs]	172.228 µs (46.1%)
iast_GLOBAL	498.614 µs [478.237 µs, 518.992 µs]	124.64 µs (33.3%)
iast_HARDCODED_SECRET_DISABLED	478.114 µs [456.064 µs, 500.164 µs]	104.139 µs (27.8%)
iast_INACTIVE	459.484 µs [437.924 µs, 481.043 µs]	85.509 µs (22.9%)
iast_TELEMETRY_OFF	477.603 µs [456.312 µs, 498.895 µs]	103.629 µs (27.7%)
tracing	451.952 µs [430.949 µs, 472.955 µs]	77.977 µs (20.9%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1319, 1358
.   : milestone, 1338,
appsec (1.726 ms) : 1702, 1751
.   : milestone, 1726,
appsec_no_iast (1.71 ms) : 1685, 1734
.   : milestone, 1710,
iast (1.496 ms) : 1473, 1519
.   : milestone, 1496,
profiling (1.487 ms) : 1463, 1512
.   : milestone, 1487,
tracing (1.498 ms) : 1474, 1523
.   : milestone, 1498,
section candidate
no_agent (1.345 ms) : 1326, 1365
.   : milestone, 1345,
appsec (1.706 ms) : 1681, 1730
.   : milestone, 1706,
appsec_no_iast (1.711 ms) : 1686, 1737
.   : milestone, 1711,
iast (1.49 ms) : 1467, 1513
.   : milestone, 1490,
profiling (1.499 ms) : 1475, 1524
.   : milestone, 1499,
tracing (1.501 ms) : 1477, 1525
.   : milestone, 1501,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.338 ms [1.319 ms, 1.358 ms]	-
appsec	1.726 ms [1.702 ms, 1.751 ms]	387.976 µs (29.0%)
appsec_no_iast	1.71 ms [1.685 ms, 1.734 ms]	371.129 µs (27.7%)
iast	1.496 ms [1.473 ms, 1.519 ms]	157.197 µs (11.7%)
profiling	1.487 ms [1.463 ms, 1.512 ms]	148.723 µs (11.1%)
tracing	1.498 ms [1.474 ms, 1.523 ms]	159.768 µs (11.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.345 ms [1.326 ms, 1.365 ms]	-
appsec	1.706 ms [1.681 ms, 1.73 ms]	360.375 µs (26.8%)
appsec_no_iast	1.711 ms [1.686 ms, 1.737 ms]	365.77 µs (27.2%)
iast	1.49 ms [1.467 ms, 1.513 ms]	144.876 µs (10.8%)
profiling	1.499 ms [1.475 ms, 1.524 ms]	153.932 µs (11.4%)
tracing	1.501 ms [1.477 ms, 1.525 ms]	155.452 µs (11.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/unwrap-akka-taskinvocation
git_commit_date	1714482408	1714483611
git_commit_sha	`fcfaf54`	`13553ae`
release_version	1.34.0-SNAPSHOT~fcfaf54d06	1.34.0-SNAPSHOT~13553aefad

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1714485784	1714485784
ci_job_id	500799221	500799221
ci_pipeline_id	33249855	33249855
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.208 ms) : 2175, 2242
.   : milestone, 2208,
iast (1.885 ms) : 1850, 1920
.   : milestone, 1885,
iast_GLOBAL (1.93 ms) : 1895, 1965
.   : milestone, 1930,
profiling (1.861 ms) : 1828, 1895
.   : milestone, 1861,
tracing (1.841 ms) : 1809, 1873
.   : milestone, 1841,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.208 ms) : 2175, 2242
.   : milestone, 2208,
iast (1.89 ms) : 1855, 1925
.   : milestone, 1890,
iast_GLOBAL (1.925 ms) : 1891, 1960
.   : milestone, 1925,
profiling (1.863 ms) : 1829, 1897
.   : milestone, 1863,
tracing (1.838 ms) : 1806, 1869
.   : milestone, 1838,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.208 ms [2.175 ms, 2.242 ms]	736.563 µs (50.1%)
iast	1.885 ms [1.85 ms, 1.92 ms]	413.673 µs (28.1%)
iast_GLOBAL	1.93 ms [1.895 ms, 1.965 ms]	458.128 µs (31.1%)
profiling	1.861 ms [1.828 ms, 1.895 ms]	389.885 µs (26.5%)
tracing	1.841 ms [1.809 ms, 1.873 ms]	369.214 µs (25.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.456 ms, 1.479 ms]	-
appsec	2.208 ms [2.175 ms, 2.242 ms]	741.053 µs (50.5%)
iast	1.89 ms [1.855 ms, 1.925 ms]	422.595 µs (28.8%)
iast_GLOBAL	1.925 ms [1.891 ms, 1.96 ms]	458.052 µs (31.2%)
profiling	1.863 ms [1.829 ms, 1.897 ms]	395.549 µs (27.0%)
tracing	1.838 ms [1.806 ms, 1.869 ms]	370.321 µs (25.2%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~13553aefad, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.652 s) : 15652000, 15652000
.   : milestone, 15652000,
appsec (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
iast (19.06 s) : 19060000, 19060000
.   : milestone, 19060000,
iast_GLOBAL (18.009 s) : 18009000, 18009000
.   : milestone, 18009000,
profiling (15.813 s) : 15813000, 15813000
.   : milestone, 15813000,
tracing (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
section candidate
no_agent (15.263 s) : 15263000, 15263000
.   : milestone, 15263000,
appsec (14.936 s) : 14936000, 14936000
.   : milestone, 14936000,
iast (18.618 s) : 18618000, 18618000
.   : milestone, 18618000,
iast_GLOBAL (17.984 s) : 17984000, 17984000
.   : milestone, 17984000,
profiling (15.352 s) : 15352000, 15352000
.   : milestone, 15352000,
tracing (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.652 s [15.652 s, 15.652 s]	-
appsec	15.137 s [15.137 s, 15.137 s]	-515.0 ms (-3.3%)
iast	19.06 s [19.06 s, 19.06 s]	3.408 s (21.8%)
iast_GLOBAL	18.009 s [18.009 s, 18.009 s]	2.357 s (15.1%)
profiling	15.813 s [15.813 s, 15.813 s]	161.0 ms (1.0%)
tracing	15.114 s [15.114 s, 15.114 s]	-538.0 ms (-3.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.263 s [15.263 s, 15.263 s]	-
appsec	14.936 s [14.936 s, 14.936 s]	-327.0 ms (-2.1%)
iast	18.618 s [18.618 s, 18.618 s]	3.355 s (22.0%)
iast_GLOBAL	17.984 s [17.984 s, 17.984 s]	2.721 s (17.8%)
profiling	15.352 s [15.352 s, 15.352 s]	89.0 ms (0.6%)
tracing	15.019 s [15.019 s, 15.019 s]	-244.0 ms (-1.6%)

unwrap akka TaskInvocations

4ade2c0

richardstartin requested a review from a team April 30, 2024 13:07

richardstartin marked this pull request as ready for review April 30, 2024 13:20

richardstartin requested a review from a team as a code owner April 30, 2024 13:20

richardstartin requested review from dougqh and am312 April 30, 2024 13:20

make CallbackRunnable unwrappable

13553ae

richardstartin changed the title ~~unwrap akka TaskInvocations~~ unwrap akka TaskInvocation and scala CallbackRunnable Apr 30, 2024

richardstartin added comp: profiling Profiling inst: scala Scala instrumentation inst: akka Akka instrumentation labels Apr 30, 2024

jbachorik approved these changes Apr 30, 2024

View reviewed changes

richardstartin merged commit d113543 into master Apr 30, 2024
80 checks passed

richardstartin deleted the rgs/unwrap-akka-taskinvocation branch April 30, 2024 14:51

github-actions bot added this to the 1.34.0 milestone Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unwrap akka `TaskInvocation` and scala `CallbackRunnable` #6975

unwrap akka `TaskInvocation` and scala `CallbackRunnable` #6975

richardstartin commented Apr 30, 2024 •

edited

pr-commenter bot commented Apr 30, 2024 •

edited

unwrap akka TaskInvocation and scala CallbackRunnable #6975

unwrap akka TaskInvocation and scala CallbackRunnable #6975

Conversation

richardstartin commented Apr 30, 2024 • edited

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Apr 30, 2024 • edited

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

unwrap akka `TaskInvocation` and scala `CallbackRunnable` #6975

unwrap akka `TaskInvocation` and scala `CallbackRunnable` #6975

richardstartin commented Apr 30, 2024 •

edited

pr-commenter bot commented Apr 30, 2024 •

edited