Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Instrumentation] Consolidate PII redaction keys for all libraries. #6980

Merged
merged 1 commit into from
May 6, 2024
Merged

[Dynamic Instrumentation] Consolidate PII redaction keys for all libraries. #6980

merged 1 commit into from
May 6, 2024

Conversation

shurivich
Copy link
Contributor

@shurivich shurivich commented May 2, 2024 •
edited

What Does This Do

Consolidate PII redaction keys for all libraries.

Additional Notes

Related PRs:
dotnet - DataDog/dd-trace-dotnet#5522
python - DataDog/dd-trace-py#9148

@shurivich shurivich added the comp: debugger Dynamic Instrumentation label May 2, 2024
@shurivich shurivich self-assigned this May 2, 2024
@shurivich shurivich requested a review from a team as a code owner May 2, 2024 13:35
@shurivich shurivich requested review from cimi and removed request for a team May 2, 2024 13:35
This was referenced May 2, 2024
Merged
Merged
@pr-commenter
Copy link

pr-commenter bot commented May 2, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master shurivich/consolidate_pii
git_commit_date 1714652169 1714656616
git_commit_sha 0b24171 6b184e6
release_version 1.34.0-SNAPSHOT~0b241711ac 1.34.0-SNAPSHOT~6b184e6e54
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714659262 1714659262
ci_job_id 502601984 502601984
ci_pipeline_id 33432097 33432097
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075043
Total [baseline] (8.58 s) : 0, 8579862
Agent [candidate] (1.076 s) : 0, 1075665
Total [candidate] (8.551 s) : 0, 8551461
section iast
Agent [baseline] (1.203 s) : 0, 1202572
Total [baseline] (9.014 s) : 0, 9013877
Agent [candidate] (1.202 s) : 0, 1202306
Total [candidate] (9.004 s) : 0, 9003535
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1214721
Total [baseline] (9.014 s) : 0, 9013507
Agent [candidate] (1.207 s) : 0, 1207381
Total [candidate] (8.995 s) : 0, 8994629
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1206374
Total [baseline] (9.091 s) : 0, 9090998
Agent [candidate] (1.206 s) : 0, 1206282
Total [candidate] (9.015 s) : 0, 9014918
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.203 s 127.529 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.215 s 139.678 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.206 s 131.331 ms (12.2%)
Total tracing 8.58 s -
Total iast 9.014 s 434.015 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.014 s 433.645 ms (5.1%)
Total iast_TELEMETRY_OFF 9.091 s 511.137 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.202 s 126.64 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 131.716 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.206 s 130.617 ms (12.1%)
Total tracing 8.551 s -
Total iast 9.004 s 452.074 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.995 s 443.167 ms (5.2%)
Total iast_TELEMETRY_OFF 9.015 s 463.456 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.806 ms) : 0, 673806
BytebuddyAgent [candidate] (674.153 ms) : 0, 674153
GlobalTracer [baseline] (309.38 ms) : 0, 309380
GlobalTracer [candidate] (309.589 ms) : 0, 309589
AppSec [baseline] (49.229 ms) : 0, 49229
AppSec [candidate] (49.339 ms) : 0, 49339
Remote Config [baseline] (657.38 µs) : 0, 657
Remote Config [candidate] (658.125 µs) : 0, 658
Telemetry [baseline] (7.594 ms) : 0, 7594
Telemetry [candidate] (7.567 ms) : 0, 7567
section iast
BytebuddyAgent [baseline] (796.996 ms) : 0, 796996
BytebuddyAgent [candidate] (795.819 ms) : 0, 795819
GlobalTracer [baseline] (289.266 ms) : 0, 289266
GlobalTracer [candidate] (289.157 ms) : 0, 289157
AppSec [baseline] (51.246 ms) : 0, 51246
AppSec [candidate] (50.422 ms) : 0, 50422
IAST [baseline] (23.331 ms) : 0, 23331
IAST [candidate] (25.099 ms) : 0, 25099
Remote Config [baseline] (587.158 µs) : 0, 587
Remote Config [candidate] (612.211 µs) : 0, 612
Telemetry [baseline] (6.622 ms) : 0, 6622
Telemetry [candidate] (6.572 ms) : 0, 6572
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (805.825 ms) : 0, 805825
BytebuddyAgent [candidate] (794.873 ms) : 0, 794873
GlobalTracer [baseline] (291.021 ms) : 0, 291021
GlobalTracer [candidate] (295.088 ms) : 0, 295088
AppSec [baseline] (53.741 ms) : 0, 53741
AppSec [candidate] (51.534 ms) : 0, 51534
IAST [baseline] (21.136 ms) : 0, 21136
IAST [candidate] (22.69 ms) : 0, 22690
Remote Config [baseline] (584.881 µs) : 0, 585
Remote Config [candidate] (2.05 ms) : 0, 2050
Telemetry [baseline] (7.486 ms) : 0, 7486
Telemetry [candidate] (6.678 ms) : 0, 6678
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.162 ms) : 0, 799162
BytebuddyAgent [candidate] (798.948 ms) : 0, 798948
GlobalTracer [baseline] (290.031 ms) : 0, 290031
GlobalTracer [candidate] (290.247 ms) : 0, 290247
AppSec [baseline] (51.473 ms) : 0, 51473
AppSec [candidate] (51.989 ms) : 0, 51989
IAST [baseline] (23.119 ms) : 0, 23119
IAST [candidate] (23.237 ms) : 0, 23237
Remote Config [baseline] (581.028 µs) : 0, 581
Remote Config [candidate] (582.161 µs) : 0, 582
Telemetry [baseline] (7.366 ms) : 0, 7366
Telemetry [candidate] (6.677 ms) : 0, 6677
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076429
Total [baseline] (10.411 s) : 0, 10411117
Agent [candidate] (1.078 s) : 0, 1078014
Total [candidate] (10.458 s) : 0, 10457771
section appsec
Agent [baseline] (1.19 s) : 0, 1190401
Total [baseline] (10.46 s) : 0, 10460110
Agent [candidate] (1.194 s) : 0, 1194419
Total [candidate] (10.502 s) : 0, 10502489
section iast
Agent [baseline] (1.207 s) : 0, 1206734
Total [baseline] (10.772 s) : 0, 10772372
Agent [candidate] (1.2 s) : 0, 1199721
Total [candidate] (10.711 s) : 0, 10710863
section profiling
Agent [baseline] (1.27 s) : 0, 1269910
Total [baseline] (10.621 s) : 0, 10621014
Agent [candidate] (1.28 s) : 0, 1279796
Total [candidate] (10.706 s) : 0, 10706361
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.19 s 113.972 ms (10.6%)
Agent iast 1.207 s 130.306 ms (12.1%)
Agent profiling 1.27 s 193.482 ms (18.0%)
Total tracing 10.411 s -
Total appsec 10.46 s 48.993 ms (0.5%)
Total iast 10.772 s 361.255 ms (3.5%)
Total profiling 10.621 s 209.897 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.194 s 116.405 ms (10.8%)
Agent iast 1.2 s 121.707 ms (11.3%)
Agent profiling 1.28 s 201.782 ms (18.7%)
Total tracing 10.458 s -
Total appsec 10.502 s 44.719 ms (0.4%)
Total iast 10.711 s 253.092 ms (2.4%)
Total profiling 10.706 s 248.59 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.494 ms) : 0, 674494
BytebuddyAgent [candidate] (674.417 ms) : 0, 674417
GlobalTracer [baseline] (309.722 ms) : 0, 309722
GlobalTracer [candidate] (311.095 ms) : 0, 311095
AppSec [baseline] (49.521 ms) : 0, 49521
AppSec [candidate] (49.724 ms) : 0, 49724
Remote Config [baseline] (667.748 µs) : 0, 668
Remote Config [candidate] (666.974 µs) : 0, 667
Telemetry [baseline] (7.634 ms) : 0, 7634
Telemetry [candidate] (7.672 ms) : 0, 7672
section appsec
BytebuddyAgent [baseline] (696.153 ms) : 0, 696153
BytebuddyAgent [candidate] (698.82 ms) : 0, 698820
GlobalTracer [baseline] (291.958 ms) : 0, 291958
GlobalTracer [candidate] (293.008 ms) : 0, 293008
AppSec [baseline] (149.185 ms) : 0, 149185
AppSec [candidate] (149.587 ms) : 0, 149587
IAST [baseline] (19.146 ms) : 0, 19146
IAST [candidate] (19.217 ms) : 0, 19217
Remote Config [baseline] (619.523 µs) : 0, 620
Remote Config [candidate] (625.877 µs) : 0, 626
Telemetry [baseline] (8.499 ms) : 0, 8499
Telemetry [candidate] (8.203 ms) : 0, 8203
section iast
BytebuddyAgent [baseline] (800.873 ms) : 0, 800873
BytebuddyAgent [candidate] (794.768 ms) : 0, 794768
GlobalTracer [baseline] (290.208 ms) : 0, 290208
GlobalTracer [candidate] (288.542 ms) : 0, 288542
AppSec [baseline] (50.469 ms) : 0, 50469
AppSec [candidate] (50.205 ms) : 0, 50205
IAST [baseline] (23.413 ms) : 0, 23413
IAST [candidate] (23.916 ms) : 0, 23916
Remote Config [baseline] (578.521 µs) : 0, 579
Remote Config [candidate] (562.103 µs) : 0, 562
Telemetry [baseline] (6.629 ms) : 0, 6629
Telemetry [candidate] (7.323 ms) : 0, 7323
section profiling
BytebuddyAgent [baseline] (679.057 ms) : 0, 679057
BytebuddyAgent [candidate] (684.17 ms) : 0, 684170
GlobalTracer [baseline] (380.799 ms) : 0, 380799
GlobalTracer [candidate] (383.426 ms) : 0, 383426
AppSec [baseline] (49.716 ms) : 0, 49716
AppSec [candidate] (50.381 ms) : 0, 50381
Remote Config [baseline] (722.859 µs) : 0, 723
Remote Config [candidate] (718.562 µs) : 0, 719
Telemetry [baseline] (7.518 ms) : 0, 7518
Telemetry [candidate] (7.596 ms) : 0, 7596
ProfilingAgent [baseline] (95.427 ms) : 0, 95427
ProfilingAgent [candidate] (96.404 ms) : 0, 96404
Profiling [baseline] (95.451 ms) : 0, 95451
Profiling [candidate] (96.428 ms) : 0, 96428

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-02T13:47:14 2024-05-02T13:54:05
git_branch master shurivich/consolidate_pii
git_commit_date 1714652169 1714656616
git_commit_sha 0b24171 6b184e6
release_version 1.34.0-SNAPSHOT~0b241711ac 1.34.0-SNAPSHOT~6b184e6e54
start_time 2024-05-02T13:47:01 2024-05-02T13:53:52
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714658393 1714658393
ci_job_id 502601986 502601986
ci_pipeline_id 33432097 33432097
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.077 µs) : 359, 397
.   : milestone, 378,
iast (478.304 µs) : 458, 499
.   : milestone, 478,
iast_FULL (545.348 µs) : 524, 567
.   : milestone, 545,
iast_GLOBAL (514.062 µs) : 491, 537
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (478.195 µs) : 458, 499
.   : milestone, 478,
iast_INACTIVE (459.097 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (467.59 µs) : 447, 489
.   : milestone, 468,
tracing (452.298 µs) : 432, 473
.   : milestone, 452,
section candidate
no_agent (367.227 µs) : 348, 387
.   : milestone, 367,
iast (479.006 µs) : 458, 500
.   : milestone, 479,
iast_FULL (542.22 µs) : 522, 563
.   : milestone, 542,
iast_GLOBAL (506.447 µs) : 486, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (483.989 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (454.93 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (475.897 µs) : 454, 497
.   : milestone, 476,
tracing (446.915 µs) : 426, 467
.   : milestone, 447,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.077 µs [358.692 µs, 397.462 µs] -
iast 478.304 µs [457.778 µs, 498.83 µs] 100.227 µs (26.5%)
iast_FULL 545.348 µs [523.843 µs, 566.852 µs] 167.271 µs (44.2%)
iast_GLOBAL 514.062 µs [490.805 µs, 537.319 µs] 135.985 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED 478.195 µs [457.669 µs, 498.721 µs] 100.117 µs (26.5%)
iast_INACTIVE 459.097 µs [438.118 µs, 480.076 µs] 81.02 µs (21.4%)
iast_TELEMETRY_OFF 467.59 µs [446.648 µs, 488.533 µs] 89.513 µs (23.7%)
tracing 452.298 µs [431.508 µs, 473.089 µs] 74.221 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.227 µs [347.508 µs, 386.947 µs] -
iast 479.006 µs [458.255 µs, 499.757 µs] 111.778 µs (30.4%)
iast_FULL 542.22 µs [521.582 µs, 562.859 µs] 174.993 µs (47.7%)
iast_GLOBAL 506.447 µs [485.647 µs, 527.246 µs] 139.219 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 483.989 µs [463.239 µs, 504.738 µs] 116.761 µs (31.8%)
iast_INACTIVE 454.93 µs [433.738 µs, 476.123 µs] 87.703 µs (23.9%)
iast_TELEMETRY_OFF 475.897 µs [454.399 µs, 497.396 µs] 108.67 µs (29.6%)
tracing 446.915 µs [426.374 µs, 467.455 µs] 79.687 µs (21.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1381
.   : milestone, 1362,
appsec (1.743 ms) : 1719, 1766
.   : milestone, 1743,
appsec_no_iast (1.747 ms) : 1723, 1771
.   : milestone, 1747,
iast (1.504 ms) : 1481, 1527
.   : milestone, 1504,
profiling (1.515 ms) : 1491, 1540
.   : milestone, 1515,
tracing (1.482 ms) : 1455, 1510
.   : milestone, 1482,
section candidate
no_agent (1.363 ms) : 1344, 1382
.   : milestone, 1363,
appsec (1.752 ms) : 1728, 1776
.   : milestone, 1752,
appsec_no_iast (1.734 ms) : 1709, 1759
.   : milestone, 1734,
iast (1.488 ms) : 1465, 1511
.   : milestone, 1488,
profiling (1.544 ms) : 1518, 1570
.   : milestone, 1544,
tracing (1.501 ms) : 1476, 1525
.   : milestone, 1501,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.381 ms] -
appsec 1.743 ms [1.719 ms, 1.766 ms] 380.963 µs (28.0%)
appsec_no_iast 1.747 ms [1.723 ms, 1.771 ms] 385.473 µs (28.3%)
iast 1.504 ms [1.481 ms, 1.527 ms] 142.572 µs (10.5%)
profiling 1.515 ms [1.491 ms, 1.54 ms] 153.469 µs (11.3%)
tracing 1.482 ms [1.455 ms, 1.51 ms] 120.841 µs (8.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.382 ms] -
appsec 1.752 ms [1.728 ms, 1.776 ms] 388.791 µs (28.5%)
appsec_no_iast 1.734 ms [1.709 ms, 1.759 ms] 370.758 µs (27.2%)
iast 1.488 ms [1.465 ms, 1.511 ms] 124.83 µs (9.2%)
profiling 1.544 ms [1.518 ms, 1.57 ms] 181.03 µs (13.3%)
tracing 1.501 ms [1.476 ms, 1.525 ms] 137.436 µs (10.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master shurivich/consolidate_pii
git_commit_date 1714652169 1714656616
git_commit_sha 0b24171 6b184e6
release_version 1.34.0-SNAPSHOT~0b241711ac 1.34.0-SNAPSHOT~6b184e6e54
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714658886 1714658886
ci_job_id 502601987 502601987
ci_pipeline_id 33432097 33432097
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.182 ms) : 2149, 2216
.   : milestone, 2182,
iast (1.868 ms) : 1833, 1903
.   : milestone, 1868,
iast_GLOBAL (1.912 ms) : 1877, 1948
.   : milestone, 1912,
profiling (1.85 ms) : 1816, 1884
.   : milestone, 1850,
tracing (1.829 ms) : 1797, 1861
.   : milestone, 1829,
section candidate
no_agent (1.455 ms) : 1444, 1466
.   : milestone, 1455,
appsec (2.197 ms) : 2163, 2231
.   : milestone, 2197,
iast (1.868 ms) : 1833, 1902
.   : milestone, 1868,
iast_GLOBAL (1.903 ms) : 1868, 1938
.   : milestone, 1903,
profiling (1.842 ms) : 1810, 1875
.   : milestone, 1842,
tracing (1.839 ms) : 1806, 1871
.   : milestone, 1839,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.182 ms [2.149 ms, 2.216 ms] 724.928 µs (49.7%)
iast 1.868 ms [1.833 ms, 1.903 ms] 410.513 µs (28.2%)
iast_GLOBAL 1.912 ms [1.877 ms, 1.948 ms] 454.996 µs (31.2%)
profiling 1.85 ms [1.816 ms, 1.884 ms] 393.023 µs (27.0%)
tracing 1.829 ms [1.797 ms, 1.861 ms] 371.499 µs (25.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.466 ms] -
appsec 2.197 ms [2.163 ms, 2.231 ms] 741.831 µs (51.0%)
iast 1.868 ms [1.833 ms, 1.902 ms] 412.561 µs (28.4%)
iast_GLOBAL 1.903 ms [1.868 ms, 1.938 ms] 448.016 µs (30.8%)
profiling 1.842 ms [1.81 ms, 1.875 ms] 387.048 µs (26.6%)
tracing 1.839 ms [1.806 ms, 1.871 ms] 383.6 µs (26.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~6b184e6e54, baseline=1.34.0-SNAPSHOT~0b241711ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.463 s) : 15463000, 15463000
.   : milestone, 15463000,
appsec (14.789 s) : 14789000, 14789000
.   : milestone, 14789000,
iast (18.44 s) : 18440000, 18440000
.   : milestone, 18440000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
.   : milestone, 17856000,
profiling (15.904 s) : 15904000, 15904000
.   : milestone, 15904000,
tracing (14.885 s) : 14885000, 14885000
.   : milestone, 14885000,
section candidate
no_agent (15.438 s) : 15438000, 15438000
.   : milestone, 15438000,
appsec (15.165 s) : 15165000, 15165000
.   : milestone, 15165000,
iast (18.579 s) : 18579000, 18579000
.   : milestone, 18579000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
.   : milestone, 17869000,
profiling (15.522 s) : 15522000, 15522000
.   : milestone, 15522000,
tracing (15.111 s) : 15111000, 15111000
.   : milestone, 15111000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.463 s [15.463 s, 15.463 s] -
appsec 14.789 s [14.789 s, 14.789 s] -674.0 ms (-4.4%)
iast 18.44 s [18.44 s, 18.44 s] 2.977 s (19.3%)
iast_GLOBAL 17.856 s [17.856 s, 17.856 s] 2.393 s (15.5%)
profiling 15.904 s [15.904 s, 15.904 s] 441.0 ms (2.9%)
tracing 14.885 s [14.885 s, 14.885 s] -578.0 ms (-3.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.438 s [15.438 s, 15.438 s] -
appsec 15.165 s [15.165 s, 15.165 s] -273.0 ms (-1.8%)
iast 18.579 s [18.579 s, 18.579 s] 3.141 s (20.3%)
iast_GLOBAL 17.869 s [17.869 s, 17.869 s] 2.431 s (15.7%)
profiling 15.522 s [15.522 s, 15.522 s] 84.0 ms (0.5%)
tracing 15.111 s [15.111 s, 15.111 s] -327.0 ms (-2.1%)

@shurivich shurivich merged commit 0059a39 into master May 6, 2024
80 checks passed
@shurivich shurivich deleted the shurivich/consolidate_pii branch May 6, 2024 08:13
@github-actions github-actions bot added this to the 1.34.0 milestone May 6, 2024
P403n1x87 pushed a commit to DataDog/dd-trace-py that referenced this pull request May 21, 2024
@shurivich
chore(debugger): consolidate pii redaction keys for all libraries (#9148
6e46390 
)

## Checklist
Consolidate PII redaction keys for all libraries.

## Notes
Related PRs:
`dotnet` - DataDog/dd-trace-dotnet#5522
`java` - DataDog/dd-trace-java#6980

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel left review comments

@cimi cimi cimi approved these changes

Assignees

@shurivich shurivich

Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shurivich @cimi @jpbempel