Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracer log file to tracer flare if datadog.slf4j.simpleLogger.logFile is defined #6999

Merged
merged 10 commits into from
May 17, 2024
Merged

Add tracer log file to tracer flare if datadog.slf4j.simpleLogger.logFile is defined #6999

merged 10 commits into from
May 17, 2024

Conversation

cecile75
Copy link
Collaborator

@cecile75 cecile75 commented May 7, 2024 •
edited
Loading

What Does This Do

This PR is a follow up of

This PR adds tracer log file to tracer flare, requested by the UI or by Triage mode:
if a tracer log file has been defined with datadog.slf4j.simpleLogger.logFile and if the size of the tracer log file is > 15MB:

  • extracts the beginning and end of the tracer log file (50/50) and writes 2 files "tracer_begin.log" and "tracer_end.log" in the tracer flare.

It's likely that the last line of "tracer_begin.log" and the first line of "tracer_end.log" will be incomplete. To only handling bytes in the java code, it will stay as it is but any tool to automatically analyze tracer debug log should discard the last line of "tracer_begin.log" and the first line of "tracer_end.log" are they are likely to be incomplete.

Motivation

Getting tracer logs in tracer flare to get as much information as possible to better troubleshoot issues

Additional Notes

Jira ticket: [APMAPI-59](https://datadoghq.atlassian.net/browse/APMAPI-59)

@pr-commenter
Copy link

pr-commenter bot commented May 7, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/tracer_debugfile_continue
git_commit_date 1715856651 1715870808
git_commit_sha d0bd085 a00b66f
release_version 1.35.0-SNAPSHOT~d0bd085303 1.35.0-SNAPSHOT~a00b66ff59
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715873576 1715873576
ci_job_id 514228304 514228304
ci_pipeline_id 34460503 34460503
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085597
Total [baseline] (8.56 s) : 0, 8560105
Agent [candidate] (1.077 s) : 0, 1076895
Total [candidate] (8.564 s) : 0, 8564475
section iast
Agent [baseline] (1.205 s) : 0, 1205324
Total [baseline] (9.017 s) : 0, 9017435
Agent [candidate] (1.204 s) : 0, 1203587
Total [candidate] (9.026 s) : 0, 9025938
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1202747
Total [baseline] (9.001 s) : 0, 9000788
Agent [candidate] (1.211 s) : 0, 1210909
Total [candidate] (9.002 s) : 0, 9001886
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1203327
Total [baseline] (9.039 s) : 0, 9038895
Agent [candidate] (1.198 s) : 0, 1197952
Total [candidate] (9.014 s) : 0, 9013900
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.205 s 119.727 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 117.149 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.203 s 117.73 ms (10.8%)
Total tracing 8.56 s -
Total iast 9.017 s 457.329 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.001 s 440.683 ms (5.1%)
Total iast_TELEMETRY_OFF 9.039 s 478.79 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.204 s 126.692 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.211 s 134.015 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.198 s 121.058 ms (11.2%)
Total tracing 8.564 s -
Total iast 9.026 s 461.463 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.002 s 437.411 ms (5.1%)
Total iast_TELEMETRY_OFF 9.014 s 449.425 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.43 ms) : 0, 680430
BytebuddyAgent [candidate] (673.702 ms) : 0, 673702
GlobalTracer [baseline] (312.598 ms) : 0, 312598
GlobalTracer [candidate] (310.814 ms) : 0, 310814
AppSec [baseline] (49.68 ms) : 0, 49680
AppSec [candidate] (49.775 ms) : 0, 49775
Remote Config [baseline] (658.776 µs) : 0, 659
Remote Config [candidate] (665.276 µs) : 0, 665
Telemetry [baseline] (7.593 ms) : 0, 7593
Telemetry [candidate] (7.575 ms) : 0, 7575
section iast
BytebuddyAgent [baseline] (798.018 ms) : 0, 798018
BytebuddyAgent [candidate] (796.567 ms) : 0, 796567
GlobalTracer [baseline] (291.548 ms) : 0, 291548
GlobalTracer [candidate] (291.135 ms) : 0, 291135
AppSec [baseline] (52.122 ms) : 0, 52122
AppSec [candidate] (49.979 ms) : 0, 49979
IAST [baseline] (22.006 ms) : 0, 22006
IAST [candidate] (24.482 ms) : 0, 24482
Remote Config [baseline] (612.726 µs) : 0, 613
Remote Config [candidate] (580.127 µs) : 0, 580
Telemetry [baseline] (6.641 ms) : 0, 6641
Telemetry [candidate] (6.587 ms) : 0, 6587
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.098 ms) : 0, 796098
BytebuddyAgent [candidate] (802.439 ms) : 0, 802439
GlobalTracer [baseline] (290.775 ms) : 0, 290775
GlobalTracer [candidate] (292.518 ms) : 0, 292518
AppSec [baseline] (51.387 ms) : 0, 51387
AppSec [candidate] (49.539 ms) : 0, 49539
IAST [baseline] (22.904 ms) : 0, 22904
IAST [candidate] (24.468 ms) : 0, 24468
Remote Config [baseline] (612.538 µs) : 0, 613
Remote Config [candidate] (649.732 µs) : 0, 650
Telemetry [baseline] (6.676 ms) : 0, 6676
Telemetry [candidate] (6.682 ms) : 0, 6682
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.861 ms) : 0, 795861
BytebuddyAgent [candidate] (791.291 ms) : 0, 791291
GlobalTracer [baseline] (291.765 ms) : 0, 291765
GlobalTracer [candidate] (290.466 ms) : 0, 290466
AppSec [baseline] (51.644 ms) : 0, 51644
AppSec [candidate] (51.878 ms) : 0, 51878
IAST [baseline] (21.78 ms) : 0, 21780
IAST [candidate] (22.871 ms) : 0, 22871
Remote Config [baseline] (611.977 µs) : 0, 612
Remote Config [candidate] (619.492 µs) : 0, 619
Telemetry [baseline] (7.237 ms) : 0, 7237
Telemetry [candidate] (6.559 ms) : 0, 6559
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076343
Total [baseline] (10.437 s) : 0, 10436681
Agent [candidate] (1.08 s) : 0, 1080248
Total [candidate] (10.401 s) : 0, 10401111
section appsec
Agent [baseline] (1.207 s) : 0, 1207494
Total [baseline] (10.552 s) : 0, 10552466
Agent [candidate] (1.198 s) : 0, 1198145
Total [candidate] (10.53 s) : 0, 10530155
section iast
Agent [baseline] (1.209 s) : 0, 1208648
Total [baseline] (10.745 s) : 0, 10744856
Agent [candidate] (1.208 s) : 0, 1208403
Total [candidate] (10.791 s) : 0, 10790586
section profiling
Agent [baseline] (1.272 s) : 0, 1272131
Total [baseline] (10.662 s) : 0, 10662340
Agent [candidate] (1.279 s) : 0, 1278650
Total [candidate] (10.619 s) : 0, 10618989
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.207 s 131.152 ms (12.2%)
Agent iast 1.209 s 132.306 ms (12.3%)
Agent profiling 1.272 s 195.788 ms (18.2%)
Total tracing 10.437 s -
Total appsec 10.552 s 115.785 ms (1.1%)
Total iast 10.745 s 308.174 ms (3.0%)
Total profiling 10.662 s 225.659 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.198 s 117.897 ms (10.9%)
Agent iast 1.208 s 128.155 ms (11.9%)
Agent profiling 1.279 s 198.402 ms (18.4%)
Total tracing 10.401 s -
Total appsec 10.53 s 129.045 ms (1.2%)
Total iast 10.791 s 389.475 ms (3.7%)
Total profiling 10.619 s 217.879 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.123 ms) : 0, 674123
BytebuddyAgent [candidate] (675.739 ms) : 0, 675739
GlobalTracer [baseline] (309.956 ms) : 0, 309956
GlobalTracer [candidate] (311.777 ms) : 0, 311777
AppSec [baseline] (49.697 ms) : 0, 49697
AppSec [candidate] (49.965 ms) : 0, 49965
Remote Config [baseline] (664.43 µs) : 0, 664
Remote Config [candidate] (665.848 µs) : 0, 666
Telemetry [baseline] (7.64 ms) : 0, 7640
Telemetry [candidate] (7.585 ms) : 0, 7585
section appsec
BytebuddyAgent [baseline] (704.017 ms) : 0, 704017
BytebuddyAgent [candidate] (697.949 ms) : 0, 697949
GlobalTracer [baseline] (296.476 ms) : 0, 296476
GlobalTracer [candidate] (294.565 ms) : 0, 294565
AppSec [baseline] (153.183 ms) : 0, 153183
AppSec [candidate] (152.808 ms) : 0, 152808
Remote Config [baseline] (625.559 µs) : 0, 626
Remote Config [candidate] (623.601 µs) : 0, 624
Telemetry [baseline] (8.852 ms) : 0, 8852
Telemetry [candidate] (8.199 ms) : 0, 8199
IAST [baseline] (19.063 ms) : 0, 19063
IAST [candidate] (19.054 ms) : 0, 19054
section iast
BytebuddyAgent [baseline] (799.731 ms) : 0, 799731
BytebuddyAgent [candidate] (799.811 ms) : 0, 799811
GlobalTracer [baseline] (292.16 ms) : 0, 292160
GlobalTracer [candidate] (291.873 ms) : 0, 291873
AppSec [baseline] (50.473 ms) : 0, 50473
AppSec [candidate] (50.485 ms) : 0, 50485
Remote Config [baseline] (616.671 µs) : 0, 617
Remote Config [candidate] (590.175 µs) : 0, 590
Telemetry [baseline] (6.616 ms) : 0, 6616
Telemetry [candidate] (8.137 ms) : 0, 8137
IAST [baseline] (24.594 ms) : 0, 24594
IAST [candidate] (23.0 ms) : 0, 23000
section profiling
ProfilingAgent [baseline] (95.986 ms) : 0, 95986
ProfilingAgent [candidate] (96.18 ms) : 0, 96180
BytebuddyAgent [baseline] (678.392 ms) : 0, 678392
BytebuddyAgent [candidate] (682.72 ms) : 0, 682720
GlobalTracer [baseline] (382.96 ms) : 0, 382960
GlobalTracer [candidate] (384.09 ms) : 0, 384090
AppSec [baseline] (50.139 ms) : 0, 50139
AppSec [candidate] (50.53 ms) : 0, 50530
Remote Config [baseline] (696.787 µs) : 0, 697
Remote Config [candidate] (708.943 µs) : 0, 709
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.539 ms) : 0, 7539
Profiling [baseline] (96.01 ms) : 0, 96010
Profiling [candidate] (96.204 ms) : 0, 96204
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-16T15:03:22 2024-05-16T15:10:09
git_branch master cecile/tracer_debugfile_continue
git_commit_date 1715856651 1715870808
git_commit_sha d0bd085 a00b66f
release_version 1.35.0-SNAPSHOT~d0bd085303 1.35.0-SNAPSHOT~a00b66ff59
start_time 2024-05-16T15:03:08 2024-05-16T15:09:56
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715872552 1715872552
ci_job_id 514228305 514228305
ci_pipeline_id 34460503 34460503
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.333 ms) : 1312, 1353
.   : milestone, 1333,
appsec (1.716 ms) : 1694, 1739
.   : milestone, 1716,
appsec_no_iast (1.669 ms) : 1645, 1693
.   : milestone, 1669,
iast (1.465 ms) : 1442, 1487
.   : milestone, 1465,
profiling (1.478 ms) : 1453, 1503
.   : milestone, 1478,
tracing (1.464 ms) : 1439, 1489
.   : milestone, 1464,
section candidate
no_agent (1.338 ms) : 1319, 1358
.   : milestone, 1338,
appsec (1.734 ms) : 1711, 1758
.   : milestone, 1734,
appsec_no_iast (1.72 ms) : 1696, 1744
.   : milestone, 1720,
iast (1.468 ms) : 1446, 1491
.   : milestone, 1468,
profiling (1.486 ms) : 1462, 1511
.   : milestone, 1486,
tracing (1.468 ms) : 1445, 1492
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.312 ms, 1.353 ms] -
appsec 1.716 ms [1.694 ms, 1.739 ms] 383.784 µs (28.8%)
appsec_no_iast 1.669 ms [1.645 ms, 1.693 ms] 336.404 µs (25.2%)
iast 1.465 ms [1.442 ms, 1.487 ms] 131.954 µs (9.9%)
profiling 1.478 ms [1.453 ms, 1.503 ms] 145.197 µs (10.9%)
tracing 1.464 ms [1.439 ms, 1.489 ms] 131.388 µs (9.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.358 ms] -
appsec 1.734 ms [1.711 ms, 1.758 ms] 395.955 µs (29.6%)
appsec_no_iast 1.72 ms [1.696 ms, 1.744 ms] 381.813 µs (28.5%)
iast 1.468 ms [1.446 ms, 1.491 ms] 129.739 µs (9.7%)
profiling 1.486 ms [1.462 ms, 1.511 ms] 147.784 µs (11.0%)
tracing 1.468 ms [1.445 ms, 1.492 ms] 129.824 µs (9.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.884 µs) : 348, 392
.   : milestone, 370,
iast (474.663 µs) : 454, 496
.   : milestone, 475,
iast_FULL (547.16 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (498.886 µs) : 478, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (481.191 µs) : 459, 504
.   : milestone, 481,
iast_INACTIVE (444.655 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (465.284 µs) : 445, 486
.   : milestone, 465,
tracing (440.898 µs) : 420, 462
.   : milestone, 441,
section candidate
no_agent (358.754 µs) : 339, 378
.   : milestone, 359,
iast (473.808 µs) : 453, 495
.   : milestone, 474,
iast_FULL (547.38 µs) : 526, 569
.   : milestone, 547,
iast_GLOBAL (505.574 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (475.78 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (446.72 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (466.223 µs) : 445, 487
.   : milestone, 466,
tracing (444.176 µs) : 423, 466
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.884 µs [347.949 µs, 391.819 µs] -
iast 474.663 µs [453.64 µs, 495.686 µs] 104.779 µs (28.3%)
iast_FULL 547.16 µs [525.945 µs, 568.375 µs] 177.276 µs (47.9%)
iast_GLOBAL 498.886 µs [478.223 µs, 519.55 µs] 129.002 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED 481.191 µs [458.756 µs, 503.627 µs] 111.307 µs (30.1%)
iast_INACTIVE 444.655 µs [423.767 µs, 465.543 µs] 74.771 µs (20.2%)
iast_TELEMETRY_OFF 465.284 µs [444.728 µs, 485.84 µs] 95.4 µs (25.8%)
tracing 440.898 µs [419.611 µs, 462.185 µs] 71.014 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.754 µs [339.085 µs, 378.423 µs] -
iast 473.808 µs [452.812 µs, 494.804 µs] 115.054 µs (32.1%)
iast_FULL 547.38 µs [525.647 µs, 569.112 µs] 188.626 µs (52.6%)
iast_GLOBAL 505.574 µs [484.524 µs, 526.623 µs] 146.82 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED 475.78 µs [454.924 µs, 496.635 µs] 117.026 µs (32.6%)
iast_INACTIVE 446.72 µs [425.635 µs, 467.805 µs] 87.967 µs (24.5%)
iast_TELEMETRY_OFF 466.223 µs [445.347 µs, 487.1 µs] 107.47 µs (30.0%)
tracing 444.176 µs [422.75 µs, 465.602 µs] 85.422 µs (23.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/tracer_debugfile_continue
git_commit_date 1715856651 1715870808
git_commit_sha d0bd085 a00b66f
release_version 1.35.0-SNAPSHOT~d0bd085303 1.35.0-SNAPSHOT~a00b66ff59
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715873102 1715873102
ci_job_id 514228306 514228306
ci_pipeline_id 34460503 34460503
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
appsec (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
iast (18.874 s) : 18874000, 18874000
.   : milestone, 18874000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
.   : milestone, 17883000,
profiling (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
tracing (14.804 s) : 14804000, 14804000
.   : milestone, 14804000,
section candidate
no_agent (14.918 s) : 14918000, 14918000
.   : milestone, 14918000,
appsec (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
iast (19.064 s) : 19064000, 19064000
.   : milestone, 19064000,
iast_GLOBAL (17.814 s) : 17814000, 17814000
.   : milestone, 17814000,
profiling (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
tracing (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.036 s [15.036 s, 15.036 s] -
appsec 15.022 s [15.022 s, 15.022 s] -14.0 ms (-0.1%)
iast 18.874 s [18.874 s, 18.874 s] 3.838 s (25.5%)
iast_GLOBAL 17.883 s [17.883 s, 17.883 s] 2.847 s (18.9%)
profiling 14.916 s [14.916 s, 14.916 s] -120.0 ms (-0.8%)
tracing 14.804 s [14.804 s, 14.804 s] -232.0 ms (-1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.918 s [14.918 s, 14.918 s] -
appsec 14.984 s [14.984 s, 14.984 s] 66.0 ms (0.4%)
iast 19.064 s [19.064 s, 19.064 s] 4.146 s (27.8%)
iast_GLOBAL 17.814 s [17.814 s, 17.814 s] 2.896 s (19.4%)
profiling 15.012 s [15.012 s, 15.012 s] 94.0 ms (0.6%)
tracing 14.957 s [14.957 s, 14.957 s] 39.0 ms (0.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~a00b66ff59, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1478
.   : milestone, 1467,
appsec (2.205 ms) : 2172, 2239
.   : milestone, 2205,
iast (1.964 ms) : 1923, 2005
.   : milestone, 1964,
iast_GLOBAL (2.0 ms) : 1959, 2041
.   : milestone, 2000,
profiling (1.855 ms) : 1821, 1889
.   : milestone, 1855,
tracing (1.835 ms) : 1802, 1867
.   : milestone, 1835,
section candidate
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.21 ms) : 2176, 2244
.   : milestone, 2210,
iast (1.964 ms) : 1923, 2005
.   : milestone, 1964,
iast_GLOBAL (1.984 ms) : 1943, 2024
.   : milestone, 1984,
profiling (1.84 ms) : 1808, 1872
.   : milestone, 1840,
tracing (1.837 ms) : 1805, 1869
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.478 ms] -
appsec 2.205 ms [2.172 ms, 2.239 ms] 738.454 µs (50.3%)
iast 1.964 ms [1.923 ms, 2.005 ms] 496.952 µs (33.9%)
iast_GLOBAL 2.0 ms [1.959 ms, 2.041 ms] 532.911 µs (36.3%)
profiling 1.855 ms [1.821 ms, 1.889 ms] 387.732 µs (26.4%)
tracing 1.835 ms [1.802 ms, 1.867 ms] 367.827 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.21 ms [2.176 ms, 2.244 ms] 750.003 µs (51.4%)
iast 1.964 ms [1.923 ms, 2.005 ms] 503.787 µs (34.5%)
iast_GLOBAL 1.984 ms [1.943 ms, 2.024 ms] 523.403 µs (35.8%)
profiling 1.84 ms [1.808 ms, 1.872 ms] 379.627 µs (26.0%)
tracing 1.837 ms [1.805 ms, 1.869 ms] 376.746 µs (25.8%)

Base automatically changed from cecile/tracer_debugfile to master May 13, 2024 09:38
@cecile75 cecile75 marked this pull request as ready for review May 15, 2024 09:44
@cecile75 cecile75 requested a review from a team as a code owner May 15, 2024 09:44
@cecile75 cecile75 requested a review from mcculls May 17, 2024 12:59
@cecile75 cecile75 merged commit 97c73dd into master May 17, 2024
80 checks passed
@cecile75 cecile75 deleted the cecile/tracer_debugfile_continue branch May 17, 2024 13:23
@github-actions github-actions bot added this to the 1.35.0 milestone May 17, 2024
@amarziali amarziali added the comp: core Tracer core label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@dougqh dougqh dougqh approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cecile75 @mcculls @dougqh @amarziali