Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always collect accept, content-type and user-agent when appsec is enabled #7009

Merged
merged 1 commit into from
May 13, 2024
Merged

Always collect accept, content-type and user-agent when appsec is enabled #7009

merged 1 commit into from
May 13, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented May 9, 2024 •
edited by jira bot
Loading

What Does This Do

Always collects Accept, Content-Type and User-Agent when appsec is enabled

Motivation

Additional Notes

Jira ticket: APPSEC-52885

@manuel-alvarez-alvarez manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label May 9, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 9, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/asm-default-header-collection
git_commit_date 1715593107 1715593207
git_commit_sha 0946fa5 5d13bee
release_version 1.35.0-SNAPSHOT~0946fa5eba 1.35.0-SNAPSHOT~5d13bee2a5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715595948 1715595948
ci_job_id 509770099 509770099
ci_pipeline_id 34118390 34118390
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079322
Total [baseline] (10.418 s) : 0, 10417647
Agent [candidate] (1.08 s) : 0, 1080047
Total [candidate] (10.488 s) : 0, 10487662
section appsec
Agent [baseline] (1.199 s) : 0, 1199472
Total [baseline] (10.461 s) : 0, 10461126
Agent [candidate] (1.201 s) : 0, 1200804
Total [candidate] (10.491 s) : 0, 10490819
section iast
Agent [baseline] (1.221 s) : 0, 1220935
Total [baseline] (10.778 s) : 0, 10777718
Agent [candidate] (1.203 s) : 0, 1203398
Total [candidate] (10.767 s) : 0, 10767405
section profiling
Agent [baseline] (1.288 s) : 0, 1288172
Total [baseline] (10.685 s) : 0, 10684602
Agent [candidate] (1.282 s) : 0, 1282257
Total [candidate] (10.624 s) : 0, 10623836
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.199 s 120.15 ms (11.1%)
Agent iast 1.221 s 141.614 ms (13.1%)
Agent profiling 1.288 s 208.851 ms (19.4%)
Total tracing 10.418 s -
Total appsec 10.461 s 43.48 ms (0.4%)
Total iast 10.778 s 360.072 ms (3.5%)
Total profiling 10.685 s 266.955 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.201 s 120.758 ms (11.2%)
Agent iast 1.203 s 123.352 ms (11.4%)
Agent profiling 1.282 s 202.211 ms (18.7%)
Total tracing 10.488 s -
Total appsec 10.491 s 3.156 ms (0.0%)
Total iast 10.767 s 279.743 ms (2.7%)
Total profiling 10.624 s 136.173 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.513 ms) : 0, 675513
BytebuddyAgent [candidate] (675.794 ms) : 0, 675794
GlobalTracer [baseline] (311.745 ms) : 0, 311745
GlobalTracer [candidate] (311.601 ms) : 0, 311601
AppSec [baseline] (49.49 ms) : 0, 49490
AppSec [candidate] (49.903 ms) : 0, 49903
Remote Config [baseline] (659.252 µs) : 0, 659
Remote Config [candidate] (666.151 µs) : 0, 666
Telemetry [baseline] (7.585 ms) : 0, 7585
Telemetry [candidate] (7.67 ms) : 0, 7670
section appsec
BytebuddyAgent [baseline] (698.627 ms) : 0, 698627
BytebuddyAgent [candidate] (699.723 ms) : 0, 699723
GlobalTracer [baseline] (294.528 ms) : 0, 294528
GlobalTracer [candidate] (295.053 ms) : 0, 295053
AppSec [baseline] (152.697 ms) : 0, 152697
AppSec [candidate] (152.966 ms) : 0, 152966
IAST [baseline] (19.428 ms) : 0, 19428
IAST [candidate] (19.339 ms) : 0, 19339
Remote Config [baseline] (618.688 µs) : 0, 619
Remote Config [candidate] (619.465 µs) : 0, 619
Telemetry [baseline] (8.796 ms) : 0, 8796
Telemetry [candidate] (8.207 ms) : 0, 8207
section iast
BytebuddyAgent [baseline] (807.724 ms) : 0, 807724
BytebuddyAgent [candidate] (795.059 ms) : 0, 795059
GlobalTracer [baseline] (295.361 ms) : 0, 295361
GlobalTracer [candidate] (291.448 ms) : 0, 291448
AppSec [baseline] (49.172 ms) : 0, 49172
AppSec [candidate] (50.388 ms) : 0, 50388
IAST [baseline] (24.907 ms) : 0, 24907
IAST [candidate] (24.183 ms) : 0, 24183
Remote Config [baseline] (1.409 ms) : 0, 1409
Remote Config [candidate] (1.304 ms) : 0, 1304
Telemetry [baseline] (7.509 ms) : 0, 7509
Telemetry [candidate] (6.614 ms) : 0, 6614
section profiling
BytebuddyAgent [baseline] (688.148 ms) : 0, 688148
BytebuddyAgent [candidate] (684.69 ms) : 0, 684690
GlobalTracer [baseline] (386.177 ms) : 0, 386177
GlobalTracer [candidate] (385.169 ms) : 0, 385169
AppSec [baseline] (51.114 ms) : 0, 51114
AppSec [candidate] (50.732 ms) : 0, 50732
Remote Config [baseline] (724.241 µs) : 0, 724
Remote Config [candidate] (711.836 µs) : 0, 712
Telemetry [baseline] (7.6 ms) : 0, 7600
Telemetry [candidate] (7.51 ms) : 0, 7510
ProfilingAgent [baseline] (97.063 ms) : 0, 97063
ProfilingAgent [candidate] (96.503 ms) : 0, 96503
Profiling [baseline] (97.087 ms) : 0, 97087
Profiling [candidate] (96.527 ms) : 0, 96527
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086482
Total [baseline] (8.561 s) : 0, 8560872
Agent [candidate] (1.076 s) : 0, 1076417
Total [candidate] (8.538 s) : 0, 8538411
section iast
Agent [baseline] (1.201 s) : 0, 1200649
Total [baseline] (9.05 s) : 0, 9049623
Agent [candidate] (1.205 s) : 0, 1204568
Total [candidate] (9.024 s) : 0, 9023754
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1201880
Total [baseline] (8.986 s) : 0, 8985972
Agent [candidate] (1.203 s) : 0, 1202899
Total [candidate] (9.006 s) : 0, 9006388
section iast_TELEMETRY_OFF
Agent [baseline] (1.208 s) : 0, 1208404
Total [baseline] (8.978 s) : 0, 8978067
Agent [candidate] (1.207 s) : 0, 1206957
Total [candidate] (9.021 s) : 0, 9021158
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.201 s 114.166 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 115.397 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.208 s 121.921 ms (11.2%)
Total tracing 8.561 s -
Total iast 9.05 s 488.751 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.986 s 425.1 ms (5.0%)
Total iast_TELEMETRY_OFF 8.978 s 417.195 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.205 s 128.151 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 126.483 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.207 s 130.54 ms (12.1%)
Total tracing 8.538 s -
Total iast 9.024 s 485.343 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.006 s 467.977 ms (5.5%)
Total iast_TELEMETRY_OFF 9.021 s 482.747 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.892 ms) : 0, 679892
BytebuddyAgent [candidate] (673.86 ms) : 0, 673860
GlobalTracer [baseline] (314.015 ms) : 0, 314015
GlobalTracer [candidate] (310.67 ms) : 0, 310670
AppSec [baseline] (49.841 ms) : 0, 49841
AppSec [candidate] (49.401 ms) : 0, 49401
Remote Config [baseline] (667.295 µs) : 0, 667
Remote Config [candidate] (650.852 µs) : 0, 651
Telemetry [baseline] (7.585 ms) : 0, 7585
Telemetry [candidate] (7.519 ms) : 0, 7519
section iast
BytebuddyAgent [baseline] (793.666 ms) : 0, 793666
BytebuddyAgent [candidate] (796.025 ms) : 0, 796025
GlobalTracer [baseline] (290.818 ms) : 0, 290818
GlobalTracer [candidate] (291.939 ms) : 0, 291939
AppSec [baseline] (52.031 ms) : 0, 52031
AppSec [candidate] (50.62 ms) : 0, 50620
IAST [baseline] (22.589 ms) : 0, 22589
IAST [candidate] (23.562 ms) : 0, 23562
Remote Config [baseline] (652.495 µs) : 0, 652
Remote Config [candidate] (1.344 ms) : 0, 1344
Telemetry [baseline] (6.618 ms) : 0, 6618
Telemetry [candidate] (6.655 ms) : 0, 6655
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.402 ms) : 0, 794402
BytebuddyAgent [candidate] (794.826 ms) : 0, 794826
GlobalTracer [baseline] (291.367 ms) : 0, 291367
GlobalTracer [candidate] (291.536 ms) : 0, 291536
AppSec [baseline] (51.092 ms) : 0, 51092
AppSec [candidate] (52.494 ms) : 0, 52494
IAST [baseline] (23.487 ms) : 0, 23487
IAST [candidate] (22.481 ms) : 0, 22481
Remote Config [baseline] (621.592 µs) : 0, 622
Remote Config [candidate] (591.71 µs) : 0, 592
Telemetry [baseline] (6.598 ms) : 0, 6598
Telemetry [candidate] (6.589 ms) : 0, 6589
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.946 ms) : 0, 797946
BytebuddyAgent [candidate] (796.821 ms) : 0, 796821
GlobalTracer [baseline] (292.768 ms) : 0, 292768
GlobalTracer [candidate] (292.745 ms) : 0, 292745
AppSec [baseline] (50.048 ms) : 0, 50048
AppSec [candidate] (51.789 ms) : 0, 51789
IAST [baseline] (25.104 ms) : 0, 25104
IAST [candidate] (23.917 ms) : 0, 23917
Remote Config [baseline] (623.326 µs) : 0, 623
Remote Config [candidate] (599.604 µs) : 0, 600
Telemetry [baseline] (7.315 ms) : 0, 7315
Telemetry [candidate] (6.512 ms) : 0, 6512
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-13T09:56:38 2024-05-13T10:03:25
git_branch master malvarez/asm-default-header-collection
git_commit_date 1715593107 1715593207
git_commit_sha 0946fa5 5d13bee
release_version 1.35.0-SNAPSHOT~0946fa5eba 1.35.0-SNAPSHOT~5d13bee2a5
start_time 2024-05-13T09:56:25 2024-05-13T10:03:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715594949 1715594949
ci_job_id 509770100 509770100
ci_pipeline_id 34118390 34118390
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+30.208µs; +84.037µs] or [+2.034%; +5.657%]		 unstable
[-635.466op/s; +389.312op/s] or [-19.858%; +12.166%]		 1.543ms 3076.923op/s 1.485ms 3200.000op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.705 µs) : 346, 385
.   : milestone, 366,
iast (483.301 µs) : 463, 504
.   : milestone, 483,
iast_FULL (534.231 µs) : 514, 555
.   : milestone, 534,
iast_GLOBAL (490.27 µs) : 470, 511
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (476.383 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (449.927 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (467.468 µs) : 446, 489
.   : milestone, 467,
tracing (442.639 µs) : 422, 463
.   : milestone, 443,
section candidate
no_agent (375.654 µs) : 356, 395
.   : milestone, 376,
iast (475.195 µs) : 455, 496
.   : milestone, 475,
iast_FULL (538.587 µs) : 518, 559
.   : milestone, 539,
iast_GLOBAL (497.906 µs) : 477, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (471.769 µs) : 451, 493
.   : milestone, 472,
iast_INACTIVE (451.168 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (471.145 µs) : 450, 492
.   : milestone, 471,
tracing (446.887 µs) : 426, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.705 µs [346.196 µs, 385.213 µs] -
iast 483.301 µs [462.863 µs, 503.739 µs] 117.596 µs (32.2%)
iast_FULL 534.231 µs [513.649 µs, 554.814 µs] 168.527 µs (46.1%)
iast_GLOBAL 490.27 µs [469.783 µs, 510.757 µs] 124.566 µs (34.1%)
iast_HARDCODED_SECRET_DISABLED 476.383 µs [455.392 µs, 497.374 µs] 110.678 µs (30.3%)
iast_INACTIVE 449.927 µs [428.851 µs, 471.004 µs] 84.223 µs (23.0%)
iast_TELEMETRY_OFF 467.468 µs [446.401 µs, 488.535 µs] 101.764 µs (27.8%)
tracing 442.639 µs [422.237 µs, 463.042 µs] 76.935 µs (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.654 µs [356.134 µs, 395.174 µs] -
iast 475.195 µs [454.745 µs, 495.645 µs] 99.542 µs (26.5%)
iast_FULL 538.587 µs [517.855 µs, 559.32 µs] 162.934 µs (43.4%)
iast_GLOBAL 497.906 µs [477.18 µs, 518.631 µs] 122.252 µs (32.5%)
iast_HARDCODED_SECRET_DISABLED 471.769 µs [450.996 µs, 492.542 µs] 96.115 µs (25.6%)
iast_INACTIVE 451.168 µs [430.642 µs, 471.694 µs] 75.514 µs (20.1%)
iast_TELEMETRY_OFF 471.145 µs [449.805 µs, 492.486 µs] 95.492 µs (25.4%)
tracing 446.887 µs [426.039 µs, 467.734 µs] 71.233 µs (19.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.693 ms) : 1668, 1717
.   : milestone, 1693,
appsec_no_iast (1.705 ms) : 1681, 1729
.   : milestone, 1705,
iast (1.474 ms) : 1451, 1497
.   : milestone, 1474,
profiling (1.485 ms) : 1461, 1510
.   : milestone, 1485,
tracing (1.476 ms) : 1453, 1500
.   : milestone, 1476,
section candidate
no_agent (1.342 ms) : 1323, 1362
.   : milestone, 1342,
appsec (1.715 ms) : 1692, 1738
.   : milestone, 1715,
appsec_no_iast (1.711 ms) : 1686, 1735
.   : milestone, 1711,
iast (1.472 ms) : 1449, 1495
.   : milestone, 1472,
profiling (1.543 ms) : 1517, 1568
.   : milestone, 1543,
tracing (1.461 ms) : 1437, 1485
.   : milestone, 1461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.337 ms, 1.375 ms] -
appsec 1.693 ms [1.668 ms, 1.717 ms] 336.761 µs (24.8%)
appsec_no_iast 1.705 ms [1.681 ms, 1.729 ms] 349.126 µs (25.7%)
iast 1.474 ms [1.451 ms, 1.497 ms] 118.171 µs (8.7%)
profiling 1.485 ms [1.461 ms, 1.51 ms] 129.473 µs (9.5%)
tracing 1.476 ms [1.453 ms, 1.5 ms] 120.494 µs (8.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.362 ms] -
appsec 1.715 ms [1.692 ms, 1.738 ms] 372.734 µs (27.8%)
appsec_no_iast 1.711 ms [1.686 ms, 1.735 ms] 368.205 µs (27.4%)
iast 1.472 ms [1.449 ms, 1.495 ms] 129.308 µs (9.6%)
profiling 1.543 ms [1.517 ms, 1.568 ms] 200.07 µs (14.9%)
tracing 1.461 ms [1.437 ms, 1.485 ms] 118.454 µs (8.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/asm-default-header-collection
git_commit_date 1715593107 1715593207
git_commit_sha 0946fa5 5d13bee
release_version 1.35.0-SNAPSHOT~0946fa5eba 1.35.0-SNAPSHOT~5d13bee2a5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715595448 1715595448
ci_job_id 509770101 509770101
ci_pipeline_id 34118390 34118390
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.34 s) : 15340000, 15340000
.   : milestone, 15340000,
appsec (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
iast (18.779 s) : 18779000, 18779000
.   : milestone, 18779000,
iast_GLOBAL (17.718 s) : 17718000, 17718000
.   : milestone, 17718000,
profiling (14.843 s) : 14843000, 14843000
.   : milestone, 14843000,
tracing (15.558 s) : 15558000, 15558000
.   : milestone, 15558000,
section candidate
no_agent (15.007 s) : 15007000, 15007000
.   : milestone, 15007000,
appsec (15.271 s) : 15271000, 15271000
.   : milestone, 15271000,
iast (18.571 s) : 18571000, 18571000
.   : milestone, 18571000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
.   : milestone, 17995000,
profiling (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
tracing (15.007 s) : 15007000, 15007000
.   : milestone, 15007000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.34 s [15.34 s, 15.34 s] -
appsec 15.009 s [15.009 s, 15.009 s] -331.0 ms (-2.2%)
iast 18.779 s [18.779 s, 18.779 s] 3.439 s (22.4%)
iast_GLOBAL 17.718 s [17.718 s, 17.718 s] 2.378 s (15.5%)
profiling 14.843 s [14.843 s, 14.843 s] -497.0 ms (-3.2%)
tracing 15.558 s [15.558 s, 15.558 s] 218.0 ms (1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.007 s [15.007 s, 15.007 s] -
appsec 15.271 s [15.271 s, 15.271 s] 264.0 ms (1.8%)
iast 18.571 s [18.571 s, 18.571 s] 3.564 s (23.7%)
iast_GLOBAL 17.995 s [17.995 s, 17.995 s] 2.988 s (19.9%)
profiling 15.279 s [15.279 s, 15.279 s] 272.0 ms (1.8%)
tracing 15.007 s [15.007 s, 15.007 s] 0.0 µs (0.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~5d13bee2a5, baseline=1.35.0-SNAPSHOT~0946fa5eba
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.195 ms) : 2161, 2229
.   : milestone, 2195,
iast (1.876 ms) : 1841, 1911
.   : milestone, 1876,
iast_GLOBAL (1.908 ms) : 1873, 1944
.   : milestone, 1908,
profiling (1.846 ms) : 1813, 1879
.   : milestone, 1846,
tracing (1.828 ms) : 1796, 1861
.   : milestone, 1828,
section candidate
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.191 ms) : 2157, 2225
.   : milestone, 2191,
iast (1.866 ms) : 1832, 1901
.   : milestone, 1866,
iast_GLOBAL (1.916 ms) : 1881, 1952
.   : milestone, 1916,
profiling (1.834 ms) : 1802, 1867
.   : milestone, 1834,
tracing (1.822 ms) : 1790, 1853
.   : milestone, 1822,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.195 ms [2.161 ms, 2.229 ms] 731.009 µs (49.9%)
iast 1.876 ms [1.841 ms, 1.911 ms] 412.24 µs (28.2%)
iast_GLOBAL 1.908 ms [1.873 ms, 1.944 ms] 444.197 µs (30.3%)
profiling 1.846 ms [1.813 ms, 1.879 ms] 381.798 µs (26.1%)
tracing 1.828 ms [1.796 ms, 1.861 ms] 364.397 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.191 ms [2.157 ms, 2.225 ms] 727.228 µs (49.7%)
iast 1.866 ms [1.832 ms, 1.901 ms] 402.732 µs (27.5%)
iast_GLOBAL 1.916 ms [1.881 ms, 1.952 ms] 452.671 µs (30.9%)
profiling 1.834 ms [1.802 ms, 1.867 ms] 371.01 µs (25.4%)
tracing 1.822 ms [1.79 ms, 1.853 ms] 358.153 µs (24.5%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-default-header-collection branch from a78d34c to 20660ea Compare May 10, 2024 07:22
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review May 10, 2024 07:22
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner May 10, 2024 07:22
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-default-header-collection branch from 20660ea to 2f79a56 Compare May 13, 2024 08:49
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-default-header-collection branch from 2f79a56 to 5d13bee Compare May 13, 2024 09:40
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit f6f57a6 into master May 13, 2024
78 of 79 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/asm-default-header-collection branch May 13, 2024 10:43
@github-actions github-actions bot added this to the 1.35.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF)
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuel-alvarez-alvarez @smola