Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect common WAF request header values by default #7010

Merged
merged 1 commit into from
May 13, 2024
Merged

Collect common WAF request header values by default #7010

merged 1 commit into from
May 13, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented May 9, 2024 •
edited by jira bot
Loading

What Does This Do

Collect common WAF request header values by default

Motivation

https://docs.google.com/document/d/1xf-s6PtSr6heZxmO_QLUtcFzY_X_rT94lRXNq6-Ghws/edit

Additional Notes

Jira ticket: APPSEC-51375

@manuel-alvarez-alvarez manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label May 9, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 9, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/asm-extra-header-collection
git_commit_date 1715597003 1715597342
git_commit_sha f6f57a6 4f60289
release_version 1.35.0-SNAPSHOT~f6f57a6190 1.35.0-SNAPSHOT~4f60289bc2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715599925 1715599925
ci_job_id 509848995 509848995
ci_pipeline_id 34124382 34124382
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076682
Total [baseline] (8.57 s) : 0, 8569507
Agent [candidate] (1.086 s) : 0, 1086072
Total [candidate] (8.561 s) : 0, 8561056
section iast
Agent [baseline] (1.203 s) : 0, 1202684
Total [baseline] (9.034 s) : 0, 9034208
Agent [candidate] (1.212 s) : 0, 1212260
Total [candidate] (9.033 s) : 0, 9033443
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1203060
Total [baseline] (8.996 s) : 0, 8996228
Agent [candidate] (1.212 s) : 0, 1211743
Total [candidate] (9.004 s) : 0, 9004212
section iast_TELEMETRY_OFF
Agent [baseline] (1.208 s) : 0, 1207555
Total [baseline] (9.028 s) : 0, 9028345
Agent [candidate] (1.203 s) : 0, 1202839
Total [candidate] (9.076 s) : 0, 9075968
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.203 s 126.002 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 126.378 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.208 s 130.873 ms (12.2%)
Total tracing 8.57 s -
Total iast 9.034 s 464.701 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.996 s 426.72 ms (5.0%)
Total iast_TELEMETRY_OFF 9.028 s 458.837 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.212 s 126.188 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.212 s 125.671 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.203 s 116.768 ms (10.8%)
Total tracing 8.561 s -
Total iast 9.033 s 472.387 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.004 s 443.155 ms (5.2%)
Total iast_TELEMETRY_OFF 9.076 s 514.912 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.649 ms) : 0, 673649
BytebuddyAgent [candidate] (679.911 ms) : 0, 679911
GlobalTracer [baseline] (311.129 ms) : 0, 311129
GlobalTracer [candidate] (313.458 ms) : 0, 313458
AppSec [baseline] (49.402 ms) : 0, 49402
AppSec [candidate] (49.754 ms) : 0, 49754
Remote Config [baseline] (659.451 µs) : 0, 659
Remote Config [candidate] (655.726 µs) : 0, 656
Telemetry [baseline] (7.533 ms) : 0, 7533
Telemetry [candidate] (7.63 ms) : 0, 7630
section iast
BytebuddyAgent [baseline] (794.904 ms) : 0, 794904
BytebuddyAgent [candidate] (801.723 ms) : 0, 801723
GlobalTracer [baseline] (291.362 ms) : 0, 291362
GlobalTracer [candidate] (293.134 ms) : 0, 293134
AppSec [baseline] (51.539 ms) : 0, 51539
AppSec [candidate] (49.467 ms) : 0, 49467
Remote Config [baseline] (596.327 µs) : 0, 596
Remote Config [candidate] (1.371 ms) : 0, 1371
Telemetry [baseline] (6.642 ms) : 0, 6642
Telemetry [candidate] (6.639 ms) : 0, 6639
IAST [baseline] (23.219 ms) : 0, 23219
IAST [candidate] (25.183 ms) : 0, 25183
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.417 ms) : 0, 794417
BytebuddyAgent [candidate] (801.107 ms) : 0, 801107
GlobalTracer [baseline] (291.019 ms) : 0, 291019
GlobalTracer [candidate] (293.467 ms) : 0, 293467
AppSec [baseline] (53.852 ms) : 0, 53852
AppSec [candidate] (50.7 ms) : 0, 50700
Remote Config [baseline] (613.053 µs) : 0, 613
Remote Config [candidate] (599.93 µs) : 0, 600
Telemetry [baseline] (6.778 ms) : 0, 6778
Telemetry [candidate] (6.653 ms) : 0, 6653
IAST [baseline] (22.018 ms) : 0, 22018
IAST [candidate] (24.566 ms) : 0, 24566
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.317 ms) : 0, 797317
BytebuddyAgent [candidate] (793.584 ms) : 0, 793584
GlobalTracer [baseline] (292.756 ms) : 0, 292756
GlobalTracer [candidate] (291.918 ms) : 0, 291918
AppSec [baseline] (50.837 ms) : 0, 50837
AppSec [candidate] (50.024 ms) : 0, 50024
Remote Config [baseline] (602.857 µs) : 0, 603
Remote Config [candidate] (593.54 µs) : 0, 594
Telemetry [baseline] (7.409 ms) : 0, 7409
Telemetry [candidate] (7.299 ms) : 0, 7299
IAST [baseline] (24.097 ms) : 0, 24097
IAST [candidate] (25.047 ms) : 0, 25047
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080009
Total [baseline] (10.429 s) : 0, 10428609
Agent [candidate] (1.077 s) : 0, 1077057
Total [candidate] (10.366 s) : 0, 10365998
section appsec
Agent [baseline] (1.203 s) : 0, 1202925
Total [baseline] (10.502 s) : 0, 10501646
Agent [candidate] (1.205 s) : 0, 1205364
Total [candidate] (10.494 s) : 0, 10494193
section iast
Agent [baseline] (1.211 s) : 0, 1211439
Total [baseline] (10.763 s) : 0, 10762570
Agent [candidate] (1.21 s) : 0, 1210158
Total [candidate] (10.901 s) : 0, 10901364
section profiling
Agent [baseline] (1.27 s) : 0, 1269787
Total [baseline] (10.653 s) : 0, 10652683
Agent [candidate] (1.279 s) : 0, 1278790
Total [candidate] (10.645 s) : 0, 10644932
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.203 s 122.916 ms (11.4%)
Agent iast 1.211 s 131.43 ms (12.2%)
Agent profiling 1.27 s 189.778 ms (17.6%)
Total tracing 10.429 s -
Total appsec 10.502 s 73.037 ms (0.7%)
Total iast 10.763 s 333.962 ms (3.2%)
Total profiling 10.653 s 224.074 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.205 s 128.307 ms (11.9%)
Agent iast 1.21 s 133.101 ms (12.4%)
Agent profiling 1.279 s 201.733 ms (18.7%)
Total tracing 10.366 s -
Total appsec 10.494 s 128.195 ms (1.2%)
Total iast 10.901 s 535.367 ms (5.2%)
Total profiling 10.645 s 278.934 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.398 ms) : 0, 675398
BytebuddyAgent [candidate] (674.258 ms) : 0, 674258
GlobalTracer [baseline] (312.011 ms) : 0, 312011
GlobalTracer [candidate] (310.823 ms) : 0, 310823
AppSec [baseline] (49.872 ms) : 0, 49872
AppSec [candidate] (49.433 ms) : 0, 49433
Remote Config [baseline] (666.68 µs) : 0, 667
Remote Config [candidate] (653.63 µs) : 0, 654
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.55 ms) : 0, 7550
section appsec
BytebuddyAgent [baseline] (700.845 ms) : 0, 700845
BytebuddyAgent [candidate] (702.107 ms) : 0, 702107
GlobalTracer [baseline] (295.325 ms) : 0, 295325
GlobalTracer [candidate] (295.885 ms) : 0, 295885
AppSec [baseline] (153.241 ms) : 0, 153241
AppSec [candidate] (153.15 ms) : 0, 153150
Remote Config [baseline] (620.901 µs) : 0, 621
Remote Config [candidate] (620.957 µs) : 0, 621
Telemetry [baseline] (8.498 ms) : 0, 8498
Telemetry [candidate] (9.207 ms) : 0, 9207
IAST [baseline] (19.553 ms) : 0, 19553
IAST [candidate] (19.536 ms) : 0, 19536
section iast
BytebuddyAgent [baseline] (801.548 ms) : 0, 801548
BytebuddyAgent [candidate] (799.862 ms) : 0, 799862
GlobalTracer [baseline] (293.021 ms) : 0, 293021
GlobalTracer [candidate] (292.935 ms) : 0, 292935
AppSec [baseline] (49.899 ms) : 0, 49899
AppSec [candidate] (50.635 ms) : 0, 50635
Remote Config [baseline] (651.201 µs) : 0, 651
Remote Config [candidate] (1.391 ms) : 0, 1391
Telemetry [baseline] (6.607 ms) : 0, 6607
Telemetry [candidate] (6.6 ms) : 0, 6600
IAST [baseline] (25.08 ms) : 0, 25080
IAST [candidate] (24.153 ms) : 0, 24153
section profiling
BytebuddyAgent [baseline] (677.682 ms) : 0, 677682
BytebuddyAgent [candidate] (683.225 ms) : 0, 683225
GlobalTracer [baseline] (381.196 ms) : 0, 381196
GlobalTracer [candidate] (383.823 ms) : 0, 383823
AppSec [baseline] (50.306 ms) : 0, 50306
AppSec [candidate] (50.771 ms) : 0, 50771
Remote Config [baseline] (710.602 µs) : 0, 711
Remote Config [candidate] (720.383 µs) : 0, 720
Telemetry [baseline] (7.521 ms) : 0, 7521
Telemetry [candidate] (7.568 ms) : 0, 7568
ProfilingAgent [baseline] (95.994 ms) : 0, 95994
ProfilingAgent [candidate] (95.768 ms) : 0, 95768
Profiling [baseline] (96.018 ms) : 0, 96018
Profiling [candidate] (95.792 ms) : 0, 95792
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-13T11:04:50 2024-05-13T11:11:35
git_branch master malvarez/asm-extra-header-collection
git_commit_date 1715597003 1715597342
git_commit_sha f6f57a6 4f60289
release_version 1.35.0-SNAPSHOT~f6f57a6190 1.35.0-SNAPSHOT~4f60289bc2
start_time 2024-05-13T11:04:37 2024-05-13T11:11:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715599037 1715599037
ci_job_id 509848997 509848997
ci_pipeline_id 34124382 34124382
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.882 µs) : 347, 387
.   : milestone, 367,
iast (470.068 µs) : 449, 491
.   : milestone, 470,
iast_FULL (530.209 µs) : 509, 551
.   : milestone, 530,
iast_GLOBAL (487.486 µs) : 467, 508
.   : milestone, 487,
iast_HARDCODED_SECRET_DISABLED (465.617 µs) : 445, 486
.   : milestone, 466,
iast_INACTIVE (442.733 µs) : 421, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (471.979 µs) : 450, 494
.   : milestone, 472,
tracing (438.866 µs) : 418, 460
.   : milestone, 439,
section candidate
no_agent (369.117 µs) : 349, 389
.   : milestone, 369,
iast (464.03 µs) : 443, 485
.   : milestone, 464,
iast_FULL (533.223 µs) : 513, 554
.   : milestone, 533,
iast_GLOBAL (488.65 µs) : 467, 510
.   : milestone, 489,
iast_HARDCODED_SECRET_DISABLED (463.078 µs) : 443, 483
.   : milestone, 463,
iast_INACTIVE (452.492 µs) : 432, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (465.045 µs) : 443, 487
.   : milestone, 465,
tracing (435.11 µs) : 415, 456
.   : milestone, 435,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.882 µs [346.587 µs, 387.177 µs] -
iast 470.068 µs [449.326 µs, 490.811 µs] 103.187 µs (28.1%)
iast_FULL 530.209 µs [509.408 µs, 551.01 µs] 163.327 µs (44.5%)
iast_GLOBAL 487.486 µs [466.72 µs, 508.253 µs] 120.605 µs (32.9%)
iast_HARDCODED_SECRET_DISABLED 465.617 µs [445.237 µs, 485.997 µs] 98.736 µs (26.9%)
iast_INACTIVE 442.733 µs [421.145 µs, 464.321 µs] 75.852 µs (20.7%)
iast_TELEMETRY_OFF 471.979 µs [449.745 µs, 494.212 µs] 105.097 µs (28.6%)
tracing 438.866 µs [418.155 µs, 459.577 µs] 71.985 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.117 µs [349.022 µs, 389.212 µs] -
iast 464.03 µs [443.493 µs, 484.567 µs] 94.913 µs (25.7%)
iast_FULL 533.223 µs [512.775 µs, 553.671 µs] 164.106 µs (44.5%)
iast_GLOBAL 488.65 µs [467.029 µs, 510.272 µs] 119.533 µs (32.4%)
iast_HARDCODED_SECRET_DISABLED 463.078 µs [442.802 µs, 483.354 µs] 93.961 µs (25.5%)
iast_INACTIVE 452.492 µs [432.148 µs, 472.836 µs] 83.375 µs (22.6%)
iast_TELEMETRY_OFF 465.045 µs [443.096 µs, 486.994 µs] 95.928 µs (26.0%)
tracing 435.11 µs [414.698 µs, 455.523 µs] 65.993 µs (17.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1336, 1375
.   : milestone, 1356,
appsec (1.722 ms) : 1698, 1745
.   : milestone, 1722,
appsec_no_iast (1.728 ms) : 1704, 1751
.   : milestone, 1728,
iast (1.452 ms) : 1429, 1475
.   : milestone, 1452,
profiling (1.483 ms) : 1459, 1508
.   : milestone, 1483,
tracing (1.468 ms) : 1444, 1492
.   : milestone, 1468,
section candidate
no_agent (1.336 ms) : 1317, 1355
.   : milestone, 1336,
appsec (1.708 ms) : 1684, 1731
.   : milestone, 1708,
appsec_no_iast (1.689 ms) : 1665, 1714
.   : milestone, 1689,
iast (1.456 ms) : 1433, 1479
.   : milestone, 1456,
profiling (1.471 ms) : 1446, 1496
.   : milestone, 1471,
tracing (1.47 ms) : 1446, 1493
.   : milestone, 1470,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.336 ms, 1.375 ms] -
appsec 1.722 ms [1.698 ms, 1.745 ms] 366.118 µs (27.0%)
appsec_no_iast 1.728 ms [1.704 ms, 1.751 ms] 372.006 µs (27.4%)
iast 1.452 ms [1.429 ms, 1.475 ms] 96.554 µs (7.1%)
profiling 1.483 ms [1.459 ms, 1.508 ms] 127.848 µs (9.4%)
tracing 1.468 ms [1.444 ms, 1.492 ms] 112.17 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.355 ms] -
appsec 1.708 ms [1.684 ms, 1.731 ms] 371.242 µs (27.8%)
appsec_no_iast 1.689 ms [1.665 ms, 1.714 ms] 352.955 µs (26.4%)
iast 1.456 ms [1.433 ms, 1.479 ms] 120.023 µs (9.0%)
profiling 1.471 ms [1.446 ms, 1.496 ms] 134.79 µs (10.1%)
tracing 1.47 ms [1.446 ms, 1.493 ms] 133.278 µs (10.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/asm-extra-header-collection
git_commit_date 1715597003 1715597342
git_commit_sha f6f57a6 4f60289
release_version 1.35.0-SNAPSHOT~f6f57a6190 1.35.0-SNAPSHOT~4f60289bc2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715599559 1715599559
ci_job_id 509848999 509848999
ci_pipeline_id 34124382 34124382
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.161 s) : 15161000, 15161000
.   : milestone, 15161000,
appsec (14.848 s) : 14848000, 14848000
.   : milestone, 14848000,
iast (18.823 s) : 18823000, 18823000
.   : milestone, 18823000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
.   : milestone, 18001000,
profiling (15.192 s) : 15192000, 15192000
.   : milestone, 15192000,
tracing (15.267 s) : 15267000, 15267000
.   : milestone, 15267000,
section candidate
no_agent (15.141 s) : 15141000, 15141000
.   : milestone, 15141000,
appsec (14.845 s) : 14845000, 14845000
.   : milestone, 14845000,
iast (19.175 s) : 19175000, 19175000
.   : milestone, 19175000,
iast_GLOBAL (17.843 s) : 17843000, 17843000
.   : milestone, 17843000,
profiling (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
tracing (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.161 s [15.161 s, 15.161 s] -
appsec 14.848 s [14.848 s, 14.848 s] -313.0 ms (-2.1%)
iast 18.823 s [18.823 s, 18.823 s] 3.662 s (24.2%)
iast_GLOBAL 18.001 s [18.001 s, 18.001 s] 2.84 s (18.7%)
profiling 15.192 s [15.192 s, 15.192 s] 31.0 ms (0.2%)
tracing 15.267 s [15.267 s, 15.267 s] 106.0 ms (0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.141 s [15.141 s, 15.141 s] -
appsec 14.845 s [14.845 s, 14.845 s] -296.0 ms (-2.0%)
iast 19.175 s [19.175 s, 19.175 s] 4.034 s (26.6%)
iast_GLOBAL 17.843 s [17.843 s, 17.843 s] 2.702 s (17.8%)
profiling 15.279 s [15.279 s, 15.279 s] 138.0 ms (0.9%)
tracing 14.907 s [14.907 s, 14.907 s] -234.0 ms (-1.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~4f60289bc2, baseline=1.35.0-SNAPSHOT~f6f57a6190
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.209 ms) : 2175, 2243
.   : milestone, 2209,
iast (1.894 ms) : 1859, 1930
.   : milestone, 1894,
iast_GLOBAL (1.928 ms) : 1892, 1965
.   : milestone, 1928,
profiling (1.836 ms) : 1802, 1869
.   : milestone, 1836,
tracing (1.83 ms) : 1798, 1863
.   : milestone, 1830,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.211 ms) : 2177, 2245
.   : milestone, 2211,
iast (1.885 ms) : 1850, 1920
.   : milestone, 1885,
iast_GLOBAL (1.93 ms) : 1894, 1966
.   : milestone, 1930,
profiling (1.841 ms) : 1809, 1874
.   : milestone, 1841,
tracing (1.84 ms) : 1808, 1872
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.209 ms [2.175 ms, 2.243 ms] 745.835 µs (51.0%)
iast 1.894 ms [1.859 ms, 1.93 ms] 431.569 µs (29.5%)
iast_GLOBAL 1.928 ms [1.892 ms, 1.965 ms] 465.606 µs (31.8%)
profiling 1.836 ms [1.802 ms, 1.869 ms] 372.731 µs (25.5%)
tracing 1.83 ms [1.798 ms, 1.863 ms] 367.658 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.211 ms [2.177 ms, 2.245 ms] 737.833 µs (50.1%)
iast 1.885 ms [1.85 ms, 1.92 ms] 411.522 µs (27.9%)
iast_GLOBAL 1.93 ms [1.894 ms, 1.966 ms] 456.576 µs (31.0%)
profiling 1.841 ms [1.809 ms, 1.874 ms] 367.709 µs (25.0%)
tracing 1.84 ms [1.808 ms, 1.872 ms] 366.126 µs (24.8%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-default-header-collection branch from a78d34c to 20660ea Compare May 10, 2024 07:22
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-extra-header-collection branch from 743e1b1 to 657a875 Compare May 10, 2024 07:26
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review May 10, 2024 07:26
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner May 10, 2024 07:26
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-default-header-collection branch 2 times, most recently from 2f79a56 to 5d13bee Compare May 13, 2024 09:40
Base automatically changed from malvarez/asm-default-header-collection to master May 13, 2024 10:43
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-extra-header-collection branch from ab74adc to 4f60289 Compare May 13, 2024 10:49
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit ed71fed into master May 13, 2024
80 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/asm-extra-header-collection branch May 13, 2024 12:18
@github-actions github-actions bot added this to the 1.35.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF)
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuel-alvarez-alvarez @smola