Add extra connection params as tags for JDBC statements #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
reviewed
May 23, 2024
| @@ -122,6 +124,8 @@ protected String dbHostname(final DBInfo info) { | |||
| public AgentSpan onConnection(final AgentSpan span, DBInfo dbInfo) { | |||
| if (dbInfo != null) { | |||
| processDatabaseType(span, dbInfo.getType()); | |||
| span.setTag(DB_WAREHOUSE, dbInfo.getWarehouse()); | |||
There was a problem hiding this comment.
nit: a null check on the value can be done before setting the tag (same for the schema) to avoid synchronizing the map of tags at span level for nothing.
PerfectSlayer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection string for Snowflake contains additional attributes we want to add to spans as tags: