Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track OpenTelemetry propagated context #7114

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Track OpenTelemetry propagated context #7114

merged 1 commit into from
Jun 5, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jun 3, 2024 •
edited
Loading

What Does This Do

Uses a thread-local to track the last propagated context from OpenTelemetry that isn't already captured on the scope stack.

Additional Notes

This is a short-term solution while we rework how we track context in the Java tracer.

It assumes that the propagated context will be used to build a span before any other span is activated on that thread.

Jira ticket: APMAPI-104

@mcculls mcculls added the tag: do not merge Do not merge changes label Jun 3, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/inherit-otel-propagated-context
git_commit_date 1717433505 1717446413
git_commit_sha bffe40c b0b03f6
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~b0b03f67c6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717449996 1717449996
ci_job_id 530969199 530969199
ci_pipeline_id 35743993 35743993
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.573 s) : 0, 1573460
Total [baseline] (14.21 s) : 0, 14210286
Agent [candidate] (1.581 s) : 0, 1581385
Total [candidate] (14.116 s) : 0, 14116109
section appsec
Agent [baseline] (1.752 s) : 0, 1752450
Total [baseline] (14.385 s) : 0, 14384933
Agent [candidate] (1.755 s) : 0, 1755153
Total [candidate] (14.456 s) : 0, 14456200
section iast
Agent [baseline] (1.713 s) : 0, 1713414
Total [baseline] (14.773 s) : 0, 14773467
Agent [candidate] (1.721 s) : 0, 1720512
Total [candidate] (14.782 s) : 0, 14782014
section profiling
Agent [baseline] (1.893 s) : 0, 1892721
Total [baseline] (14.69 s) : 0, 14689903
Agent [candidate] (1.893 s) : 0, 1892826
Total [candidate] (14.735 s) : 0, 14734994
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.573 s -
Agent appsec 1.752 s 178.99 ms (11.4%)
Agent iast 1.713 s 139.954 ms (8.9%)
Agent profiling 1.893 s 319.26 ms (20.3%)
Total tracing 14.21 s -
Total appsec 14.385 s 174.647 ms (1.2%)
Total iast 14.773 s 563.181 ms (4.0%)
Total profiling 14.69 s 479.617 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.581 s -
Agent appsec 1.755 s 173.768 ms (11.0%)
Agent iast 1.721 s 139.127 ms (8.8%)
Agent profiling 1.893 s 311.442 ms (19.7%)
Total tracing 14.116 s -
Total appsec 14.456 s 340.091 ms (2.4%)
Total iast 14.782 s 665.905 ms (4.7%)
Total profiling 14.735 s 618.885 ms (4.4%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (968.575 ms) : 0, 968575
BytebuddyAgent [candidate] (973.883 ms) : 0, 973883
GlobalTracer [baseline] (463.175 ms) : 0, 463175
GlobalTracer [candidate] (464.524 ms) : 0, 464524
AppSec [baseline] (70.46 ms) : 0, 70460
AppSec [candidate] (71.421 ms) : 0, 71421
Remote Config [baseline] (838.299 µs) : 0, 838
Remote Config [candidate] (850.307 µs) : 0, 850
Telemetry [baseline] (9.823 ms) : 0, 9823
Telemetry [candidate] (9.898 ms) : 0, 9898
section appsec
BytebuddyAgent [baseline] (1.001 s) : 0, 1000876
BytebuddyAgent [candidate] (1.002 s) : 0, 1002121
GlobalTracer [baseline] (438.259 ms) : 0, 438259
GlobalTracer [candidate] (439.199 ms) : 0, 439199
AppSec [baseline] (230.725 ms) : 0, 230725
AppSec [candidate] (230.827 ms) : 0, 230827
IAST [baseline] (24.022 ms) : 0, 24022
IAST [candidate] (23.987 ms) : 0, 23987
Remote Config [baseline] (783.258 µs) : 0, 783
Remote Config [candidate] (784.471 µs) : 0, 784
Telemetry [baseline] (9.199 ms) : 0, 9199
Telemetry [candidate] (9.539 ms) : 0, 9539
section iast
BytebuddyAgent [baseline] (1.153 s) : 0, 1152516
BytebuddyAgent [candidate] (1.156 s) : 0, 1156228
GlobalTracer [baseline] (434.777 ms) : 0, 434777
GlobalTracer [candidate] (434.746 ms) : 0, 434746
AppSec [baseline] (65.977 ms) : 0, 65977
AppSec [candidate] (66.896 ms) : 0, 66896
IAST [baseline] (28.622 ms) : 0, 28622
IAST [candidate] (31.03 ms) : 0, 31030
Remote Config [baseline] (796.089 µs) : 0, 796
Remote Config [candidate] (802.845 µs) : 0, 803
Telemetry [baseline] (10.881 ms) : 0, 10881
Telemetry [candidate] (10.909 ms) : 0, 10909
section profiling
BytebuddyAgent [baseline] (983.432 ms) : 0, 983432
BytebuddyAgent [candidate] (982.688 ms) : 0, 982688
GlobalTracer [baseline] (579.892 ms) : 0, 579892
GlobalTracer [candidate] (578.887 ms) : 0, 578887
AppSec [baseline] (72.454 ms) : 0, 72454
AppSec [candidate] (71.614 ms) : 0, 71614
Remote Config [baseline] (1.02 ms) : 0, 1020
Remote Config [candidate] (1.033 ms) : 0, 1033
Telemetry [baseline] (9.879 ms) : 0, 9879
Telemetry [candidate] (9.671 ms) : 0, 9671
ProfilingAgent [baseline] (152.671 ms) : 0, 152671
ProfilingAgent [candidate] (155.597 ms) : 0, 155597
Profiling [baseline] (152.724 ms) : 0, 152724
Profiling [candidate] (155.659 ms) : 0, 155659
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.582 s) : 0, 1581568
Total [baseline] (11.922 s) : 0, 11922154
Agent [candidate] (1.578 s) : 0, 1578092
Total [candidate] (11.931 s) : 0, 11930676
section iast
Agent [baseline] (1.703 s) : 0, 1703187
Total [baseline] (12.515 s) : 0, 12514601
Agent [candidate] (1.703 s) : 0, 1703186
Total [candidate] (12.515 s) : 0, 12515113
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.706 s) : 0, 1706468
Total [baseline] (12.493 s) : 0, 12493306
Agent [candidate] (1.708 s) : 0, 1708436
Total [candidate] (12.566 s) : 0, 12565676
section iast_TELEMETRY_OFF
Agent [baseline] (1.708 s) : 0, 1708327
Total [baseline] (12.561 s) : 0, 12561399
Agent [candidate] (1.71 s) : 0, 1709793
Total [candidate] (12.585 s) : 0, 12585350
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.582 s -
Agent iast 1.703 s 121.619 ms (7.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.706 s 124.901 ms (7.9%)
Agent iast_TELEMETRY_OFF 1.708 s 126.759 ms (8.0%)
Total tracing 11.922 s -
Total iast 12.515 s 592.446 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 12.493 s 571.151 ms (4.8%)
Total iast_TELEMETRY_OFF 12.561 s 639.244 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.578 s -
Agent iast 1.703 s 125.094 ms (7.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.708 s 130.344 ms (8.3%)
Agent iast_TELEMETRY_OFF 1.71 s 131.701 ms (8.3%)
Total tracing 11.931 s -
Total iast 12.515 s 584.437 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 12.566 s 634.999 ms (5.3%)
Total iast_TELEMETRY_OFF 12.585 s 654.674 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (973.344 ms) : 0, 973344
BytebuddyAgent [candidate] (971.917 ms) : 0, 971917
GlobalTracer [baseline] (465.668 ms) : 0, 465668
GlobalTracer [candidate] (463.573 ms) : 0, 463573
AppSec [baseline] (70.852 ms) : 0, 70852
AppSec [candidate] (71.11 ms) : 0, 71110
Remote Config [baseline] (852.227 µs) : 0, 852
Remote Config [candidate] (846.501 µs) : 0, 847
Telemetry [baseline] (9.88 ms) : 0, 9880
Telemetry [candidate] (9.874 ms) : 0, 9874
section iast
BytebuddyAgent [baseline] (1.144 s) : 0, 1144265
BytebuddyAgent [candidate] (1.144 s) : 0, 1143728
GlobalTracer [baseline] (430.964 ms) : 0, 430964
GlobalTracer [candidate] (430.529 ms) : 0, 430529
AppSec [baseline] (66.148 ms) : 0, 66148
AppSec [candidate] (65.062 ms) : 0, 65062
IAST [baseline] (31.473 ms) : 0, 31473
IAST [candidate] (33.418 ms) : 0, 33418
Remote Config [baseline] (776.593 µs) : 0, 777
Remote Config [candidate] (794.239 µs) : 0, 794
Telemetry [baseline] (9.838 ms) : 0, 9838
Telemetry [candidate] (9.852 ms) : 0, 9852
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.145 s) : 0, 1144829
BytebuddyAgent [candidate] (1.146 s) : 0, 1145665
GlobalTracer [baseline] (431.902 ms) : 0, 431902
GlobalTracer [candidate] (431.402 ms) : 0, 431402
AppSec [baseline] (67.757 ms) : 0, 67757
AppSec [candidate] (68.428 ms) : 0, 68428
IAST [baseline] (29.01 ms) : 0, 29010
IAST [candidate] (30.672 ms) : 0, 30672
Remote Config [baseline] (770.696 µs) : 0, 771
Remote Config [candidate] (787.944 µs) : 0, 788
Telemetry [baseline] (12.373 ms) : 0, 12373
Telemetry [candidate] (11.575 ms) : 0, 11575
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.147 s) : 0, 1146990
BytebuddyAgent [candidate] (1.146 s) : 0, 1145715
GlobalTracer [baseline] (432.344 ms) : 0, 432344
GlobalTracer [candidate] (432.91 ms) : 0, 432910
AppSec [baseline] (68.798 ms) : 0, 68798
AppSec [candidate] (69.481 ms) : 0, 69481
IAST [baseline] (29.631 ms) : 0, 29631
IAST [candidate] (31.993 ms) : 0, 31993
Remote Config [baseline] (793.666 µs) : 0, 794
Remote Config [candidate] (773.549 µs) : 0, 774
Telemetry [baseline] (9.821 ms) : 0, 9821
Telemetry [candidate] (8.878 ms) : 0, 8878
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-03T20:47:05 2024-06-03T20:53:53
git_branch master mcculls/inherit-otel-propagated-context
git_commit_date 1717433505 1717446413
git_commit_sha bffe40c b0b03f6
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~b0b03f67c6
start_time 2024-06-03T20:46:52 2024-06-03T20:53:40
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717448378 1717448378
ci_job_id 530969200 530969200
ci_pipeline_id 35743993 35743993
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.055 µs) : 355, 395
.   : milestone, 375,
iast (480.91 µs) : 460, 502
.   : milestone, 481,
iast_FULL (550.974 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (504.452 µs) : 483, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (479.154 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (454.267 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (468.163 µs) : 447, 489
.   : milestone, 468,
tracing (439.966 µs) : 420, 460
.   : milestone, 440,
section candidate
no_agent (365.487 µs) : 346, 385
.   : milestone, 365,
iast (482.077 µs) : 461, 503
.   : milestone, 482,
iast_FULL (548.68 µs) : 527, 570
.   : milestone, 549,
iast_GLOBAL (503.998 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (486.253 µs) : 465, 508
.   : milestone, 486,
iast_INACTIVE (451.21 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (470.344 µs) : 449, 492
.   : milestone, 470,
tracing (442.904 µs) : 422, 464
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.055 µs [355.492 µs, 394.618 µs] -
iast 480.91 µs [459.614 µs, 502.206 µs] 105.855 µs (28.2%)
iast_FULL 550.974 µs [529.951 µs, 571.997 µs] 175.919 µs (46.9%)
iast_GLOBAL 504.452 µs [483.012 µs, 525.892 µs] 129.397 µs (34.5%)
iast_HARDCODED_SECRET_DISABLED 479.154 µs [458.322 µs, 499.986 µs] 104.099 µs (27.8%)
iast_INACTIVE 454.267 µs [433.426 µs, 475.108 µs] 79.212 µs (21.1%)
iast_TELEMETRY_OFF 468.163 µs [447.257 µs, 489.068 µs] 93.108 µs (24.8%)
tracing 439.966 µs [419.901 µs, 460.031 µs] 64.911 µs (17.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.487 µs [345.688 µs, 385.285 µs] -
iast 482.077 µs [460.834 µs, 503.321 µs] 116.591 µs (31.9%)
iast_FULL 548.68 µs [527.354 µs, 570.006 µs] 183.193 µs (50.1%)
iast_GLOBAL 503.998 µs [482.973 µs, 525.023 µs] 138.511 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 486.253 µs [464.786 µs, 507.721 µs] 120.767 µs (33.0%)
iast_INACTIVE 451.21 µs [430.391 µs, 472.029 µs] 85.723 µs (23.5%)
iast_TELEMETRY_OFF 470.344 µs [449.149 µs, 491.54 µs] 104.857 µs (28.7%)
tracing 442.904 µs [422.06 µs, 463.748 µs] 77.417 µs (21.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.333 ms) : 1314, 1353
.   : milestone, 1333,
appsec (1.722 ms) : 1698, 1746
.   : milestone, 1722,
appsec_no_iast (1.709 ms) : 1684, 1734
.   : milestone, 1709,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.518 ms) : 1492, 1544
.   : milestone, 1518,
tracing (1.462 ms) : 1437, 1487
.   : milestone, 1462,
section candidate
no_agent (1.347 ms) : 1328, 1366
.   : milestone, 1347,
appsec (1.729 ms) : 1705, 1754
.   : milestone, 1729,
appsec_no_iast (1.721 ms) : 1695, 1746
.   : milestone, 1721,
iast (1.47 ms) : 1445, 1494
.   : milestone, 1470,
profiling (1.479 ms) : 1454, 1503
.   : milestone, 1479,
tracing (1.474 ms) : 1450, 1498
.   : milestone, 1474,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.314 ms, 1.353 ms] -
appsec 1.722 ms [1.698 ms, 1.746 ms] 388.798 µs (29.2%)
appsec_no_iast 1.709 ms [1.684 ms, 1.734 ms] 375.357 µs (28.2%)
iast 1.478 ms [1.455 ms, 1.501 ms] 144.813 µs (10.9%)
profiling 1.518 ms [1.492 ms, 1.544 ms] 184.405 µs (13.8%)
tracing 1.462 ms [1.437 ms, 1.487 ms] 128.971 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.366 ms] -
appsec 1.729 ms [1.705 ms, 1.754 ms] 382.216 µs (28.4%)
appsec_no_iast 1.721 ms [1.695 ms, 1.746 ms] 373.533 µs (27.7%)
iast 1.47 ms [1.445 ms, 1.494 ms] 122.464 µs (9.1%)
profiling 1.479 ms [1.454 ms, 1.503 ms] 131.602 µs (9.8%)
tracing 1.474 ms [1.45 ms, 1.498 ms] 126.817 µs (9.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/inherit-otel-propagated-context
git_commit_date 1717433505 1717446413
git_commit_sha bffe40c b0b03f6
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~b0b03f67c6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717448904 1717448904
ci_job_id 530969201 530969201
ci_pipeline_id 35743993 35743993
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
.   : milestone, 1460,
appsec (2.211 ms) : 2176, 2245
.   : milestone, 2211,
iast (1.964 ms) : 1923, 2005
.   : milestone, 1964,
iast_GLOBAL (2.004 ms) : 1963, 2045
.   : milestone, 2004,
profiling (1.835 ms) : 1802, 1869
.   : milestone, 1835,
tracing (1.825 ms) : 1794, 1857
.   : milestone, 1825,
section candidate
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.197 ms) : 2163, 2231
.   : milestone, 2197,
iast (1.953 ms) : 1913, 1994
.   : milestone, 1953,
iast_GLOBAL (2.005 ms) : 1964, 2046
.   : milestone, 2005,
profiling (1.852 ms) : 1818, 1886
.   : milestone, 1852,
tracing (1.824 ms) : 1791, 1856
.   : milestone, 1824,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.471 ms] -
appsec 2.211 ms [2.176 ms, 2.245 ms] 750.83 µs (51.4%)
iast 1.964 ms [1.923 ms, 2.005 ms] 503.995 µs (34.5%)
iast_GLOBAL 2.004 ms [1.963 ms, 2.045 ms] 543.865 µs (37.3%)
profiling 1.835 ms [1.802 ms, 1.869 ms] 375.121 µs (25.7%)
tracing 1.825 ms [1.794 ms, 1.857 ms] 365.438 µs (25.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.197 ms [2.163 ms, 2.231 ms] 733.733 µs (50.1%)
iast 1.953 ms [1.913 ms, 1.994 ms] 490.147 µs (33.5%)
iast_GLOBAL 2.005 ms [1.964 ms, 2.046 ms] 541.859 µs (37.0%)
profiling 1.852 ms [1.818 ms, 1.886 ms] 388.936 µs (26.6%)
tracing 1.824 ms [1.791 ms, 1.856 ms] 360.724 µs (24.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~b0b03f67c6, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.322 s) : 15322000, 15322000
.   : milestone, 15322000,
appsec (15.198 s) : 15198000, 15198000
.   : milestone, 15198000,
iast (18.817 s) : 18817000, 18817000
.   : milestone, 18817000,
iast_GLOBAL (17.743 s) : 17743000, 17743000
.   : milestone, 17743000,
profiling (15.796 s) : 15796000, 15796000
.   : milestone, 15796000,
tracing (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
section candidate
no_agent (14.858 s) : 14858000, 14858000
.   : milestone, 14858000,
appsec (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,
iast (18.68 s) : 18680000, 18680000
.   : milestone, 18680000,
iast_GLOBAL (17.756 s) : 17756000, 17756000
.   : milestone, 17756000,
profiling (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
tracing (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.322 s [15.322 s, 15.322 s] -
appsec 15.198 s [15.198 s, 15.198 s] -124.0 ms (-0.8%)
iast 18.817 s [18.817 s, 18.817 s] 3.495 s (22.8%)
iast_GLOBAL 17.743 s [17.743 s, 17.743 s] 2.421 s (15.8%)
profiling 15.796 s [15.796 s, 15.796 s] 474.0 ms (3.1%)
tracing 15.04 s [15.04 s, 15.04 s] -282.0 ms (-1.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.858 s [14.858 s, 14.858 s] -
appsec 15.086 s [15.086 s, 15.086 s] 228.0 ms (1.5%)
iast 18.68 s [18.68 s, 18.68 s] 3.822 s (25.7%)
iast_GLOBAL 17.756 s [17.756 s, 17.756 s] 2.898 s (19.5%)
profiling 15.026 s [15.026 s, 15.026 s] 168.0 ms (1.1%)
tracing 14.954 s [14.954 s, 14.954 s] 96.0 ms (0.6%)

@mcculls mcculls changed the title [WIP] Track OTel propagated context not captured on the scope stack Track OTel propagated context not captured on the scope stack Jun 3, 2024
@mcculls mcculls added inst: opentelemetry OpenTelemetry instrumentation and removed tag: do not merge Do not merge changes labels Jun 3, 2024
@mcculls mcculls force-pushed the mcculls/inherit-otel-propagated-context branch from 11c1810 to b0b03f6 Compare June 3, 2024 20:26
@mcculls mcculls marked this pull request as ready for review June 3, 2024 20:26
@mcculls mcculls requested review from a team as code owners June 3, 2024 20:26
@mcculls mcculls changed the title Track OTel propagated context not captured on the scope stack Track OpenTelemetry propagated context not captured on the scope stack Jun 3, 2024
@mcculls mcculls changed the title Track OpenTelemetry propagated context not captured on the scope stack Track OpenTelemetry propagated context Jun 3, 2024
@mcculls mcculls requested a review from amarziali June 5, 2024 15:16
@mcculls mcculls merged commit 6860183 into master Jun 5, 2024
81 checks passed
@mcculls mcculls deleted the mcculls/inherit-otel-propagated-context branch June 5, 2024 16:55
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: opentelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcculls @amarziali