Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating unnecessary OtelSpanContext… #7116

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Avoid creating unnecessary OtelSpanContext… #7116

merged 1 commit into from
Jun 4, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jun 3, 2024

…when extracting context from OTel wrapper around Datadog span

Motivation

getSpanContext ends up creating an intermediate OtelSpanContext when we really just need the agent span context.

( It also queries the local root span for the sampling priority and creates a default trace state, which is also never used here. )

@mcculls mcculls added tag: performance Performance related changes inst: opentelemetry OpenTelemetry instrumentation labels Jun 3, 2024
@mcculls mcculls marked this pull request as ready for review June 3, 2024 20:25
@mcculls mcculls requested a review from a team as a code owner June 3, 2024 20:25
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-unnecessary-otelspancontext
git_commit_date 1717449286 1717445617
git_commit_sha c9524d0 58f669b
release_version 1.35.0-SNAPSHOT~c9524d0e3d 1.35.0-SNAPSHOT~58f669b711
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717455759 1717455759
ci_job_id 531082956 531082956
ci_pipeline_id 35742817 35742817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 13 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:tracing:Remote Config better
[-103.887µs; -51.063µs] or [-14.084%; -6.923%]		 660.153µs 737.628µs
scenario:startup:petclinic:tracing:Remote Config better
[-95.026µs; -38.019µs] or [-13.094%; -5.239%]		 659.188µs 725.711µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~c9524d0e3d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064206
Total [baseline] (8.542 s) : 0, 8542324
Agent [candidate] (1.057 s) : 0, 1057200
Total [candidate] (8.573 s) : 0, 8572808
section iast
Agent [baseline] (1.175 s) : 0, 1174529
Total [baseline] (9.027 s) : 0, 9026989
Agent [candidate] (1.169 s) : 0, 1168892
Total [candidate] (9.002 s) : 0, 9001524
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183386
Total [baseline] (9.019 s) : 0, 9018738
Agent [candidate] (1.174 s) : 0, 1173984
Total [candidate] (8.981 s) : 0, 8981177
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1169821
Total [baseline] (8.992 s) : 0, 8992482
Agent [candidate] (1.169 s) : 0, 1168568
Total [candidate] (8.994 s) : 0, 8994228
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.175 s 110.323 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 119.18 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.17 s 105.614 ms (9.9%)
Total tracing 8.542 s -
Total iast 9.027 s 484.665 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.019 s 476.414 ms (5.6%)
Total iast_TELEMETRY_OFF 8.992 s 450.159 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.169 s 111.693 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 116.785 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.169 s 111.369 ms (10.5%)
Total tracing 8.573 s -
Total iast 9.002 s 428.716 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.981 s 408.368 ms (4.8%)
Total iast_TELEMETRY_OFF 8.994 s 421.42 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~c9524d0e3d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (655.998 ms) : 0, 655998
BytebuddyAgent [candidate] (652.025 ms) : 0, 652025
GlobalTracer [baseline] (314.733 ms) : 0, 314733
GlobalTracer [candidate] (313.064 ms) : 0, 313064
AppSec [baseline] (50.461 ms) : 0, 50461
AppSec [candidate] (49.636 ms) : 0, 49636
Remote Config [baseline] (737.628 µs) : 0, 738
Remote Config [candidate] (660.153 µs) : 0, 660
Telemetry [baseline] (7.626 ms) : 0, 7626
Telemetry [candidate] (7.491 ms) : 0, 7491
section iast
BytebuddyAgent [baseline] (784.175 ms) : 0, 784175
BytebuddyAgent [candidate] (779.307 ms) : 0, 779307
GlobalTracer [baseline] (293.955 ms) : 0, 293955
GlobalTracer [candidate] (294.294 ms) : 0, 294294
AppSec [baseline] (46.897 ms) : 0, 46897
AppSec [candidate] (46.329 ms) : 0, 46329
IAST [baseline] (26.458 ms) : 0, 26458
IAST [candidate] (26.712 ms) : 0, 26712
Remote Config [baseline] (607.488 µs) : 0, 607
Remote Config [candidate] (627.648 µs) : 0, 628
Telemetry [baseline] (9.137 ms) : 0, 9137
Telemetry [candidate] (8.376 ms) : 0, 8376
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.984 ms) : 0, 790984
BytebuddyAgent [candidate] (784.408 ms) : 0, 784408
GlobalTracer [baseline] (296.526 ms) : 0, 296526
GlobalTracer [candidate] (294.649 ms) : 0, 294649
AppSec [baseline] (48.931 ms) : 0, 48931
AppSec [candidate] (49.158 ms) : 0, 49158
IAST [baseline] (25.01 ms) : 0, 25010
IAST [candidate] (24.846 ms) : 0, 24846
Remote Config [baseline] (614.121 µs) : 0, 614
Remote Config [candidate] (611.009 µs) : 0, 611
Telemetry [baseline] (7.813 ms) : 0, 7813
Telemetry [candidate] (6.924 ms) : 0, 6924
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.469 ms) : 0, 780469
BytebuddyAgent [candidate] (781.09 ms) : 0, 781090
GlobalTracer [baseline] (294.446 ms) : 0, 294446
GlobalTracer [candidate] (294.6 ms) : 0, 294600
AppSec [baseline] (49.389 ms) : 0, 49389
AppSec [candidate] (48.95 ms) : 0, 48950
IAST [baseline] (23.952 ms) : 0, 23952
IAST [candidate] (23.048 ms) : 0, 23048
Remote Config [baseline] (599.985 µs) : 0, 600
Remote Config [candidate] (617.224 µs) : 0, 617
Telemetry [baseline] (7.595 ms) : 0, 7595
Telemetry [candidate] (6.898 ms) : 0, 6898
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~c9524d0e3d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060195
Total [baseline] (10.46 s) : 0, 10459857
Agent [candidate] (1.058 s) : 0, 1057534
Total [candidate] (10.298 s) : 0, 10297938
section appsec
Agent [baseline] (1.18 s) : 0, 1179531
Total [baseline] (10.52 s) : 0, 10520393
Agent [candidate] (1.185 s) : 0, 1184579
Total [candidate] (10.453 s) : 0, 10453219
section iast
Agent [baseline] (1.176 s) : 0, 1175697
Total [baseline] (10.749 s) : 0, 10748785
Agent [candidate] (1.174 s) : 0, 1173621
Total [candidate] (10.763 s) : 0, 10763381
section profiling
Agent [baseline] (1.266 s) : 0, 1266064
Total [baseline] (10.648 s) : 0, 10648346
Agent [candidate] (1.26 s) : 0, 1259654
Total [candidate] (10.577 s) : 0, 10577081
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.18 s 119.336 ms (11.3%)
Agent iast 1.176 s 115.502 ms (10.9%)
Agent profiling 1.266 s 205.87 ms (19.4%)
Total tracing 10.46 s -
Total appsec 10.52 s 60.535 ms (0.6%)
Total iast 10.749 s 288.927 ms (2.8%)
Total profiling 10.648 s 188.489 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.185 s 127.045 ms (12.0%)
Agent iast 1.174 s 116.087 ms (11.0%)
Agent profiling 1.26 s 202.12 ms (19.1%)
Total tracing 10.298 s -
Total appsec 10.453 s 155.281 ms (1.5%)
Total iast 10.763 s 465.443 ms (4.5%)
Total profiling 10.577 s 279.144 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~c9524d0e3d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (653.658 ms) : 0, 653658
BytebuddyAgent [candidate] (652.232 ms) : 0, 652232
GlobalTracer [baseline] (313.625 ms) : 0, 313625
GlobalTracer [candidate] (312.999 ms) : 0, 312999
AppSec [baseline] (50.21 ms) : 0, 50210
AppSec [candidate] (49.647 ms) : 0, 49647
Remote Config [baseline] (725.711 µs) : 0, 726
Remote Config [candidate] (659.188 µs) : 0, 659
Telemetry [baseline] (7.6 ms) : 0, 7600
Telemetry [candidate] (7.55 ms) : 0, 7550
section appsec
BytebuddyAgent [baseline] (677.149 ms) : 0, 677149
BytebuddyAgent [candidate] (679.779 ms) : 0, 679779
GlobalTracer [baseline] (296.765 ms) : 0, 296765
GlobalTracer [candidate] (298.37 ms) : 0, 298370
AppSec [baseline] (153.101 ms) : 0, 153101
AppSec [candidate] (152.692 ms) : 0, 152692
IAST [baseline] (18.654 ms) : 0, 18654
IAST [candidate] (18.815 ms) : 0, 18815
Remote Config [baseline] (621.162 µs) : 0, 621
Remote Config [candidate] (620.635 µs) : 0, 621
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (9.041 ms) : 0, 9041
section iast
BytebuddyAgent [baseline] (785.043 ms) : 0, 785043
BytebuddyAgent [candidate] (784.184 ms) : 0, 784184
GlobalTracer [baseline] (294.806 ms) : 0, 294806
GlobalTracer [candidate] (294.373 ms) : 0, 294373
AppSec [baseline] (46.962 ms) : 0, 46962
AppSec [candidate] (47.912 ms) : 0, 47912
IAST [baseline] (28.005 ms) : 0, 28005
IAST [candidate] (25.562 ms) : 0, 25562
Remote Config [baseline] (601.684 µs) : 0, 602
Remote Config [candidate] (614.437 µs) : 0, 614
Telemetry [baseline] (6.954 ms) : 0, 6954
Telemetry [candidate] (7.674 ms) : 0, 7674
section profiling
BytebuddyAgent [baseline] (666.692 ms) : 0, 666692
BytebuddyAgent [candidate] (662.671 ms) : 0, 662671
GlobalTracer [baseline] (386.993 ms) : 0, 386993
GlobalTracer [candidate] (385.668 ms) : 0, 385668
AppSec [baseline] (50.936 ms) : 0, 50936
AppSec [candidate] (50.198 ms) : 0, 50198
Remote Config [baseline] (796.266 µs) : 0, 796
Remote Config [candidate] (871.591 µs) : 0, 872
Telemetry [baseline] (7.371 ms) : 0, 7371
Telemetry [candidate] (7.427 ms) : 0, 7427
ProfilingAgent [baseline] (96.328 ms) : 0, 96328
ProfilingAgent [candidate] (96.273 ms) : 0, 96273
Profiling [baseline] (96.352 ms) : 0, 96352
Profiling [candidate] (96.299 ms) : 0, 96299
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-03T20:35:53 2024-06-03T20:42:45
git_branch master mcculls/avoid-unnecessary-otelspancontext
git_commit_date 1717433505 1717445617
git_commit_sha bffe40c 58f669b
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~58f669b711
start_time 2024-06-03T20:35:40 2024-06-03T20:42:32
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717447712 1717447712
ci_job_id 530933049 530933049
ci_pipeline_id 35742817 35742817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-103.643µs; -50.470µs] or [-6.683%; -3.255%]		 unstable
[-474.564op/s; +702.485op/s] or [-16.017%; +23.709%]		 1.474ms 3076.923op/s 1.551ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.367 ms) : 1348, 1386
.   : milestone, 1367,
appsec (1.724 ms) : 1700, 1748
.   : milestone, 1724,
appsec_no_iast (1.734 ms) : 1709, 1759
.   : milestone, 1734,
iast (1.491 ms) : 1468, 1513
.   : milestone, 1491,
profiling (1.551 ms) : 1526, 1576
.   : milestone, 1551,
tracing (1.471 ms) : 1446, 1496
.   : milestone, 1471,
section candidate
no_agent (1.371 ms) : 1351, 1390
.   : milestone, 1371,
appsec (1.731 ms) : 1706, 1756
.   : milestone, 1731,
appsec_no_iast (1.722 ms) : 1698, 1746
.   : milestone, 1722,
iast (1.478 ms) : 1455, 1500
.   : milestone, 1478,
profiling (1.474 ms) : 1449, 1498
.   : milestone, 1474,
tracing (1.461 ms) : 1437, 1485
.   : milestone, 1461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.367 ms [1.348 ms, 1.386 ms] -
appsec 1.724 ms [1.7 ms, 1.748 ms] 356.506 µs (26.1%)
appsec_no_iast 1.734 ms [1.709 ms, 1.759 ms] 366.545 µs (26.8%)
iast 1.491 ms [1.468 ms, 1.513 ms] 123.45 µs (9.0%)
profiling 1.551 ms [1.526 ms, 1.576 ms] 183.497 µs (13.4%)
tracing 1.471 ms [1.446 ms, 1.496 ms] 104.066 µs (7.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.371 ms [1.351 ms, 1.39 ms] -
appsec 1.731 ms [1.706 ms, 1.756 ms] 360.616 µs (26.3%)
appsec_no_iast 1.722 ms [1.698 ms, 1.746 ms] 351.563 µs (25.6%)
iast 1.478 ms [1.455 ms, 1.5 ms] 106.905 µs (7.8%)
profiling 1.474 ms [1.449 ms, 1.498 ms] 103.086 µs (7.5%)
tracing 1.461 ms [1.437 ms, 1.485 ms] 90.49 µs (6.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.491 µs) : 353, 396
.   : milestone, 374,
iast (486.467 µs) : 465, 508
.   : milestone, 486,
iast_FULL (556.017 µs) : 535, 577
.   : milestone, 556,
iast_GLOBAL (524.911 µs) : 502, 548
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (487.06 µs) : 466, 509
.   : milestone, 487,
iast_INACTIVE (453.366 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (476.765 µs) : 455, 498
.   : milestone, 477,
tracing (449.017 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (379.738 µs) : 359, 401
.   : milestone, 380,
iast (485.468 µs) : 464, 507
.   : milestone, 485,
iast_FULL (559.782 µs) : 538, 581
.   : milestone, 560,
iast_GLOBAL (511.763 µs) : 491, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (482.8 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (457.552 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (475.122 µs) : 454, 496
.   : milestone, 475,
tracing (447.2 µs) : 426, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.491 µs [353.325 µs, 395.657 µs] -
iast 486.467 µs [465.144 µs, 507.789 µs] 111.976 µs (29.9%)
iast_FULL 556.017 µs [534.845 µs, 577.189 µs] 181.526 µs (48.5%)
iast_GLOBAL 524.911 µs [501.837 µs, 547.984 µs] 150.42 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED 487.06 µs [465.554 µs, 508.566 µs] 112.569 µs (30.1%)
iast_INACTIVE 453.366 µs [432.292 µs, 474.441 µs] 78.875 µs (21.1%)
iast_TELEMETRY_OFF 476.765 µs [455.08 µs, 498.45 µs] 102.274 µs (27.3%)
tracing 449.017 µs [428.128 µs, 469.906 µs] 74.526 µs (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.738 µs [358.907 µs, 400.568 µs] -
iast 485.468 µs [464.358 µs, 506.579 µs] 105.73 µs (27.8%)
iast_FULL 559.782 µs [538.476 µs, 581.087 µs] 180.044 µs (47.4%)
iast_GLOBAL 511.763 µs [490.74 µs, 532.787 µs] 132.026 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 482.8 µs [461.378 µs, 504.222 µs] 103.062 µs (27.1%)
iast_INACTIVE 457.552 µs [436.362 µs, 478.742 µs] 77.814 µs (20.5%)
iast_TELEMETRY_OFF 475.122 µs [453.84 µs, 496.404 µs] 95.384 µs (25.1%)
tracing 447.2 µs [426.253 µs, 468.148 µs] 67.463 µs (17.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-unnecessary-otelspancontext
git_commit_date 1717433505 1717445617
git_commit_sha bffe40c 58f669b
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~58f669b711
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717448967 1717448967
ci_job_id 530933051 530933051
ci_pipeline_id 35742817 35742817
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.436 s) : 20436000, 20436000
.   : milestone, 20436000,
appsec (21.659 s) : 21659000, 21659000
.   : milestone, 21659000,
iast (25.158 s) : 25158000, 25158000
.   : milestone, 25158000,
iast_GLOBAL (24.984 s) : 24984000, 24984000
.   : milestone, 24984000,
profiling (20.481 s) : 20481000, 20481000
.   : milestone, 20481000,
tracing (20.473 s) : 20473000, 20473000
.   : milestone, 20473000,
section candidate
no_agent (20.449 s) : 20449000, 20449000
.   : milestone, 20449000,
appsec (20.941 s) : 20941000, 20941000
.   : milestone, 20941000,
iast (24.411 s) : 24411000, 24411000
.   : milestone, 24411000,
iast_GLOBAL (25.113 s) : 25113000, 25113000
.   : milestone, 25113000,
profiling (20.872 s) : 20872000, 20872000
.   : milestone, 20872000,
tracing (20.588 s) : 20588000, 20588000
.   : milestone, 20588000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.436 s [20.436 s, 20.436 s] -
appsec 21.659 s [21.659 s, 21.659 s] 1.223 s (6.0%)
iast 25.158 s [25.158 s, 25.158 s] 4.722 s (23.1%)
iast_GLOBAL 24.984 s [24.984 s, 24.984 s] 4.548 s (22.3%)
profiling 20.481 s [20.481 s, 20.481 s] 45.0 ms (0.2%)
tracing 20.473 s [20.473 s, 20.473 s] 37.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.449 s [20.449 s, 20.449 s] -
appsec 20.941 s [20.941 s, 20.941 s] 492.0 ms (2.4%)
iast 24.411 s [24.411 s, 24.411 s] 3.962 s (19.4%)
iast_GLOBAL 25.113 s [25.113 s, 25.113 s] 4.664 s (22.8%)
profiling 20.872 s [20.872 s, 20.872 s] 423.0 ms (2.1%)
tracing 20.588 s [20.588 s, 20.588 s] 139.0 ms (0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~58f669b711, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.552 ms) : 1539, 1565
.   : milestone, 1552,
appsec (2.667 ms) : 2607, 2726
.   : milestone, 2667,
iast (2.342 ms) : 2272, 2412
.   : milestone, 2342,
iast_GLOBAL (2.387 ms) : 2317, 2457
.   : milestone, 2387,
profiling (2.18 ms) : 2121, 2238
.   : milestone, 2180,
tracing (2.161 ms) : 2104, 2218
.   : milestone, 2161,
section candidate
no_agent (1.544 ms) : 1530, 1557
.   : milestone, 1544,
appsec (2.674 ms) : 2614, 2734
.   : milestone, 2674,
iast (2.341 ms) : 2271, 2411
.   : milestone, 2341,
iast_GLOBAL (2.389 ms) : 2319, 2459
.   : milestone, 2389,
profiling (2.2 ms) : 2138, 2262
.   : milestone, 2200,
tracing (2.142 ms) : 2086, 2198
.   : milestone, 2142,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.552 ms [1.539 ms, 1.565 ms] -
appsec 2.667 ms [2.607 ms, 2.726 ms] 1.115 ms (71.8%)
iast 2.342 ms [2.272 ms, 2.412 ms] 789.489 µs (50.9%)
iast_GLOBAL 2.387 ms [2.317 ms, 2.457 ms] 835.009 µs (53.8%)
profiling 2.18 ms [2.121 ms, 2.238 ms] 627.587 µs (40.4%)
tracing 2.161 ms [2.104 ms, 2.218 ms] 608.508 µs (39.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.544 ms [1.53 ms, 1.557 ms] -
appsec 2.674 ms [2.614 ms, 2.734 ms] 1.13 ms (73.2%)
iast 2.341 ms [2.271 ms, 2.411 ms] 797.298 µs (51.7%)
iast_GLOBAL 2.389 ms [2.319 ms, 2.459 ms] 845.262 µs (54.8%)
profiling 2.2 ms [2.138 ms, 2.262 ms] 656.309 µs (42.5%)
tracing 2.142 ms [2.086 ms, 2.198 ms] 598.367 µs (38.8%)

@mcculls mcculls merged commit 47cdadc into master Jun 4, 2024
83 checks passed
@mcculls mcculls deleted the mcculls/avoid-unnecessary-otelspancontext branch June 4, 2024 09:17
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: opentelemetry OpenTelemetry instrumentation tag: performance Performance related changes
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcculls @PerfectSlayer