Map OpenTelemetry VirtualField to Datadog ContextStore #7129

mcculls · 2024-06-05T14:58:10Z

Uses a similar approach to FieldBackedContextRequestRewriter to map VirtualField requests in extension code to the Datadog ContextStore API. Also collects which context stores are being used from the extension so we can arrange the appropriate field injection at startup.

Jira ticket: APMAPI-6

pr-commenter · 2024-06-05T16:11:45Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/map-otel-virtual-fields
git_commit_date	1718015534	1718015615
git_commit_sha	`7087a81`	`f613d36`
release_version	1.36.0-SNAPSHOT~7087a8148b	1.36.0-SNAPSHOT~f613d36219

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718018453	1718018453
ci_job_id	537279835	537279835
ci_pipeline_id	36262418	36262418
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 18 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060528
Total [baseline] (8.531 s) : 0, 8531341
Agent [candidate] (1.058 s) : 0, 1058279
Total [candidate] (8.524 s) : 0, 8523925
section iast
Agent [baseline] (1.175 s) : 0, 1174787
Total [baseline] (8.97 s) : 0, 8970152
Agent [candidate] (1.166 s) : 0, 1166215
Total [candidate] (8.993 s) : 0, 8993201
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174980
Total [baseline] (8.963 s) : 0, 8962729
Agent [candidate] (1.173 s) : 0, 1172699
Total [candidate] (9.027 s) : 0, 9027136
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1163629
Total [baseline] (8.99 s) : 0, 8990332
Agent [candidate] (1.171 s) : 0, 1170764
Total [candidate] (9.002 s) : 0, 9002060

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	iast	1.175 s	114.259 ms (10.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.175 s	114.453 ms (10.8%)
Agent	iast_TELEMETRY_OFF	1.164 s	103.101 ms (9.7%)
Total	tracing	8.531 s	-
Total	iast	8.97 s	438.811 ms (5.1%)
Total	iast_HARDCODED_SECRET_DISABLED	8.963 s	431.388 ms (5.1%)
Total	iast_TELEMETRY_OFF	8.99 s	458.991 ms (5.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.058 s	-
Agent	iast	1.166 s	107.936 ms (10.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	114.42 ms (10.8%)
Agent	iast_TELEMETRY_OFF	1.171 s	112.484 ms (10.6%)
Total	tracing	8.524 s	-
Total	iast	8.993 s	469.277 ms (5.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.027 s	503.211 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.002 s	478.135 ms (5.6%)

gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.901 ms) : 0, 663901
BytebuddyAgent [candidate] (662.676 ms) : 0, 662676
GlobalTracer [baseline] (303.386 ms) : 0, 303386
GlobalTracer [candidate] (302.699 ms) : 0, 302699
AppSec [baseline] (50.191 ms) : 0, 50191
AppSec [candidate] (49.931 ms) : 0, 49931
Logs Intake [baseline] (397.853 µs) : 0, 398
Logs Intake [candidate] (409.717 µs) : 0, 410
Remote Config [baseline] (677.438 µs) : 0, 677
Remote Config [candidate] (655.361 µs) : 0, 655
Telemetry [baseline] (7.549 ms) : 0, 7549
Telemetry [candidate] (7.534 ms) : 0, 7534
section iast
BytebuddyAgent [baseline] (783.424 ms) : 0, 783424
BytebuddyAgent [candidate] (777.546 ms) : 0, 777546
GlobalTracer [baseline] (294.678 ms) : 0, 294678
GlobalTracer [candidate] (292.413 ms) : 0, 292413
AppSec [baseline] (47.099 ms) : 0, 47099
AppSec [candidate] (47.055 ms) : 0, 47055
Logs Intake [baseline] (303.773 µs) : 0, 304
Logs Intake [candidate] (304.782 µs) : 0, 305
Remote Config [baseline] (597.98 µs) : 0, 598
Remote Config [candidate] (611.058 µs) : 0, 611
Telemetry [baseline] (8.582 ms) : 0, 8582
Telemetry [candidate] (8.499 ms) : 0, 8499
IAST [baseline] (26.736 ms) : 0, 26736
IAST [candidate] (26.459 ms) : 0, 26459
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.801 ms) : 0, 782801
BytebuddyAgent [candidate] (779.44 ms) : 0, 779440
GlobalTracer [baseline] (295.475 ms) : 0, 295475
GlobalTracer [candidate] (295.936 ms) : 0, 295936
AppSec [baseline] (46.871 ms) : 0, 46871
AppSec [candidate] (47.083 ms) : 0, 47083
Logs Intake [baseline] (302.766 µs) : 0, 303
Logs Intake [candidate] (306.935 µs) : 0, 307
Remote Config [baseline] (572.263 µs) : 0, 572
Remote Config [candidate] (580.002 µs) : 0, 580
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (9.246 ms) : 0, 9246
IAST [baseline] (27.188 ms) : 0, 27188
IAST [candidate] (26.733 ms) : 0, 26733
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.451 ms) : 0, 775451
BytebuddyAgent [candidate] (780.08 ms) : 0, 780080
GlobalTracer [baseline] (293.416 ms) : 0, 293416
GlobalTracer [candidate] (296.481 ms) : 0, 296481
AppSec [baseline] (47.054 ms) : 0, 47054
AppSec [candidate] (49.277 ms) : 0, 49277
Logs Intake [baseline] (300.987 µs) : 0, 301
Logs Intake [candidate] (303.77 µs) : 0, 304
Remote Config [baseline] (559.076 µs) : 0, 559
Remote Config [candidate] (564.701 µs) : 0, 565
Telemetry [baseline] (8.295 ms) : 0, 8295
Telemetry [candidate] (6.925 ms) : 0, 6925
IAST [baseline] (25.232 ms) : 0, 25232
IAST [candidate] (23.739 ms) : 0, 23739

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060925
Total [baseline] (10.394 s) : 0, 10394329
Agent [candidate] (1.064 s) : 0, 1064424
Total [candidate] (10.347 s) : 0, 10347404
section appsec
Agent [baseline] (1.178 s) : 0, 1178296
Total [baseline] (10.5 s) : 0, 10500061
Agent [candidate] (1.186 s) : 0, 1185991
Total [candidate] (10.479 s) : 0, 10478974
section iast
Agent [baseline] (1.169 s) : 0, 1169001
Total [baseline] (10.685 s) : 0, 10685179
Agent [candidate] (1.168 s) : 0, 1168356
Total [candidate] (10.702 s) : 0, 10701897
section profiling
Agent [baseline] (1.256 s) : 0, 1256123
Total [baseline] (10.558 s) : 0, 10558291
Agent [candidate] (1.268 s) : 0, 1268176
Total [candidate] (10.72 s) : 0, 10719552

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.178 s	117.372 ms (11.1%)
Agent	iast	1.169 s	108.077 ms (10.2%)
Agent	profiling	1.256 s	195.198 ms (18.4%)
Total	tracing	10.394 s	-
Total	appsec	10.5 s	105.732 ms (1.0%)
Total	iast	10.685 s	290.85 ms (2.8%)
Total	profiling	10.558 s	163.962 ms (1.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.186 s	121.567 ms (11.4%)
Agent	iast	1.168 s	103.932 ms (9.8%)
Agent	profiling	1.268 s	203.752 ms (19.1%)
Total	tracing	10.347 s	-
Total	appsec	10.479 s	131.57 ms (1.3%)
Total	iast	10.702 s	354.493 ms (3.4%)
Total	profiling	10.72 s	372.148 ms (3.6%)

gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.37 ms) : 0, 664370
BytebuddyAgent [candidate] (667.7 ms) : 0, 667700
GlobalTracer [baseline] (303.435 ms) : 0, 303435
GlobalTracer [candidate] (303.236 ms) : 0, 303236
AppSec [baseline] (50.297 ms) : 0, 50297
AppSec [candidate] (50.3 ms) : 0, 50300
Logs Intake [baseline] (411.23 µs) : 0, 411
Logs Intake [candidate] (393.693 µs) : 0, 394
Remote Config [baseline] (664.112 µs) : 0, 664
Remote Config [candidate] (681.997 µs) : 0, 682
Telemetry [baseline] (7.517 ms) : 0, 7517
Telemetry [candidate] (7.56 ms) : 0, 7560
section appsec
BytebuddyAgent [baseline] (674.472 ms) : 0, 674472
BytebuddyAgent [candidate] (679.037 ms) : 0, 679037
GlobalTracer [baseline] (296.585 ms) : 0, 296585
GlobalTracer [candidate] (298.877 ms) : 0, 298877
AppSec [baseline] (152.863 ms) : 0, 152863
AppSec [candidate] (153.353 ms) : 0, 153353
Logs Intake [baseline] (331.077 µs) : 0, 331
Logs Intake [candidate] (330.99 µs) : 0, 331
Remote Config [baseline] (635.455 µs) : 0, 635
Remote Config [candidate] (641.429 µs) : 0, 641
Telemetry [baseline] (8.827 ms) : 0, 8827
Telemetry [candidate] (8.454 ms) : 0, 8454
IAST [baseline] (20.443 ms) : 0, 20443
IAST [candidate] (21.237 ms) : 0, 21237
section iast
BytebuddyAgent [baseline] (779.305 ms) : 0, 779305
BytebuddyAgent [candidate] (778.73 ms) : 0, 778730
GlobalTracer [baseline] (293.272 ms) : 0, 293272
GlobalTracer [candidate] (292.968 ms) : 0, 292968
AppSec [baseline] (47.01 ms) : 0, 47010
AppSec [candidate] (46.877 ms) : 0, 46877
Logs Intake [baseline] (302.089 µs) : 0, 302
Logs Intake [candidate] (308.283 µs) : 0, 308
Remote Config [baseline] (591.421 µs) : 0, 591
Remote Config [candidate] (586.892 µs) : 0, 587
Telemetry [baseline] (9.957 ms) : 0, 9957
Telemetry [candidate] (7.624 ms) : 0, 7624
IAST [baseline] (25.301 ms) : 0, 25301
IAST [candidate] (28.0 ms) : 0, 28000
section profiling
BytebuddyAgent [baseline] (660.253 ms) : 0, 660253
BytebuddyAgent [candidate] (666.918 ms) : 0, 666918
GlobalTracer [baseline] (384.983 ms) : 0, 384983
GlobalTracer [candidate] (387.661 ms) : 0, 387661
AppSec [baseline] (50.48 ms) : 0, 50480
AppSec [candidate] (51.069 ms) : 0, 51069
Logs Intake [baseline] (331.008 µs) : 0, 331
Logs Intake [candidate] (336.009 µs) : 0, 336
Remote Config [baseline] (732.706 µs) : 0, 733
Remote Config [candidate] (750.933 µs) : 0, 751
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (7.44 ms) : 0, 7440
ProfilingAgent [baseline] (95.543 ms) : 0, 95543
ProfilingAgent [candidate] (96.941 ms) : 0, 96941
Profiling [baseline] (95.567 ms) : 0, 95567
Profiling [candidate] (96.966 ms) : 0, 96966

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-10T10:51:44	2024-06-10T10:58:37
git_branch	master	mcculls/map-otel-virtual-fields
git_commit_date	1718015534	1718015615
git_commit_sha	`7087a81`	`f613d36`
release_version	1.36.0-SNAPSHOT~7087a8148b	1.36.0-SNAPSHOT~f613d36219
start_time	2024-06-10T10:51:31	2024-06-10T10:58:23

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718017464	1718017464
ci_job_id	537279836	537279836
ci_pipeline_id	36262418	36262418
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1383
.   : milestone, 1364,
appsec (1.723 ms) : 1699, 1748
.   : milestone, 1723,
appsec_no_iast (1.718 ms) : 1693, 1742
.   : milestone, 1718,
iast (1.498 ms) : 1475, 1520
.   : milestone, 1498,
profiling (1.536 ms) : 1510, 1562
.   : milestone, 1536,
tracing (1.489 ms) : 1465, 1513
.   : milestone, 1489,
section candidate
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.732 ms) : 1708, 1757
.   : milestone, 1732,
appsec_no_iast (1.718 ms) : 1693, 1742
.   : milestone, 1718,
iast (1.488 ms) : 1465, 1511
.   : milestone, 1488,
profiling (1.51 ms) : 1484, 1536
.   : milestone, 1510,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.364 ms [1.344 ms, 1.383 ms]	-
appsec	1.723 ms [1.699 ms, 1.748 ms]	359.633 µs (26.4%)
appsec_no_iast	1.718 ms [1.693 ms, 1.742 ms]	354.009 µs (26.0%)
iast	1.498 ms [1.475 ms, 1.52 ms]	133.974 µs (9.8%)
profiling	1.536 ms [1.51 ms, 1.562 ms]	172.019 µs (12.6%)
tracing	1.489 ms [1.465 ms, 1.513 ms]	125.582 µs (9.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.348 ms [1.329 ms, 1.367 ms]	-
appsec	1.732 ms [1.708 ms, 1.757 ms]	384.315 µs (28.5%)
appsec_no_iast	1.718 ms [1.693 ms, 1.742 ms]	369.583 µs (27.4%)
iast	1.488 ms [1.465 ms, 1.511 ms]	140.203 µs (10.4%)
profiling	1.51 ms [1.484 ms, 1.536 ms]	161.757 µs (12.0%)
tracing	1.471 ms [1.447 ms, 1.495 ms]	122.869 µs (9.1%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.855 µs) : 353, 392
.   : milestone, 373,
iast (482.593 µs) : 462, 504
.   : milestone, 483,
iast_FULL (559.51 µs) : 538, 581
.   : milestone, 560,
iast_GLOBAL (514.727 µs) : 493, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (496.76 µs) : 475, 519
.   : milestone, 497,
iast_INACTIVE (461.419 µs) : 440, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (477.89 µs) : 457, 499
.   : milestone, 478,
tracing (451.337 µs) : 430, 473
.   : milestone, 451,
section candidate
no_agent (373.603 µs) : 354, 393
.   : milestone, 374,
iast (484.964 µs) : 464, 506
.   : milestone, 485,
iast_FULL (558.976 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (519.757 µs) : 497, 543
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (491.535 µs) : 470, 513
.   : milestone, 492,
iast_INACTIVE (457.844 µs) : 437, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (475.865 µs) : 455, 497
.   : milestone, 476,
tracing (448.058 µs) : 426, 470
.   : milestone, 448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.855 µs [353.442 µs, 392.268 µs]	-
iast	482.593 µs [461.556 µs, 503.63 µs]	109.738 µs (29.4%)
iast_FULL	559.51 µs [538.177 µs, 580.843 µs]	186.655 µs (50.1%)
iast_GLOBAL	514.727 µs [493.175 µs, 536.279 µs]	141.872 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED	496.76 µs [474.677 µs, 518.843 µs]	123.905 µs (33.2%)
iast_INACTIVE	461.419 µs [440.241 µs, 482.597 µs]	88.564 µs (23.8%)
iast_TELEMETRY_OFF	477.89 µs [456.751 µs, 499.03 µs]	105.035 µs (28.2%)
tracing	451.337 µs [430.145 µs, 472.529 µs]	78.482 µs (21.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.603 µs [354.198 µs, 393.008 µs]	-
iast	484.964 µs [463.531 µs, 506.396 µs]	111.361 µs (29.8%)
iast_FULL	558.976 µs [537.812 µs, 580.14 µs]	185.373 µs (49.6%)
iast_GLOBAL	519.757 µs [496.91 µs, 542.604 µs]	146.154 µs (39.1%)
iast_HARDCODED_SECRET_DISABLED	491.535 µs [470.262 µs, 512.808 µs]	117.932 µs (31.6%)
iast_INACTIVE	457.844 µs [436.706 µs, 478.982 µs]	84.241 µs (22.5%)
iast_TELEMETRY_OFF	475.865 µs [454.57 µs, 497.159 µs]	102.262 µs (27.4%)
tracing	448.058 µs [426.492 µs, 469.625 µs]	74.456 µs (19.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/map-otel-virtual-fields
git_commit_date	1718015534	1718015615
git_commit_sha	`7087a81`	`f613d36`
release_version	1.36.0-SNAPSHOT~7087a8148b	1.36.0-SNAPSHOT~f613d36219

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1718018086	1718018086
ci_job_id	537279837	537279837
ci_pipeline_id	36262418	36262418
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
.   : milestone, 1481,
appsec (2.215 ms) : 2181, 2249
.   : milestone, 2215,
iast (1.981 ms) : 1939, 2022
.   : milestone, 1981,
iast_GLOBAL (2.017 ms) : 1976, 2058
.   : milestone, 2017,
profiling (1.882 ms) : 1848, 1917
.   : milestone, 1882,
tracing (1.852 ms) : 1820, 1884
.   : milestone, 1852,
section candidate
no_agent (1.473 ms) : 1461, 1485
.   : milestone, 1473,
appsec (2.233 ms) : 2198, 2267
.   : milestone, 2233,
iast (1.983 ms) : 1942, 2025
.   : milestone, 1983,
iast_GLOBAL (2.026 ms) : 1985, 2067
.   : milestone, 2026,
profiling (1.875 ms) : 1840, 1910
.   : milestone, 1875,
tracing (1.849 ms) : 1817, 1882
.   : milestone, 1849,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.469 ms, 1.493 ms]	-
appsec	2.215 ms [2.181 ms, 2.249 ms]	733.565 µs (49.5%)
iast	1.981 ms [1.939 ms, 2.022 ms]	499.881 µs (33.8%)
iast_GLOBAL	2.017 ms [1.976 ms, 2.058 ms]	535.781 µs (36.2%)
profiling	1.882 ms [1.848 ms, 1.917 ms]	401.336 µs (27.1%)
tracing	1.852 ms [1.82 ms, 1.884 ms]	370.736 µs (25.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.485 ms]	-
appsec	2.233 ms [2.198 ms, 2.267 ms]	759.561 µs (51.6%)
iast	1.983 ms [1.942 ms, 2.025 ms]	510.193 µs (34.6%)
iast_GLOBAL	2.026 ms [1.985 ms, 2.067 ms]	552.768 µs (37.5%)
profiling	1.875 ms [1.84 ms, 1.91 ms]	402.3 µs (27.3%)
tracing	1.849 ms [1.817 ms, 1.882 ms]	376.451 µs (25.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~f613d36219, baseline=1.36.0-SNAPSHOT~7087a8148b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.5 s) : 15500000, 15500000
.   : milestone, 15500000,
appsec (15.134 s) : 15134000, 15134000
.   : milestone, 15134000,
iast (18.807 s) : 18807000, 18807000
.   : milestone, 18807000,
iast_GLOBAL (17.931 s) : 17931000, 17931000
.   : milestone, 17931000,
profiling (16.058 s) : 16058000, 16058000
.   : milestone, 16058000,
tracing (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
section candidate
no_agent (15.696 s) : 15696000, 15696000
.   : milestone, 15696000,
appsec (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
iast (18.601 s) : 18601000, 18601000
.   : milestone, 18601000,
iast_GLOBAL (17.881 s) : 17881000, 17881000
.   : milestone, 17881000,
profiling (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
tracing (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.5 s [15.5 s, 15.5 s]	-
appsec	15.134 s [15.134 s, 15.134 s]	-366.0 ms (-2.4%)
iast	18.807 s [18.807 s, 18.807 s]	3.307 s (21.3%)
iast_GLOBAL	17.931 s [17.931 s, 17.931 s]	2.431 s (15.7%)
profiling	16.058 s [16.058 s, 16.058 s]	558.0 ms (3.6%)
tracing	14.955 s [14.955 s, 14.955 s]	-545.0 ms (-3.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.696 s [15.696 s, 15.696 s]	-
appsec	14.971 s [14.971 s, 14.971 s]	-725.0 ms (-4.6%)
iast	18.601 s [18.601 s, 18.601 s]	2.905 s (18.5%)
iast_GLOBAL	17.881 s [17.881 s, 17.881 s]	2.185 s (13.9%)
profiling	14.984 s [14.984 s, 14.984 s]	-712.0 ms (-4.5%)
tracing	15.022 s [15.022 s, 15.022 s]	-674.0 ms (-4.3%)

PerfectSlayer

LGTM 👍

...gent-otel/otel-tooling/src/main/java/datadog/opentelemetry/tooling/OtelMethodCallMapper.java

* Map virtual field usage into context store request * Use Type.getInternalName to help future refactoring * Allow advanced mapping of OpenTelemetry method calls * Map OpenTelemetry VirtualField to Datadog ContextStore

mcculls added tag: no release notes Changes to exclude from release notes inst: opentelemetry OpenTelemetry instrumentation labels Jun 5, 2024

mcculls marked this pull request as ready for review June 5, 2024 15:14

mcculls requested a review from a team as a code owner June 5, 2024 15:14

mcculls requested review from PerfectSlayer and ygree June 5, 2024 15:14

mcculls force-pushed the mcculls/map-otel-virtual-fields branch 2 times, most recently from 678d6f1 to 04fa9c6 Compare June 8, 2024 10:05

mcculls changed the base branch from master to mcculls/fix-extension-bytecode-cache June 8, 2024 10:05

mcculls removed the tag: no release notes Changes to exclude from release notes label Jun 8, 2024

PerfectSlayer approved these changes Jun 10, 2024

View reviewed changes

...gent-otel/otel-tooling/src/main/java/datadog/opentelemetry/tooling/OtelMethodCallMapper.java Show resolved Hide resolved

Base automatically changed from mcculls/fix-extension-bytecode-cache to master June 10, 2024 10:32

mcculls added 5 commits June 10, 2024 11:33

Map virtual field usage into context store request

a883b9e

Use Type.getInternalName to help future refactoring

cc74766

Simplify collections

acac1b5

Allow advanced mapping of OpenTelemetry method calls

52036b3

Map OpenTelemetry VirtualField to Datadog ContextStore

f613d36

mcculls force-pushed the mcculls/map-otel-virtual-fields branch from 04fa9c6 to f613d36 Compare June 10, 2024 10:34

mcculls merged commit 1b6b7fd into master Jun 10, 2024
81 checks passed

mcculls deleted the mcculls/map-otel-virtual-fields branch June 10, 2024 11:26

github-actions bot added this to the 1.36.0 milestone Jun 10, 2024

mcculls mentioned this pull request Jun 12, 2024

Map OpenTelemetry VirtualField to Datadog ContextStore #7171

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Map OpenTelemetry VirtualField to Datadog ContextStore #7129

Map OpenTelemetry VirtualField to Datadog ContextStore #7129

mcculls commented Jun 5, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Jun 5, 2024 •

edited

Loading

PerfectSlayer left a comment

Map OpenTelemetry VirtualField to Datadog ContextStore #7129

Map OpenTelemetry VirtualField to Datadog ContextStore #7129

Conversation

mcculls commented Jun 5, 2024 • edited by jira bot Loading

pr-commenter bot commented Jun 5, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

PerfectSlayer left a comment

Choose a reason for hiding this comment

mcculls commented Jun 5, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Jun 5, 2024 •

edited

Loading